New issue
Advanced search Search tips

Issue 783808 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

pobfuzz: SkTextBlob::MakeFromBuffer -> SkReadBuffer::readRect null deref

Project Member Reported by ClusterFuzz, Nov 10 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6011164436987904

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  SkReadBuffer::readRect
  SkTextBlob::MakeFromBuffer
  SkTextBlob::Deserialize
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=514197:514231

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6011164436987904

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 

Comment 1 by enne@chromium.org, Nov 10 2017

Cc: khushals...@chromium.org enne@chromium.org
Labels: -Pri-1 Pri-2
Owner: vmp...@chromium.org
Status: Assigned (was: Untriaged)
Summary: pobfuzz: SkTextBlob::MakeFromBuffer -> SkReadBuffer::readRect null deref (was: Null-dereference READ in SkReadBuffer::readRect)

Comment 2 by enne@chromium.org, Nov 10 2017

Components: Internals>Compositing>Rasterization
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cfacc551f44e0f9d85ea50c86005ed847b2cc55

commit 0cfacc551f44e0f9d85ea50c86005ed847b2cc55
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Sun Nov 12 07:16:58 2017

cc/paint: Validate SkData for text blob deserialization.

This patch verifies that the SkData we use to deserialize a text blob
looks correct (and will not cause an assert in Skia).

R=enne@chromium.org

Bug:  783808 ,  783815 ,  783828 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib07666354827a70dd4a95a589c60ab12b5e61ae7
Reviewed-on: https://chromium-review.googlesource.com/764582
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515862}
[modify] https://crrev.com/0cfacc551f44e0f9d85ea50c86005ed847b2cc55/cc/paint/paint_op_reader.cc

Project Member

Comment 4 by ClusterFuzz, Nov 13 2017

ClusterFuzz has detected this issue as fixed in range 515861:515862.

Detailed report: https://clusterfuzz.com/testcase?key=6011164436987904

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  SkReadBuffer::readRect
  SkTextBlob::MakeFromBuffer
  SkTextBlob::Deserialize
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=514197:514231
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=515861:515862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6011164436987904

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Nov 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6011164436987904 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment