New issue
Advanced search Search tips

Issue 783803 link

Starred by 3 users
Status: Assigned
Owner:
mcasas@chromium.org
Cc:
acourbot@chromium.org
zmo@chromium.org
mcasas@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Consider removing vaapi_wrapper.cc VADisplayState::va_initialized_ variable

Project Member Reported by mcasas@chromium.org, Nov 10 2017 
vaapi_wrapper.cc internal class VADisplayState has an internal
variable |va_initialized_| with the sole intention of [1]:

// Must check if vaInitialize completed successfully, to work around a bug in
// libva. The bug was fixed upstream:
// http://lists.freedesktop.org/archives/libva/2013-July/001807.html
// TODO(mgiuca): Remove this check, and the |va_initialized_| variable, once
// the fix has rolled out sufficiently.

Which seems sufficiently rolled, at least from v1.7.3 POV:
https://github.com/01org/libva/blob/libva-1.7.3/va/va.c#L616


[1] https://cs.chromium.org/chromium/src/media/gpu/vaapi_wrapper.cc?type=cs&q=VADisplayState::Deinitialize&sq=package:chromium&l=275

Comment 1 by uzair.ja...@samsung.com, Nov 16 2017 

Hi

https://chromium-review.googlesource.com/c/chromium/src/+/773700

Please can you take a look.

Thanks
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 16

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by vmi...@chromium.org, Nov 16

Cc: zmo@chromium.org
Labels: -Type-Bug Type-Feature
Owner: mcasas@chromium.org
Status: Assigned (was: Untriaged)
mcasas: Could you please review if this is still valid?
►

Sign in to add a comment