New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783795 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 782771
Owner: ----
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

50.3% improvement in blink_perf.owp_storage at 514279:514374

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

Suspiciously large improvement.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783795

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9420b3ac0449a090c79caf159d32c7f20d93599da8c796ff8a13ab2f7ebaaa0b


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

Mergedinto: 782771
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Nate Chapin
  Commit : 1aec1a92fb786cae0a24ff2b22d4858d4486252e
  Date   : Mon Nov 06 23:47:59 2017
  Subject: Make script cache hits async

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : blink_perf.owp_storage
  Metric       : IDBFactory::open/IDBFactory::open
  Change       : 43.00% | 1.86919166665 -> 1.06537499999

Revision             Result                    N
chromium@514278      1.86919 +- 0.586833       6      good
chromium@514290      2.09982 +- 0.637668       6      good
chromium@514296      1.81503 +- 0.303008       6      good
chromium@514298      1.80886 +- 0.555518       6      good
chromium@514299      0.911842 +- 0.32531       6      bad       <--
chromium@514302      0.957592 +- 0.33288       6      bad
chromium@514326      0.836258 +- 0.369299      6      bad
chromium@514374      1.06537 +- 0.357113       6      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.owp_storage

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963299138381750576


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment