New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783793 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Pen input does not set modifier flags on event

Reported by mistermu...@googlemail.com, Nov 10 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.40 Safari/537.36

Steps to reproduce the problem:
1. Add an event listener to the document for pointermove or mousemove
2. Log evt.ctrlKey, evt.altKey or evt.shiftKey to console
3. Use a pen to create "pen" pointer/mousemove events and press one of the modifiers

What is the expected behavior?
The flag for the pressed modifier should be set to true.

What went wrong?
No flags are true.

Did this work before? N/A 

Chrome version: 62.0.3202.89  Channel: stable
OS Version: 10.0
Flash Version: 

Tested on Microsoft Surface.
 
pentest.html
1.1 KB View Download

Comment 1 by kochi@chromium.org, Nov 10 2017

Components: -Blink Blink>Input
Cc: dtapu...@chromium.org
Labels: Needs-Triage-M63
Cc: sc00335...@techmahindra.com
Labels: Needs-Feedback Triaged-ET
Unable to reproduce this issue on reported version 62.0.3202.89 and on latest canary 64.0.3267.0 using Microsoft surface pro with steps mentioned below.

1. Opened attached HTML file in browser.
2. Scrolled up and down using touch and pen -- Observed Pointer and mouse move with false 

@Reporter: Could you please let us know whether the steps are correct or not. And also could you please let us know how to add event listeners to attached HTML file.

Thanks!

783793.mp4
5.8 MB View Download
@sc00335...@techmahindra.com Additionally, press one of the modifier keys CTRL, SHIFT or ALT while dragging the pen. The output should log "true" for the pressed modifier. However, it does not. 
Of course to do this you will have to connect a keyboard to the Surface Pro.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 13 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: dtapu...@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ce3ca0f5b68783ccff971c399c1b89968258006

commit 4ce3ca0f5b68783ccff971c399c1b89968258006
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Tue Nov 14 14:47:28 2017

Modifier flags from keyboard were not propagated to pen events.

Ensure we mask on the current keyboard modifer state so that all
modifier keys can be detected.

BUG= 783793 

Change-Id: I0dd0cfaabc32f6a8df0cbea793bbac43dbe3dcb6
Reviewed-on: https://chromium-review.googlesource.com/766667
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516300}
[modify] https://crrev.com/4ce3ca0f5b68783ccff971c399c1b89968258006/ui/views/win/pen_event_processor.cc
[modify] https://crrev.com/4ce3ca0f5b68783ccff971c399c1b89968258006/ui/views/win/pen_event_processor_unittest.cc

Labels: M-64
Status: Fixed (was: Assigned)

Sign in to add a comment