Ideally, AudioPermissionPrompt should be composited by a Rect background, microphone VectorIcon, a text element and two buttons. There is no need for a special audio_permission_prompt_texture, so it should be removed.
FYI: See issue 784369 for more general improvement.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91672359e6836cf6ae344afc868485ee4db450b3 commit 91672359e6836cf6ae344afc868485ee4db450b3 Author: Christopher Grant <cjgrant@chromium.org> Date: Tue May 08 18:24:23 2018 VR: Compose exit prompt from UI elements Remove the last remaining monolithic texture-based element. Now, all element are composed of basic rectangle, text and icon elements. A follow-on change can move text helper code out of UiTexture, into the Text class. BUG= 783788 Prompt testing R=tiborg Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Ida9a2a91e47199445acd97d9bdf22dc84c6cfcf5 Reviewed-on: https://chromium-review.googlesource.com/1048322 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556883} [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/elements/button.cc [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/elements/button.h [delete] https://crrev.com/8b972f42ae070f4ba06ba4ac39379d14d714c373/chrome/browser/vr/elements/prompt.cc [delete] https://crrev.com/8b972f42ae070f4ba06ba4ac39379d14d714c373/chrome/browser/vr/elements/prompt.h [delete] https://crrev.com/8b972f42ae070f4ba06ba4ac39379d14d714c373/chrome/browser/vr/elements/prompt_texture.cc [delete] https://crrev.com/8b972f42ae070f4ba06ba4ac39379d14d714c373/chrome/browser/vr/elements/prompt_texture.h [delete] https://crrev.com/8b972f42ae070f4ba06ba4ac39379d14d714c373/chrome/browser/vr/elements/prompt_unittest.cc [add] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/elements/text_button.cc [add] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/elements/text_button.h [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/elements/ui_element_type.cc [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/elements/ui_element_type.h [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/model/modal_prompt_type.cc [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/model/modal_prompt_type.h [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/test/ui_test.cc [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/test/ui_test.h [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/ui.cc [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/ui_input_manager_unittest.cc [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/91672359e6836cf6ae344afc868485ee4db450b3/chrome/browser/vr/ui_unittest.cc
Comment 1 by asimjour@chromium.org
, Nov 21 2017