New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783785 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.9% regression in smoothness.tough_canvas_cases at 515064:515124

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783785

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d0ee4550ab9a6be6cec270f98315983dc85107f4fcb87127e7e74ecdd688d2e8


Bot(s) for this bug's original alert(s):

chromium-rel-win7-x64-dual
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 10 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: win_x64_perf_bisect
  Benchmark    : smoothness.tough_canvas_cases
  Metric       : frame_times/http___www.craftymind.com_factory_guimark2_HTML5ChartingTest.html

Revision             Result                  N
chromium@515063      18.8191 +- 1.94023      21      good
chromium@515124      18.8362 +- 1.88013      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...www.craftymind.com.factory.guimark2.HTML5ChartingTest.html smoothness.tough_canvas_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963300514301580928


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/164fa1cef80000
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

Cc: junov@chromium.org
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/164fa1cef80000

Reland: Refactor of Canvas2DLayerBridge resource model
By junov@chromium.org ยท Wed Nov 08 23:26:00 2017
chromium @ 5b07996e178c5f4e153e771d48ab839867fa7440

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
junov: ping on this regression? It hasn't recovered.
Components: Internals>GPU>Metrics

Comment 8 by junov@chromium.org, Apr 30 2018

Status: WontFix (was: Assigned)
The culprit CL is: https://chromium-review.googlesource.com/c/chromium/src/+/728340

This change modified performance characteristics of 2D canvas. Overall it was a good change.  This is the only test that saw a measurable regression (on only one platform), and almost all other tests got a performance improvement.

Let's take this as a positive trade-off

Sign in to add a comment