New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783780 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 781132



Sign in to add a comment

[autotest] Server side tests failing due to "unexpected keyword argument 'alive_count_max'"

Project Member Reported by dtosic@chromium.org, Nov 10 2017

Issue description

Autotest failures in server side tests:

11/10 04:58:03.077 ERROR|        server_job:0864| Exception escaped control file, job aborting:
Traceback (most recent call last):
  File "/usr/local/autotest/server/server_job.py", line 856, in run
    self._execute_code(server_control_file, namespace)
  File "/usr/local/autotest/server/server_job.py", line 1357, in _execute_code
    execfile(code_file, namespace, namespace)
  File "/usr/local/autotest/results/155393242-chromeos-test/control.srv", line 32, in <module>
    parallel_simple(run_test, machines)
  File "/usr/local/autotest/server/subcommand.py", line 98, in parallel_simple
    function(arg)
  File "/usr/local/autotest/results/155393242-chromeos-test/control.srv", line 28, in run_test
    host = hosts.create_host(machine, servo_args=servo_args)
  File "/usr/local/autotest/server/hosts/factory.py", line 196, in create_host
    host_instance = custom_host_class(hostname, **args)
  File "/usr/local/autotest/server/hosts/base_classes.py", line 56, in __init__
    super(Host, self).__init__(*args, **dargs)
  File "/usr/local/autotest/client/common_lib/hosts/base_classes.py", line 69, in __init__
    self._initialize(*args, **dargs)
  File "/usr/local/autotest/server/hosts/cros_host.py", line 313, in _initialize
    try_servo_repair=try_servo_repair)
  File "/usr/local/autotest/server/hosts/servo_host.py", line 848, in create_servo_host
    newhost.repair(silent=True)
  File "/usr/local/autotest/server/hosts/servo_host.py", line 620, in repair
    self._repair_strategy.repair(self, silent)
  File "/usr/local/autotest/client/common_lib/hosts/repair.py", line 774, in repair
    self._verify_root._verify_host(host, silent)
  File "/usr/local/autotest/client/common_lib/hosts/repair.py", line 348, in _verify_host
    self._verify_dependencies(host, silent)
  File "/usr/local/autotest/client/common_lib/hosts/repair.py", line 226, in _verify_dependencies
    self._verify_list(host, self._dependency_list, silent)
  File "/usr/local/autotest/client/common_lib/hosts/repair.py", line 216, in _verify_list
    raise AutoservVerifyDependencyError(self, failures)

AutoservVerifyDependencyError: make_ssh_command() got an unexpected keyword argument 'alive_count_max'

Seems all server side tests are failing as of R64-10114.0.0
 

Comment 1 by ar...@chromium.org, Nov 10 2017

Owner: deanliao@chromium.org
Status: Assigned (was: Untriaged)
Is it possible that crrev.com/c/756077 is the culprit of this issue? That seems the change that addded alive_count_max as a parameter.

Assigning to deanliao@ to take a look. Please re-assign to the right owner if I am wrong :)

Comment 2 by dtosic@chromium.org, Nov 13 2017

Cc: katierh@chromium.org
Blocking: 781132

Comment 4 by dtosic@chromium.org, Nov 13 2017

Not sure how this bug is blocking an already fixed bug?
If this was a type, then it still doesn't make sense.

https://crrev.com/c/756077 does not resolve the issue here.
If a setup has a servo then the tests still fails. 

https://crrev.com/c/756077 is part of 10112.0.0, but our tests are still failing as of 10114.0 per http://stainless/search?col=build&exclude_non_release=true&exclude_cts=true&suite=%5Ehotrod%24&row=test&view=matrix&first_date=20171107&last_date=20171113

Please treat this a hight priority, not server side tests that test the chromebox for meetings are running.

Comment 5 by dtosic@chromium.org, Nov 13 2017

Any update on this?
dtosic@ sorry that the revert commit took some to merge. I should post the commit under review/CQ verify first. 

Comment 8 by dtosic@chromium.org, Nov 14 2017

Thanks for fixing!

Comment 9 by dtosic@chromium.org, Nov 14 2017

Any setup/test that uses a servo should be enough for verification.

A sample test from our side:
test_that --autotest_dir ~/trunk/src/third_party/autotest/files/  --board=<board> <pool:hotrod device> enterprise_CFM_Sanity

where the board and device should be picked from the pool:hotrod set.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e3e75f6d3bb17aed42bbd0c5e4614b1ed20007c4

commit e3e75f6d3bb17aed42bbd0c5e4614b1ed20007c4
Author: Dean Liao <deanliao@chromium.org>
Date: Thu Nov 16 18:46:57 2017

Revert "Revert "[telemetry_runner] Connect SSH host with non-default port.""

Reland it again after fixing bug (in servo_hsot.py).

BUG= chromium:783780 
TEST=Verify by running enterprise_CFM_Sanity.

Change-Id: I90c67a767577e6927cc2396f642503ee656a1a2b
Reviewed-on: https://chromium-review.googlesource.com/767831
Commit-Ready: Shuo-Peng Liao <deanliao@chromium.org>
Tested-by: Shuo-Peng Liao <deanliao@chromium.org>
Reviewed-by: Denis Tosic <dtosic@chromium.org>

[modify] https://crrev.com/e3e75f6d3bb17aed42bbd0c5e4614b1ed20007c4/server/hosts/abstract_ssh.py
[modify] https://crrev.com/e3e75f6d3bb17aed42bbd0c5e4614b1ed20007c4/server/hosts/cros_host.py
[modify] https://crrev.com/e3e75f6d3bb17aed42bbd0c5e4614b1ed20007c4/server/cros/telemetry_runner.py
[modify] https://crrev.com/e3e75f6d3bb17aed42bbd0c5e4614b1ed20007c4/server/hosts/ssh_host.py
[modify] https://crrev.com/e3e75f6d3bb17aed42bbd0c5e4614b1ed20007c4/server/hosts/servo_host.py

Status: Fixed (was: Assigned)

Sign in to add a comment