New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783778 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Dropdown length too short when #omnibox-ui-narrow-dropdown is enabled

Project Member Reported by gcomanici@chromium.org, Nov 10 2017

Issue description

When the flag #omnibox-ui-narrow-dropdown is enabled, the omnibox dropdown is cutting off the last suggestion. See attached screenshots.

Note: all other flags were set to default.

Chrome Version: 64.0.3260.2 (Official Build) dev (64-bit)

 
dropdown1.png
51.2 KB View Download
dropdown2.png
64.2 KB View Download
dropdown3.png
39.8 KB View Download

Comment 1 by k...@chromium.org, Nov 13 2017

Status: Available (was: Untriaged)
Bisected between 513360 and 513361.
Owner: tapted@chromium.org
Suspecting CL
https://chromium.googlesource.com/chromium/src/+/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

Over to tapted@
Labels: OS-Windows
Owner: jdonnelly@chromium.org
Status: Untriaged (was: Available)
If omnibox experiments break when Harmony is enabled, it's going to be on the omnibox team rather than the Harmony team to fix them -- we can support the primary UI, but not non-default experiments (due to bandwidth).

To jdonnelly to triage since I don't know who owns this experiment right now.

Also, confirming similar behavior on Windows.
Labels: -Pri-2 Pri-3
Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)
We don't currently have plans to turn this option on for any users, so this isn't high priority to fix. (The option exists for PMs and designers to try it out and figure out how it fits with other design changes being contemplated.)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10fd28c627d6bd70abb8388d9bbecea524bf0bc6

commit 10fd28c627d6bd70abb8388d9bbecea524bf0bc6
Author: Tommy C. Li <tommycli@chromium.org>
Date: Mon Dec 18 16:49:43 2017

Omnibox UI Experiments: Fix narrow-dropdown appearance for Harmony

Small fix to adjust the Omnibox suggestions dropdown for the new
Harmony (kSecondaryUiMd enabled) BubbleBorder.

Bug:  783778 
Change-Id: Id0b2a9e962aad098f46d53d1eedffad668639221
Reviewed-on: https://chromium-review.googlesource.com/831046
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524727}
[modify] https://crrev.com/10fd28c627d6bd70abb8388d9bbecea524bf0bc6/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Status: Fixed (was: Assigned)
Cc: sandeepkumars@chromium.org
Labels: Needs-Feedback
Tested the issue using #65.0.3298.3 on Linux Ubutnu 14.04, Win 10 as per the steps mentioned in comment #0.

Pre-condition
============
Enable #omnibox-ui-narrow-dropdown 

Note: 
1. This issue is not seen in Linux (Refer screenshot)
2. Issue is still reprodcuible in Win 10. (Refer screenshot)

@gcomanici: Please take a look at this issue.

Thanks!!
Windows.png
72.4 KB View Download
Linux.png
127 KB View Download
Labels: -Needs-Feedback TE-Verified-M65 TE-Verified-65.0.3299.0
Please ignore the above comment.

Tested the issue using #65.0.3299.0 on Linux Ubutnu 14.04, Win 10 as per the steps mentioned in comment #0. No chopping of text is seen.

Please find the screenshot's. Hence adding Verified labels.

Thanks!! 
Screenshot from 2017-12-19 17:01:31.png
195 KB View Download
WIn -99.png
59.6 KB View Download
Although the problem is not as obvious as in the previous version (i.e. text is not chopped off) it still feels odd to have the margin too close to the text, especially when using letters such as g,y,p etc.

see attached image, based on using Chrome 65.0.3294.5 (Official Build) dev (64-bit) on Ubunti 14.04 
AKu59HLPgEN.png
63.5 KB View Download
Status: Assigned (was: Fixed)
Reopening per comment #9.
gcomanici: Can you still reproduce it on Canary 3299 or later? It may not have hit the build you are on.
Labels: -OS-Linux
Verified in 65.0.3300.0 (Ubuntu 14.04) and the issue is fixed.
Status: Verified (was: Assigned)
Thanks!

Sign in to add a comment