New issue
Advanced search Search tips

Issue 783762 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
dpa...@chromium.org
aga...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature


Previous locations:
monorail:3177


Sign in to add a comment

FR: Support Fixes: ### in CL description to set status=Fixed in Monorail

Project Member Reported by dbeam@chromium.org, Nov 3 2017 
What steps will reproduce the problem?
(1) add FIXES=<bug_num> (as an alternative to BUG=) (or Fixes: )
(2) CL lands
(3) bug is updated

What is the expected output?
bug status is set to "Fixed" when CL lands and bug is updated with CL info.

What do you see instead?
FIXES= probably wouldn't be recognized

Please provide any additional information.
This is a common technique in other bug trackers.

Comment 1 by jeffcarp@chromium.org, Nov 3 2017 

How would this interact with the existing Bug: footer? It sounds like many CLs would have footers with duplicate values:

Bug:  1234 ,
Fixes: 1234

Comment 2 by dpa...@chromium.org, Nov 3 2017 

Suggetions:

Case 1:
"Bug:  1234 " would update the bug without closing it.

Case 2:
"Fixes: 1234" would update the bug and also close it.

Case 3:
"Bug:   1234 " and "Fixes: "1234", redundant but does same as Case 2

Case 4:
"Bug:  1234 , 5678 " and "Fixes: 1234" updates 1234 and 5678, closes 1234.

Comment 3 by aga...@chromium.org, Nov 10 2017 

This is more a feature request for Bugdroid than for Monorail.

But even while this would be relatively trivial to implement, we would need to talk to other stakeholders and make a policy decision about whether we want to do this, and what other tooling support (e.g. flags to "git cl upload" to set the Fixes: footer like it does the Bug: footer; support for parsing Fixes: in all of the other tools that look for Bug: footers; support for an Unfixes: footer so that reverts can set that??) would be necessary.

Comment 4 by aga...@chromium.org, Nov 10 2017

Project: chromium
Moved issue monorail:3177 to now be issue chromium:783762.

Comment 5 by aga...@chromium.org, Nov 10 2017

Cc: aga...@chromium.org
Components: Infra>Git Infra>SDK
Labels: -Priority-Medium -Type-Enhancement Pri-3 Type-Feature
Status: Unconfirmed (was: New)
Summary: FR: Support Fixes: ### in CL description to set status=Fixed in Monorail (was: FIXES=### in CL description sets status=Fixed in Monorail when landed)

Comment 6 by ehmaldonado@chromium.org, Aug 8

Status: Available (was: Unconfirmed)
Nice idea
►

Sign in to add a comment