New issue
Advanced search Search tips

Issue 783759 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 699530



Sign in to add a comment

[Password Manager] Username should be detected on CPF of https://cloud.digitalocean.com

Project Member Reported by kolos@chromium.org, Nov 10 2017

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Save credential https://cloud.digitalocean.com. There must only one entry in the password store (with non-empty username)
(2) Go to Profile Settings => Edit Profile
(3) Type new password and press "Update profile" (don't use generation)

What is the expected result?
Chrome should prompt to save the new password. 

What happens instead?
Chrome doesn't prompt.
 

Comment 1 by kolos@chromium.org, Nov 10 2017

Possible problem: PasswordFormManager.is_possible_change_password_form_without_username_ should should be updated every time CreatePendingCredentials is called. 

is_possible_change_password_form_without_username_ relies on new_password_element and username_element that may vary based on user input or Javascript changes.

Comment 2 by kolos@chromium.org, Nov 10 2017

hmmm, I just realized that Chrome does silent update. But then the problem is that fallback for such cases is not available, because the fallback relies on ShouldPromptUserToSavePassword which returns false for such cases. 

Comment 3 by kolos@chromium.org, Jan 26 2018

Blocking: -774955
Status: (was: Available)
Summary: [Password Manager] Username should be detected on CPF of https://cloud.digitalocean.com (was: [Password Manager] Password is not updated on https://cloud.digitalocean.com)
The problem from #1 should be resolved. We can retrieve the username value from CPF but don't do that because of constant |is_possible_change_password_form_without_username_|. 

Update actually happens. Adjusting the title. 

Comment 4 by kolos@chromium.org, Jan 26 2018

Blocking: 699530

Comment 5 by kolos@chromium.org, Jan 26 2018

Owner: kolos@chromium.org
Status: Assigned

Sign in to add a comment