New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 783734 link

Starred by 2 users
Status: Verified
Owner:
fukino@chromium.org
Closed: Nov 2017
Cc:
█ krajshree@chromium.org
ajha@chromium.org
█ oka@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Image preview is seen missing in General information page for multiple windows of Files App

Project Member Reported by mmanchala@chromium.org, Nov 10 2017 
Chrome Version: 64.0.3262.2/10114.0.0 dev-channel Kip,Peppy and Paine
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Take screenshot using 'Ctrl+F5(Overview Mode Button)'
(2)Now at notifications click on 'show in folder' -> Files App gets opened
->select image and click on 'Space' Key(or right click on it and select 'Get info' option)->image  preview is seen in General information page
(3)Now again at notifications click on 'show in folder' -> Again Files App gets opened ->select image and click on 'Space' Key-> Observe for image  preview in General information page (Please refer Video and screenshot)

Expected: Image preview should be seen every time in General information page for multiple windows of Files App
Actual: Instead Image preview is seen missing for second window of Files App

This is Regression Issue as same is working fine in M-62

@fukino: Please confirm the issue
Actual_NoPreview.webm
4.1 MB View Download
Actual_NoPreview.jpg
109 KB View Download
Expected_Preview.webm
2.8 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2a825d852b3179f2aac254583fcf0edd9d52e3b

commit c2a825d852b3179f2aac254583fcf0edd9d52e3b
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Nov 16 11:57:49 2017

Post message to webview after 'contentload' event is processed.

The contentload event from <webview> is dispached at the same time with 'load'
event in webview.
To ensure that posted message is handled in webview, we should post message to
webview asynchronously on 'contentload' event.

Bug:  783734 
Test: Manually tested.
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic875eff26d8ace5783941504c8f864a0573b8a8c
Reviewed-on: https://chromium-review.googlesource.com/771453
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517061}
[modify] https://crrev.com/c2a825d852b3179f2aac254583fcf0edd9d52e3b/ui/file_manager/file_manager/foreground/elements/files_safe_media.js

Comment 2 by fukino@chromium.org, Nov 30 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Nov 30 2017

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 19 2018

Labels: -Merge-TBD

Comment 5 by mkarkada@chromium.org, Jan 26 2018

Status: Verified (was: Fixed)
Verified on Chrome OS 10176.61.0, 64.0.3282.122 beta build.
►

Sign in to add a comment