New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783716 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Username field turns uneditable on gmail login page

Reported by vineetha...@etouch.net, Nov 10 2017

Issue description

Chrome Version: 64.0.3264.0 c555c442306ca8d68cf0d53d4a3b1adabfd25295-refs/heads/master@{#515409}(32/64-bit)

OS: Win(7,8,10), Mac(10.12.6, 10.13.1) and Linux(14.04 LTS).

Pre-condition: At least one valid gmail login credential should be saved in "Manage passwords" for chrome.

Steps to reproduce:
1.Launch Chrome, navigate to "www.gmail.com" and try to log in.
2.Observe that saved login credential is auto populated in the user name field.
3.Clear the selected user name to give more username options in the drop down.
4.Select any one user name from the drop down using keyboard arrow key then Press Esc and observe.

Actual Result: User name(Email or phone) field turns unresponsive and cannot be edited.
Expected Result: User name should not turn unresponsive and should be editable even after pressing ESC key.

This is regression issue broken in ‘M-64’ and below per-revision bisect result

Using the per-revision bisect providing the bisect results,
Good Build: 64.0.3244.0(Revision: 509945)
Bad Build: 64.0.3245.0(Revision: 510270)

You are probably looking for a change made after 509960 (known good), but no later than 509961 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/e73f847bc53b227cb7cf88f7f9d1ba19c3d86108..962a26fe7d0355903d4c2721faddcbe51e0ee45c

Suspect: https://chromium.googlesource.com/chromium/src/+/962a26fe7d0355903d4c2721faddcbe51e0ee45c

@sebsg: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!

 
ExpectedVideo.mp4
1.3 MB View Download
ActualVideo.mp4
860 KB View Download
Labels: ReleaseBlock-Beta
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 3 by ew...@chromium.org, Nov 10 2017

Components: -Services>SignIn UI>Browser>Passwords
This is an issue with password autofill, not Chrome sign-in.

Comment 4 by se...@chromium.org, Nov 13 2017

Status: Started (was: Assigned)

Comment 5 by se...@chromium.org, Nov 13 2017

Cc: dvadym@chromium.org kolos@chromium.org
It seems the suggestion preview were not cleared previously either for password/username suggestions when the user presses Esc.

But now that I changed the suggestion preview to be a placeholder it gives this weird effect.

I'm discussion the issue with some password autofill colleagues.

Comment 6 by ajha@chromium.org, Nov 20 2017

This is marked as Beta blocker and M-64 will be branched in ~1 week time. If possible, please plan the fix before branch point.

Thank you!

Comment 7 by se...@chromium.org, Nov 20 2017

Cc: cfroussios@chromium.org
+ cfroussios@ if you want to take a look?
 Issue 788130  has been merged into this issue.

Comment 9 by se...@chromium.org, Nov 23 2017

Owner: cfroussios@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06e9d8071bb30350c9b569970c6821fafc270839

commit 06e9d8071bb30350c9b569970c6821fafc270839
Author: Christos Froussios <cfroussios@chromium.org>
Date: Fri Nov 24 15:38:03 2017

🔐 Clear username/password preview when hidding the popup

In some cases, the autofill preview stays, making the field appear
uneditable for the user.

Bug:  783716 
Change-Id: I60e156993ffaa6ead935ca45eec05c01cb70cb2a
Reviewed-on: https://chromium-review.googlesource.com/789071
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519120}
[modify] https://crrev.com/06e9d8071bb30350c9b569970c6821fafc270839/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/06e9d8071bb30350c9b569970c6821fafc270839/chrome/browser/ui/autofill/autofill_popup_controller_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment