New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783709 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

61.7% improvement in system_health.memory_desktop at 514848:515057

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

Suspiciously large improvements, did something break?
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783709

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=e4ecf27c0d25bea1d694ee9699ba0ee6199d18434f6fd75030615deafec08945


Bot(s) for this bug's original alert(s):

chromium-rel-mac12
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/1238aa5ef80000
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

Cc: junov@chromium.org
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
๐Ÿ“ Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1238aa5ef80000

Reland: Refactor of Canvas2DLayerBridge resource model
By junov@chromium.org ยท Wed Nov 08 23:26:00 2017
chromium @ 5b07996e178c5f4e153e771d48ab839867fa7440

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by junov@chromium.org, Nov 13 2017

Status: WontFix (was: Assigned)
The improvement is expected. It is because the canvas IOSurface code path no longer triggers the skia copy-on-write mechanism when presenting animation frames.  This means no more unnecessary extra buffer allocations on the skia side.

Sign in to add a comment