New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783707 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.8% regression in system_health.memory_mobile at 514609:514697

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783707

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=449198ec7a3a894c439c2ae7016679c758788fe3939e00b2b2667a33d40702ac


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 11 2017

Cc: alito@chromium.org
Owner: alito@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author alito@chromium.org ===

Hi alito@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ali Tofigh
  Commit : e44ea3b37eab57ca6ff563802454af6e35a8331e
  Date   : Tue Nov 07 21:43:39 2017
  Subject: Deduplicate some test code

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/browse_media/browse_media_youtube
  Change       : 1.89% | 7075840.0 -> 7209642.66667

Revision             Result                  N
chromium@514608      7075840 +- 64177.9      6      good
chromium@514609      7210667 +- 48952.5      6      bad       <--
chromium@514610      7201792 +- 68539.2      6      bad
chromium@514611      7232512 +- 62321.1      6      bad
chromium@514614      7201109 +- 81595.1      6      bad
chromium@514620      7212032 +- 80003.2      6      bad
chromium@514631      7240704 +- 74576.5      6      bad
chromium@514653      7341397 +- 123838       6      bad
chromium@514697      7209643 +- 51945.5      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963319295852578736


For feedback, file a bug with component Speed>Bisection

Comment 4 by alito@chromium.org, Nov 11 2017

The CL that the bisect is pointing to touches only test code. No production code is modified in that CL. That CL annot be the culprit in this case. I don't do any mobile development. Please try to find a different owner.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 13 2017

Cc: mattreyn...@google.com
Owner: mattreyn...@google.com

=== Auto-CCing suspected CL author mattreynolds@google.com ===

Hi mattreynolds@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Matt Reynolds
  Commit : e88656fc09b1199c4feaaa8dd6fdca490799b2d2
  Date   : Sat Nov 04 01:08:16 2017
  Subject: Remove Objective-C calls from XboxDataFetcher

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/browse_media/browse_media_youtube
  Change       : 2.14% | 7072426.66667 -> 7223978.66667

Revision             Result                  N
chromium@514000      7072427 +- 56061.9      6      good
chromium@514001      7207936 +- 59002.3      6      bad       <--
chromium@514002      7240704 +- 120223       6      bad
chromium@514004      7198379 +- 88688.9      6      bad
chromium@514007      7228416 +- 34147.0      6      bad
chromium@514013      7202475 +- 84623.1      6      bad
chromium@514025      7233195 +- 103568       6      bad
chromium@514050      7205205 +- 79723.1      6      bad
chromium@514100      7201109 +- 39037.6      6      bad
chromium@514200      7221589 +- 82209.6      6      bad
chromium@514400      7222272 +- 114834       6      bad
chromium@514800      7223979 +- 55156.8      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963051615598864768


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Assigned)
This went back down, and bisect pointed at two different CLs. Probably bimodal?

Sign in to add a comment