New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783696 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 783654
Owner: ----
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

95.3%-136.3% improvement in blink_perf.layout at 514117:514432

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

Suspiciously large improvements, did something break?
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783696

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=9a3b8be68d3a0cc72e5c58271a852b709129d4c81c0bc77bc09b7c9066b97e36


Bot(s) for this bug's original alert(s):

android-nexus5
android-nexus5X
android-nexus7v2
android-one
android-webview-nexus5X
android-webview-nexus6
chromium-rel-mac-retina
chromium-rel-mac11
chromium-rel-mac11-pro
chromium-rel-mac12
chromium-rel-mac12-mini-8gb
chromium-rel-win10
chromium-rel-win7-dual
chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-intel
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
linux-release
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 10 2017


=== BISECT JOB RESULTS ===
NO Perf regression found, tests failed to produce values

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : multicol_fixed-height-with-spanner-and-nested-tables/multicol_fixed-height-with-spanner-and-nested-tables


Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963319471689494992


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 13 2017

📍 Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/100aa5e1f80000
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 13 2017

Mergedinto: 783654
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Robert Hogan
  Commit : 11a2b7b75eeccbb4e06a5cf7faed637af7b6719a
  Date   : Mon Nov 06 22:28:46 2017
  Subject: Remove unnecessary extra layout in table cells

Bisect Details
  Configuration: winx64nvidia_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : multicol_fixed-height-with-spanner-and-nested-tables/multicol_fixed-height-with-spanner-and-nested-tables
  Change       : 131.68% | 141.252150466 -> 327.247480748

Revision             Result                   N
chromium@514000      141.252 +- 9.39258       6      good
chromium@514133      149.572 +- 1.32651       6      good
chromium@514200      147.612 +- 1.19351       6      good
chromium@514239      153.709 +- 2.46222       6      good
chromium@514253      146.443 +- 0.858887      6      good
chromium@514257      147.92 +- 0.934519       6      good
chromium@514258      146.019 +- 1.29539       6      good
chromium@514259      318.853 +- 3.54725       6      bad       <--
chromium@514260      324.57 +- 2.71676        6      bad
chromium@514266      327.247 +- 2.31622       6      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963048041528036576


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment