Change suggested file name for password export to "Chrome Passwords.csv" |
|||
Issue descriptionThe goal is to make it more human-like, so replacing the dash with a space and capitalising. This was suggested in https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit?disco=AAAABgxxUW0
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e900267db0d6eb7e1aaa73156d84b88fca48378 commit 1e900267db0d6eb7e1aaa73156d84b88fca48378 Author: Vaclav Brozek <vabr@chromium.org> Date: Wed Nov 15 10:34:37 2017 Make "Chrome Passwords" the default file name & localise it When exporting passwords, Chrome suggests a default file name. Currently it's "chrome_passwords" (plus the ".csv" extension). This CL changes that to "Chrome Passwords" based on the suggestion of our UX designer (linked on the bug). Moreover, since the focus is on the name making sense to the user, it certainly pays off to translate it. Hence this CL also changes the hard-coded constant to a translated resource string. Bug: 783669 Change-Id: I1bedadd481142911015b42dabb8219b662f2ee8b Reviewed-on: https://chromium-review.googlesource.com/768386 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#516660} [modify] https://crrev.com/1e900267db0d6eb7e1aaa73156d84b88fca48378/chrome/browser/ui/passwords/password_manager_porter.cc [modify] https://crrev.com/1e900267db0d6eb7e1aaa73156d84b88fca48378/components/password_manager_strings.grdp
,
Nov 16 2017
,
Feb 27 2018
Issue verified Version: Chrome Canary 66.0.3356.0 Device: iPhone 8 iOS: 11.2.6 Suggested file name changed to "Chrome Passwords.csv" https://screenshot.googleplex.com/YMH2Gx1Ex3a https://drive.google.com/open?id=1Ll2vgktRSFza5z71XFXDLXSbg20NxpJv |
|||
►
Sign in to add a comment |
|||
Comment 1 by vabr@chromium.org
, Nov 14 2017Status: Started (was: Available)