New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 783657 link

Starred by 5 users
Status: WontFix
Owner:
tapted@chromium.org
Closed: Nov 2017
Cc:
bsep@chromium.org
nyerramilli@chromium.org
tapted@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
est...@chromium.org
█ ranjitkan@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

On clicking checkbox, Focus doesn't remove from Uninstall button.

Reported by dchau...@etouch.net, Nov 10 2017 
Chrome Version: 64.0.3264.0 (Official Build)c555c442306ca8d68cf0d53d4a3b1adabfd25295-refs/heads/master@{#515409} 32/64-bit.
OS: Windows (7,8,8.1,10).

What steps will reproduce the problem?
1. Launch Chrome and exit it from wrench menu.
2. Go Control panel and double click on Chrome icon to open 'Uninstall Google Chrome' dialog box.
3. Now, click on 'Also delete your browsing data' checkbox and observe the 'Uninstall' button.

On clicking checkbox, Focus doesn't remove from Uninstall button.
On clicking checkbox, Focus should get removed from Uninstall button.

This is a non-regression issue, broken in M-64 series, below is manual regression range.

Good build: 64.0.3256.0
Bad build: 64.0.3257.0

Unable to provide bisect per-revision as need to uninstall chrome from Control panel hence providing Changelog URL.
https://chromium.googlesource.com/chromium/src/+log/64.0.3256.0..64.0.3257.0?pretty=fuller&n=10000

Suspect: https://chromium.googlesource.com/chromium/src/+/1eca7aba022c190ea02e34dbd4ae52a8f5f88bbc

@tapted: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

NOTE: This issue is not seen on Mac and Linux OS.

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
542 KB View Download
Expected behavior.mp4
384 KB View Download

Comment 1 by tapted@chromium.org, Nov 10 2017

Cc: bsep@chromium.org est...@chromium.org
Labels: Proj-HarmonyDialogs
Status: WontFix (was: Assigned)
Summary: On clicking checkbox, Focus doesn't remove from Uninstall button. (was: Regression: Focus issue is observed on Uninstall overlay.)
I think this is intentional. The logic was added in r397289

Checkbox::Checkbox(const base::string16& label, bool force_md)
...
  if (UseMd()) {
    set_request_focus_on_press(false);

Comment 2 by estade@google.com, Nov 10 2017

Cc: sgabr...@chromium.org
Sebastien or some other designer can correct me if I'm wrong, but I think technically in an ideal world clicking would clear all focus indicators. That line exists because we don't want to show an indicator on the checkbox, but if we were to match blink it would not show on either control after you click. The problem is we aren't currently sophisticated enough to have separate "focused" and "visibly focused" states.

Comment 3 by tapted@chromium.org, Nov 15 2017

Cc: tapted@chromium.org
 Issue 784308  has been merged into this issue.

Comment 4 by tapted@chromium.org, Feb 13 2018 

 Issue 811180  has been merged into this issue.

Comment 5 by tapted@chromium.org, May 3 2018 

 Issue 839345  has been merged into this issue.

Comment 6 by tapted@chromium.org, May 8 2018 

 Issue 833827  has been merged into this issue.

Comment 7 by tapted@chromium.org, May 16 2018 

 Issue 843085  has been merged into this issue.

Comment 8 by tapted@chromium.org, Nov 1 

 Issue 900520  has been merged into this issue.
►

Sign in to add a comment