New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783654 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

99.8%-117.6% improvement in blink_perf.layout at 514149:514399

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

Suspiciously large improvement, did something break?
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783654

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b1b897b71e5d2cd8098ecce881eeff2e6548ee2093aa345ab6c2fb7feb2b715a


Bot(s) for this bug's original alert(s):

android-nexus6
chromium-rel-mac11-air
win-high-dpi
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

Cc: robho...@gmail.com
Owner: robho...@gmail.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author robhogan@gmail.com ===

Hi robhogan@gmail.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Robert Hogan
  Commit : 11a2b7b75eeccbb4e06a5cf7faed637af7b6719a
  Date   : Mon Nov 06 22:28:46 2017
  Subject: Remove unnecessary extra layout in table cells

Bisect Details
  Configuration: winx64_high_dpi_perf_bisect
  Benchmark    : blink_perf.layout
  Metric       : multicol_fixed-height-with-spanner-and-nested-tables/multicol_fixed-height-with-spanner-and-nested-tables
  Change       : 125.04% | 107.03352299 -> 240.870489301

Revision             Result                   N
chromium@514216      107.034 +- 1.60277       6      good
chromium@514242      109.053 +- 5.28431       6      good
chromium@514255      108.665 +- 0.700911      6      good
chromium@514258      106.137 +- 12.6057       6      good
chromium@514259      236.12 +- 5.48987        6      bad       <--
chromium@514260      234.858 +- 2.0735        6      bad
chromium@514261      234.851 +- 2.46033       6      bad
chromium@514267      234.801 +- 2.96029       6      bad
chromium@514317      240.87 +- 1.44895        6      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963323132026216704


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 13 2017

 Issue 783696  has been merged into this issue.

Comment 5 by robho...@gmail.com, Nov 13 2017

Status: WontFix (was: Assigned)
No, the content looks fine. That CL was expected to cause fewer layouts.

Sign in to add a comment