Issue metadata
Sign in to add a comment
|
99.8%-117.6% improvement in blink_perf.layout at 514149:514399 |
||||||||||||||||||||
Issue descriptionSuspiciously large improvement, did something break?
,
Nov 10 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8963323132026216704
,
Nov 10 2017
=== Auto-CCing suspected CL author robhogan@gmail.com === Hi robhogan@gmail.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Robert Hogan Commit : 11a2b7b75eeccbb4e06a5cf7faed637af7b6719a Date : Mon Nov 06 22:28:46 2017 Subject: Remove unnecessary extra layout in table cells Bisect Details Configuration: winx64_high_dpi_perf_bisect Benchmark : blink_perf.layout Metric : multicol_fixed-height-with-spanner-and-nested-tables/multicol_fixed-height-with-spanner-and-nested-tables Change : 125.04% | 107.03352299 -> 240.870489301 Revision Result N chromium@514216 107.034 +- 1.60277 6 good chromium@514242 109.053 +- 5.28431 6 good chromium@514255 108.665 +- 0.700911 6 good chromium@514258 106.137 +- 12.6057 6 good chromium@514259 236.12 +- 5.48987 6 bad <-- chromium@514260 234.858 +- 2.0735 6 bad chromium@514261 234.851 +- 2.46033 6 bad chromium@514267 234.801 +- 2.96029 6 bad chromium@514317 240.87 +- 1.44895 6 bad Please refer to the following doc on diagnosing blink_perf regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.layout More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8963323132026216704 For feedback, file a bug with component Speed>Bisection
,
Nov 13 2017
Issue 783696 has been merged into this issue.
,
Nov 13 2017
No, the content looks fine. That CL was expected to cause fewer layouts. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 10 2017