New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783653 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.3% regression in system_health.memory_mobile at 514155:514278

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783653

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a6f4ec52da8600de7fdfe71ab0f8073520ffb365628af3014fd103dcd158f563


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 12 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/load_media/load_media_facebook_photos

Revision             Result                  N
chromium@514154      38540349 +- 934110      21      good
chromium@514278      38573750 +- 779657      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.facebook.photos system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963323163458919360


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 14 2017

Cc: nikhil.s...@samsung.com
Owner: nikhil.s...@samsung.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author nikhil.sahni@samsung.com ===

Hi nikhil.sahni@samsung.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : nikhil
  Commit : be8cb489375a0838f529387f4dfd4595e7cd2ca4
  Date   : Mon Nov 06 07:44:52 2017
  Subject: CSSSkew constructor should reject non-angles.

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/load_media/load_media_facebook_photos
  Change       : 1.14% | 38205321.7778 -> 38642683.5556

Revision             Result                  N
chromium@514000      38205322 +- 532680      9       good
chromium@514063      38316970 +- 567793      14      good
chromium@514094      38255238 +- 404393      14      good
chromium@514096      38258163 +- 314564      14      good
chromium@514097      38369438 +- 514302      21      bad       <--
chromium@514099      38372559 +- 329994      14      bad
chromium@514102      38387773 +- 330228      14      bad
chromium@514110      38503078 +- 535865      9       bad
chromium@514125      38491489 +- 615206      14      bad
chromium@514250      38537212 +- 482741      9       bad
chromium@514500      38745539 +- 165303      6       bad
chromium@515000      38642684 +- 897482      9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.facebook.photos system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963051321719439312


For feedback, file a bug with component Speed>Bisection
Cc: shend@chromium.org
Hi Darren,

Can you please advise me on this , this is pointing to my change
https://chromium-review.googlesource.com/c/chromium/src/+/750542

Thanks,
Nikhil Sahni

Comment 8 by shend@chromium.org, Nov 14 2017

Hmm, I highly doubt that your patch would be causing a memory regression...
I'm gonna run the bisect again and see if it comes up with a different result.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Nov 14 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_webview_arm64_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/load_media/load_media_facebook_photos

Revision             Result                  N
chromium@514154      38495878 +- 751235      21      good
chromium@514278      38491002 +- 776974      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.media.facebook.photos system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8962915388355497920


For feedback, file a bug with component Speed>Bisection

Comment 11 by shend@chromium.org, Nov 14 2017

Yeah it looks like the benchmark is a bit noisy. alexclarke, is it ok to close this?
Status: WontFix (was: Assigned)
Yeah, this metric is pretty noisy and came back down eventually, WontFix-ing. Sorry for the noise.

Sign in to add a comment