New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 783649 link

Starred by 1 user
Status: Duplicate
Merged: issue 783648
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
█ junov@chromium.org
aleventhal@chromium.org
dewittj@chromium.org
█ fsam...@chromium.org
m...@chromium.org
dmazz...@chromium.org
█ alexclarke@chromium.org
haraken@chromium.org
xingliu@chromium.org
dtrainor@chromium.org
carlosk@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.7% regression in smoothness.tough_canvas_cases at 515024:515083

Project Member Reported by alexclarke@chromium.org, Nov 10 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783649

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=4ef54b89055df5011181308906c81fbf945c80bdbede0ffbba3ead85696a8afa


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 10 2017 


=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : smoothness.tough_canvas_cases
  Metric       : frame_times/tough_canvas_cases_canvas-font-cycler.html


To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=tough.canvas.cases.canvas.font.cycler.html smoothness.tough_canvas_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963323219747930304


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 10 2017 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14f0a2bef80000
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 10 2017 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14a77a36f80000
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

Cc: dtrainor@chromium.org carlosk@chromium.org junov@chromium.org dmazz...@chromium.org m...@chromium.org haraken@chromium.org fsam...@chromium.org xingliu@chromium.org aleventhal@chromium.org dewittj@chromium.org
Owner: dmazz...@chromium.org
Status: Assigned (was: Untriaged)
馃搷 Found significant differences after each of 4 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14a77a36f80000

Reland: Refactor of Canvas2DLayerBridge resource model
By junov@chromium.org 路 Wed Nov 08 23:26:00 2017
chromium @ 5b07996e178c5f4e153e771d48ab839867fa7440

Fix an issue that UI will infinitely loading when clicking notification.
By xingliu@chromium.org 路 Wed Nov 08 23:38:15 2017
chromium @ 3995adaf732f249ffb410398bae53698c7c8d71c

Add CapturableFrameSink interface to support tab capture in VIZ.
By miu@chromium.org 路 Wed Nov 08 23:46:21 2017
chromium @ 1ddcb7575e7ab86a791cd84357944302762b467c

Fix naming of AXObject throughout Blink.
By dmazzoni@chromium.org 路 Wed Nov 08 23:53:46 2017
chromium @ f1317f4bef330412662755fb32dd73634190ebec

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 10 2017 

馃樋 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/14f0a2bef80000
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Nov 11 2017 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14969121f80000
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Nov 11 2017

Owner: junov@chromium.org
馃搷 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14969121f80000

Reland: Refactor of Canvas2DLayerBridge resource model
By junov@chromium.org 路 Wed Nov 08 23:26:00 2017
chromium @ 5b07996e178c5f4e153e771d48ab839867fa7440

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Nov 11 2017

Mergedinto: 783648
Status: Duplicate (was: Assigned)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Justin Novosad
  Commit : 5b07996e178c5f4e153e771d48ab839867fa7440
  Date   : Wed Nov 08 23:26:00 2017
  Subject: Reland: Refactor of Canvas2DLayerBridge resource model

Bisect Details
  Configuration: android_nexus7_perf_bisect
  Benchmark    : smoothness.tough_canvas_cases
  Metric       : frame_times/tough_canvas_cases_rendering_throughput_put_get_image_data.html
  Change       : 47.43% | 232.800147603 -> 343.207223048

Revision             Result                  N
chromium@514700      232.8 +- 12.0827        6      good
chromium@514885      230.368 +- 16.0926      6      good
chromium@514977      228.857 +- 14.3448      6      good
chromium@515000      226.163 +- 6.81168      6      good
chromium@515001      347.371 +- 7.14187      6      bad       <--
chromium@515002      351.283 +- 11.6179      6      bad
chromium@515003      346.126 +- 9.36942      6      bad
chromium@515006      345.992 +- 7.42393      6      bad
chromium@515012      348.699 +- 13.1731      6      bad
chromium@515023      351.045 +- 14.4724      6      bad
chromium@515069      343.207 +- 12.5518      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=tough.canvas.cases.rendering.throughput.put.get.image.data.html smoothness.tough_canvas_cases

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963217118270262768


For feedback, file a bug with component Speed>Bisection
►

Sign in to add a comment