New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783621 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

250.1% regression in blink_perf.owp_storage at 515118:515129

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783621

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=31a9cdb021a73e49d24cdc660fee72404efb7f9085f09479b2a0d0e4ae01cb6c


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

Cc: kouhei@chromium.org
Owner: kouhei@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author kouhei@chromium.org ===

Hi kouhei@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Kouhei Ueno
  Commit : e1cfaee91ad08478fbd956fcd73d570032702397
  Date   : Thu Nov 09 08:23:01 2017
  Subject: Revert "Make script cache hits async"

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : blink_perf.owp_storage
  Metric       : IDBFactory::open/IDBFactory::open
  Change       : 211.52% | 2.96480833333 -> 9.23590833334

Revision             Result                   N
chromium@515117      2.96481 +- 0.348592      6      good
chromium@515120      3.14775 +- 0.41792       6      good
chromium@515121      9.04603 +- 0.872475      6      bad       <--
chromium@515122      9.08865 +- 1.28451       6      bad
chromium@515123      9.26091 +- 1.07792       6      bad
chromium@515129      9.23591 +- 0.657265      6      bad

Please refer to the following doc on diagnosing blink_perf regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/speed/benchmark_harnesses/blink_perf.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.owp_storage

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963323638815024608


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

 Issue 783624  has been merged into this issue.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

 Issue 783625  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

 Issue 783766  has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

 Issue 783794  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Nov 11 2017

 Issue 783632  has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Nov 11 2017

 Issue 783908  has been merged into this issue.
This was a revert of a CL which caused loading.desktop regression. We plan to reland the CL after tweak.

Ongoing discussion at https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/scheduler-dev/RZRjVPFLMLY/mTrtJWphCQAJ


Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, Nov 13 2017

Cc: tdresser@google.com
 Issue 784345  has been merged into this issue.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Nov 21 2017

Cc: u...@chromium.org
 Issue 787439  has been merged into this issue.
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, Nov 21 2017

 Issue 787438  has been merged into this issue.
kouhei: any update here?
Cc: -tdresser@google.com tdres...@chromium.org
Ping.
Owner: japhet@chromium.org
japhet: Would you give updates on https://chromium-review.googlesource.com/c/chromium/src/+/737481 ?
I've got a CL that attempts to re-land making script cache hits async without the perf regressions it caused at https://chromium-review.googlesource.com/c/chromium/src/+/762078

I haven't been pushing it very hard, though, because it's sufficiently hacky that I'm worried that it's not worth the mess.
Labels: -Performance-Sheriff
Removing Performance-Sheriff label, as reverts aren't the type of regression that sheriffs should ping on.

Sign in to add a comment