New issue
Advanced search Search tips

Issue 783616 link

Starred by 1 user
Status: WontFix
Owner:
marcochen@chromium.org
Closed: Nov 2017
Cc:
chromeos-factory-eng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make light_sensor_calibration.py Support Sensor Device - acpi-als

Project Member Reported by marcochen@chromium.org, Nov 10 2017 
The issues we met when sensor device is acpi-als not cros-ec-als are

  1. ambient_light_sensor.GetController gets cros-ec-als in default and pytest itself doesn't provide a arg for specifying other sensor device name.

  2. It's similar to issue above but it is regarding to location. Currently lid is in default.

  3. acpi-als driver now only expose in_illuminace_calibscale via sysfs but no in_illuminace_calibbias. The pytest now always set calibration value into this missing sysfs attribute.

Comment 1 by marcochen@chromium.org, Nov 10 2017 

  4. pytest always set scale and bias values into VPD which would be referred by light-init.sh. But acpi-als doesn't provide bias related sysfs attribute which would cause an error.

Comment 2 by marcochen@chromium.org, Nov 13 2017 

This would be blocked first until figuring out whether we would like to change from acpi-als to cros-ec-light on the specific project because for new platform/project cros-ec-light should be used in default.

Comment 3 by marcochen@chromium.org, Nov 27 2017 

Finally decided to move ALS from ALS task to motionsense task in EC which will be proxied by cors-ec-light on the kernel driver. So close this issue.

Comment 4 by marcochen@chromium.org, Nov 27 2017

Status: WontFix (was: Untriaged)

Comment 5 by marcochen@chromium.org, Nov 27 2017 

The CL of comment 3 is CL:774341
►

Sign in to add a comment