Issue metadata
Sign in to add a comment
|
Move mock_permission_prompt code to test_support target |
||||||||||||||||||||||
Issue descriptionRight now the chrome/browser/ui/permission_bubble/mock_permission_prompt* files are listed twice in chrome/test/BUILD.gn. They should be consolidated into the test_support target instead.
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a96be8a2e7727885a1f3cae91cbade036a6033c commit 4a96be8a2e7727885a1f3cae91cbade036a6033c Author: Timothy Loh <timloh@chromium.org> Date: Mon Nov 13 07:41:39 2017 Move some sources shared across different test targets to test_support Bug: 783587 Change-Id: I4ffd2a49e0b8f4ae93074b867b079b9562ecf80e Reviewed-on: https://chromium-review.googlesource.com/765609 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#515898} [modify] https://crrev.com/4a96be8a2e7727885a1f3cae91cbade036a6033c/chrome/browser/BUILD.gn [modify] https://crrev.com/4a96be8a2e7727885a1f3cae91cbade036a6033c/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/4a96be8a2e7727885a1f3cae91cbade036a6033c/chrome/test/BUILD.gn
,
Nov 13 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by est...@chromium.org
, Nov 10 2017