DeferredMediaBrowserTest as dead Android code |
|||
Issue descriptiondefer_background_media_browsertest.cc is not built for Android, yet it contains a small chunk of #if defined(OS_ANDROID) code. Does it need to be there? Was there some incorrect assumptions when writing the test? See also bug 611756 for getting browser_tests on Android, someday.
,
Nov 14 2017
as per c#1, give back to thestig@, feel free to delete it.
,
Nov 14 2017
It's your test, but sure, I can delete code. :)
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f585075efca8190ceb1e1d01a3e62c032ac9b0a2 commit f585075efca8190ceb1e1d01a3e62c032ac9b0a2 Author: Lei Zhang <thestig@chromium.org> Date: Wed Nov 15 03:02:36 2017 Simplify DeferredMediaBrowserTest. Android-specific code is dead code in browser tests. Bug: 783582 Change-Id: I87652e098f63143afa2d0d0e3de6b3064b578142 Reviewed-on: https://chromium-review.googlesource.com/770134 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#516574} [modify] https://crrev.com/f585075efca8190ceb1e1d01a3e62c032ac9b0a2/chrome/browser/media/defer_background_media_browsertest.cc
,
Nov 15 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dalecur...@chromium.org
, Nov 10 2017