New issue
Advanced search Search tips

Issue 783576 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DownloadTest.TestMultipleDownloadsInfobar is never built

Project Member Reported by thestig@chromium.org, Nov 10 2017

Issue description

In chrome/browser/download/download_browsertest.cc, DownloadTest.TestMultipleDownloadsInfobar is never built because it is OS_ANDROID only, but the file is not built in Android.
 
See also bug 611756.
Owner: qin...@chromium.org
Status: Assigned (was: Untriaged)
Cc: xingliu@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8a0cb1ff78ffeb3813d77b76df348b55bae872f

commit a8a0cb1ff78ffeb3813d77b76df348b55bae872f
Author: Min Qin <qinmin@chromium.org>
Date: Fri Dec 01 00:09:44 2017

Removed unused DownloadTest.TestMultipleDownloadsInfobar

This is a desktop test, and it is disabled in https://codereview.chromium.org/1322033003
This test never runs on Android and IOS, so the added #if block is not used.

BUG=783576

Change-Id: I4c8e4ad0dd9b7dfaa0607a4961cbcabf16cc69cc
Reviewed-on: https://chromium-review.googlesource.com/801221
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520762}
[modify] https://crrev.com/a8a0cb1ff78ffeb3813d77b76df348b55bae872f/chrome/browser/download/download_browsertest.cc

Sign in to add a comment