New issue
Advanced search Search tips

Issue 783567 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove the legacy fallback code path for the ARC backup settings.

Project Member Reported by kinaba@chromium.org, Nov 10 2017

Issue description

I am going to change the code path of syncing the ARC backup settings from Chrome to ARC in:
https://chromium-review.googlesource.com/c/chromium/src/+/756720.

For a short while we need to keep both the old and the new implementation because Chrome and the ARC Android images are updated independently and may cause mismatch in the versions.

But after the both side is updated, we can, and should, safely remove the legacy code.
 
Labels: -M-64 M-65
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da07836fff9b427fe31b29c2db9471a3b9cafe34

commit da07836fff9b427fe31b29c2db9471a3b9cafe34
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Thu Dec 07 02:40:25 2017

Remove the legacy fallback code path for the ARC backup settings.

crrev.com/517091 switched the backup settings sync path from ArcIntentHelper
to a new special apk. This CL cleans up the legacy ArcIntentHelper path now.

BUG= 783567 
TEST=Manual: (un)tick backup in ARC optin and confirm it in Android settings

Change-Id: I77c123cc4be1e310303cad329249162e2ecd900b
Reviewed-on: https://chromium-review.googlesource.com/807487
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Shuhei Takahashi <nya@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522314}
[modify] https://crrev.com/da07836fff9b427fe31b29c2db9471a3b9cafe34/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/da07836fff9b427fe31b29c2db9471a3b9cafe34/chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc
[modify] https://crrev.com/da07836fff9b427fe31b29c2db9471a3b9cafe34/components/arc/BUILD.gn
[add] https://crrev.com/da07836fff9b427fe31b29c2db9471a3b9cafe34/components/arc/test/fake_backup_settings_instance.cc
[add] https://crrev.com/da07836fff9b427fe31b29c2db9471a3b9cafe34/components/arc/test/fake_backup_settings_instance.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment