Eng: Enable Harmony Dialogs on ChromeOS |
||||||||||||||||||||
Issue descriptionTracking bug for engineering work for Issue 839559 "Enable harmony on ChromeOS". ChromeOS equivalent of Issue 775848 "Eng: Enable Harmony Dialogs on Windows, Linux and Mac." See also Issue 775847 - launch bug - "Enable Harmony Dialogs on Windows, Linux and Mac." Speculatively targeting M-66. ⛆ |
|
|
,
Nov 13 2017
,
Nov 23 2017
,
Dec 6 2017
,
Dec 14 2017
,
Jan 18 2018
,
Feb 15 2018
,
May 18 2018
,
May 21 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db0e213a037aabba4e00d21c8e180af33e7a74ca commit db0e213a037aabba4e00d21c8e180af33e7a74ca Author: glevin <glevin@chromium.org> Date: Tue Jun 19 19:49:42 2018 SecondaryUiMd on by default for CrOS Enables Harmony dialog styling by default on Chrome OS dialogs. Also see launch bug crbug.com/839559. Bug: 783540 Test: Summon any dialog (blockers of 783540) that has been Harmonized. Verify that it has the Harmonious styling. Change-Id: I2c9340d33d0d404edec2b110fe4dd9d6727bc645 Reviewed-on: https://chromium-review.googlesource.com/1072727 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568576} [modify] https://crrev.com/db0e213a037aabba4e00d21c8e180af33e7a74ca/ui/base/ui_base_features.cc
,
Jun 19 2018
The merge request is for the above CL turning the SecondaryUiMd flag on by default.
,
Jun 26 2018
,
Jun 26 2018
The bug is marked as P3 or Feature. It should not be merged as M68 is in beta. Please contact the approriate milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 26 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b66cab98e9a8bf2501721a22bbb7ad2f68e47651 commit b66cab98e9a8bf2501721a22bbb7ad2f68e47651 Author: glevin <glevin@chromium.org> Date: Wed Jun 27 19:47:18 2018 SecondaryUiMd on by default for CrOS Enables Harmony dialog styling by default on Chrome OS dialogs. Also see launch bug crbug.com/839559. Bug: 783540 Test: Summon any dialog (blockers of 783540) that has been Harmonized. Verify that it has the Harmonious styling. Change-Id: I2c9340d33d0d404edec2b110fe4dd9d6727bc645 Reviewed-on: https://chromium-review.googlesource.com/1072727 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568576}(cherry picked from commit db0e213a037aabba4e00d21c8e180af33e7a74ca) Reviewed-on: https://chromium-review.googlesource.com/1117519 Reviewed-by: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#558} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/b66cab98e9a8bf2501721a22bbb7ad2f68e47651/ui/base/ui_base_features.cc
,
Jun 27 2018
The merge of https://chromium-review.googlesource.com/1072727 also required merging fixes of two tests which this change breaks: https://chromium-review.googlesource.com/1103586 https://chromium-review.googlesource.com/1105457 The additional merging of these two was approved via email by bhthompson@ and bsep@.
,
Aug 2
,
Jan 15
|
|||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by tapted@chromium.org
, Nov 10 2017