Chrome unhides itself when the status bubble shows |
||||||
Issue descriptionChrome Version: 64.0.3263.0 OS: macOS 10.12.6 What steps will reproduce the problem? (1) Visit a page that loads data periodically, or auto reloads itself. (2) Hide Chrome with cmd+H. (3) Wait a bit. What is the expected result? Chrome stays hidden. What happens instead? Chrome unhides after a bit :(. Pretty sure this regressed in r513793, so self-assigning.
,
Nov 20 2017
M-64 will be branched in ~1 week time and would be good to have all the Beta blockers resolved before branch point. Please plan the fix accordingly.
,
Nov 20 2017
Vào 20-11-2017 5:46 CH, "a… via monorail" < monorail+v2.463707639@chromium.org> đã viết:
,
Nov 21 2017
,
Nov 21 2017
Should we revert r513793 then? I think this bug is more severe than not getting FSLP.
,
Nov 21 2017
I'm going to look into this today.
,
Nov 27 2017
sdy@, Could you please take a look and update the thread accordingly as it is marked as beta blocker. Thanks..!
,
Nov 29 2017
Friendly ping for an update on this as M-64 branches tomorrow and will be promoted to Beta in 2 weeks time.
,
Nov 29 2017
Re. pings: A CL is up for this, I’m just waiting for a review on a test it adds. Hopefully will land it today.
,
Nov 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed213854ffb5242584658b65a53081ff36ebaaa1 commit ed213854ffb5242584658b65a53081ff36ebaaa1 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Nov 29 19:18:38 2017 Fix status bubble causing Chrome to unhide. Telling the status bubble to orderFront: without adding it as a child of the browser window caused Chrome to unhide (e.g. if the bubble appeared due to background network activity when Chrome was hidden with cmd+H). Just adding it as a child is enough to show it, and doesn't trigger this problem, so remove -orderFront:. Bug: 783521 Change-Id: Ic2c94b0d90d43771a95774e010ad1799feeb8b32 Reviewed-on: https://chromium-review.googlesource.com/782665 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#520189} [modify] https://crrev.com/ed213854ffb5242584658b65a53081ff36ebaaa1/chrome/browser/ui/cocoa/status_bubble_mac.mm [add] https://crrev.com/ed213854ffb5242584658b65a53081ff36ebaaa1/chrome/browser/ui/cocoa/status_bubble_mac_interactive_uitest.mm [modify] https://crrev.com/ed213854ffb5242584658b65a53081ff36ebaaa1/chrome/test/BUILD.gn
,
Nov 29 2017
,
Jan 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57a73a51aa9de8ec4e93ee414c32aed8fb81d0a5 commit 57a73a51aa9de8ec4e93ee414c32aed8fb81d0a5 Author: Sidney San Martín <sdy@chromium.org> Date: Fri Jan 19 05:50:24 2018 Work around a High Sierra bug that makes a window in an inactive space activate if it shows its status bubble. Starting in 10.13, adding a child window to a window in an inactive space brings it to the front if the user is interacting with its application in the active space. I can't find a nice workaround, and hidden windows showing a status bubble have triggered similar issues in the past, so this workaround waits to add the status bubble to a window until it's visible. Bug: 798792 , 783521 Change-Id: I35cd7df87d74b6e1237cd91fc91acf455c443f82 Reviewed-on: https://chromium-review.googlesource.com/849559 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#530431} [modify] https://crrev.com/57a73a51aa9de8ec4e93ee414c32aed8fb81d0a5/chrome/browser/ui/cocoa/status_bubble_mac.h [modify] https://crrev.com/57a73a51aa9de8ec4e93ee414c32aed8fb81d0a5/chrome/browser/ui/cocoa/status_bubble_mac.mm [modify] https://crrev.com/57a73a51aa9de8ec4e93ee414c32aed8fb81d0a5/chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm [modify] https://crrev.com/57a73a51aa9de8ec4e93ee414c32aed8fb81d0a5/ui/base/test/cocoa_helper.h [modify] https://crrev.com/57a73a51aa9de8ec4e93ee414c32aed8fb81d0a5/ui/base/test/cocoa_helper.mm
,
Jan 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee14e0da0d09a0ac25db1e935c8a64b66dc51c5a commit ee14e0da0d09a0ac25db1e935c8a64b66dc51c5a Author: Sidney San Martín <sdy@chromium.org> Date: Mon Jan 29 18:25:16 2018 Work around a High Sierra bug that makes a window in an inactive space activate if it shows its status bubble. Starting in 10.13, adding a child window to a window in an inactive space brings it to the front if the user is interacting with its application in the active space. I can't find a nice workaround, and hidden windows showing a status bubble have triggered similar issues in the past, so this workaround waits to add the status bubble to a window until it's visible. TBR=sdy@chromium.org (cherry picked from commit 57a73a51aa9de8ec4e93ee414c32aed8fb81d0a5) Bug: 798792 , 783521 Change-Id: I35cd7df87d74b6e1237cd91fc91acf455c443f82 Reviewed-on: https://chromium-review.googlesource.com/849559 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530431} Reviewed-on: https://chromium-review.googlesource.com/891498 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#140} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/ee14e0da0d09a0ac25db1e935c8a64b66dc51c5a/chrome/browser/ui/cocoa/status_bubble_mac.h [modify] https://crrev.com/ee14e0da0d09a0ac25db1e935c8a64b66dc51c5a/chrome/browser/ui/cocoa/status_bubble_mac.mm [modify] https://crrev.com/ee14e0da0d09a0ac25db1e935c8a64b66dc51c5a/chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm [modify] https://crrev.com/ee14e0da0d09a0ac25db1e935c8a64b66dc51c5a/ui/base/test/cocoa_helper.h [modify] https://crrev.com/ee14e0da0d09a0ac25db1e935c8a64b66dc51c5a/ui/base/test/cocoa_helper.mm
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a80e723e5c134d659730491586c4cdf05cbb7bb8 commit a80e723e5c134d659730491586c4cdf05cbb7bb8 Author: Sidney San Martín <sdy@chromium.org> Date: Mon Feb 12 22:05:58 2018 Cherry pick space switching fixes to M64. > Work around a High Sierra bug that makes a window in an inactive space activate if it shows its status bubble. > > Starting in 10.13, adding a child window to a window in an inactive space > brings it to the front if the user is interacting with its application in the > active space. I can't find a nice workaround, and hidden windows showing a > status bubble have triggered similar issues in the past, so this workaround > waits to add the status bubble to a window until it's visible. > > Bug: 798792 , 783521 > Change-Id: I35cd7df87d74b6e1237cd91fc91acf455c443f82 > Reviewed-on: https://chromium-review.googlesource.com/849559 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530431} > > Delete Mac status bubble code for old OSs. > > Bug: 780521 > Change-Id: I18931966904196185e9693a80e62ae5db101c5ee > Reviewed-on: https://chromium-review.googlesource.com/853035 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527481} Change-Id: I45d9d384913da3d2ff9c20dde25ccd51d4edeb40 Reviewed-on: https://chromium-review.googlesource.com/914694 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#670} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/chrome/browser/ui/cocoa/status_bubble_mac.h [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/chrome/browser/ui/cocoa/status_bubble_mac.mm [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/ui/gfx/test/ui_cocoa_test_helper.h [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/ui/gfx/test/ui_cocoa_test_helper.mm |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ajha@chromium.org
, Nov 17 2017