New issue
Advanced search Search tips

Issue 783520 link

Starred by 1 user
Status: Assigned
Owner:
thomasanderson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Minimum width for browser windows is too narrow sometimes

Project Member Reported by thomasanderson@chromium.org, Nov 10 2017 
See the attached video.  The window can be resized so that the tabs disappear.

This can be more easily seen when using native GTK frame buttons which are larger than the classic theme buttons.  Note that this bug was not caused by native GTK buttons, but merely exposed by it.
window_min_size.mp4
255 KB View Download

Comment 1 by thomasanderson@chromium.org, Nov 10 2017

Owner: pkasting@chromium.org
Over to pkasting@.  The relevant sizing code is in OpaqueBrowserFrameViewLayout::GetMinimumSize.  Not sure what the logic is supposed to be.
https://cs.chromium.org/chromium/src/chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc?l=113

Comment 2 by pkasting@chromium.org, Nov 29 2017

Cc: -thomasanderson@chromium.org
Owner: thomasanderson@chromium.org
It looks to me like the sizing code there is trying to do the right thing, and I can't repro on Windows.

Are you sure this isn't caused by GTK buttons?  Maybe the minimum size needed by the buttons is being calculated incorrectly elsewhere?

Are you able to debug this and check what the minimum sizes we claim to need for each element are, versus what they actually are?

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Available)
►

Sign in to add a comment