New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783519 link

Starred by 23 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Feature

Blocked on:
issue 784607
issue 784993
issue 787514
issue 787522

Blocking:
issue 838380



Sign in to add a comment

Add AV1 decoder support to Chrome.

Project Member Reported by dalecur...@chromium.org, Nov 10 2017

Issue description

This covers the task of adding a basic decoder for AV1 based on libaom.
 
Blockedon: 784607
Blocking: 784993
Blocking: -784993
Blockedon: 784993
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f292c6236d2845961202307ff4b3d223b368d3d

commit 6f292c6236d2845961202307ff4b3d223b368d3d
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Nov 15 06:24:33 2017

Extract MemoryPool from VpxVideoDecoder as generic FrameBufferPool

No functional changes, this should satisfy all of the existing
VP9 use cases and allows us to use it with the AV1 decoder in
a later change.

BUG= 783519 
TEST=new tests and existing tests still pass.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icbf667261949bbe06a25ecab140f352c5e0e348a
Reviewed-on: https://chromium-review.googlesource.com/770253
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516611}
[modify] https://crrev.com/6f292c6236d2845961202307ff4b3d223b368d3d/media/filters/BUILD.gn
[add] https://crrev.com/6f292c6236d2845961202307ff4b3d223b368d3d/media/filters/frame_buffer_pool.cc
[add] https://crrev.com/6f292c6236d2845961202307ff4b3d223b368d3d/media/filters/frame_buffer_pool.h
[add] https://crrev.com/6f292c6236d2845961202307ff4b3d223b368d3d/media/filters/frame_buffer_pool_unittest.cc
[modify] https://crrev.com/6f292c6236d2845961202307ff4b3d223b368d3d/media/filters/vpx_video_decoder.cc
[modify] https://crrev.com/6f292c6236d2845961202307ff4b3d223b368d3d/media/filters/vpx_video_decoder.h

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b03fc92a51679a4a04645614879bc8e3a2955e77

commit b03fc92a51679a4a04645614879bc8e3a2955e77
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Nov 15 22:04:42 2017

Introduce AomVideoDecoder (based on VpxVideoDecoder).

Adds a simple 1-copy AV1 video decoder to Chrome. Zero copy and
offloading have not been done to start with since libaom may
produce weird formats (8bit data in 16bit allocation).

There are quite a few TODOs left to sort out:
- We currently don't handle the I440 pixel formats.
- We currently only handle a single profile, but more are expected.
- Decoding for AV1 content should probably be offloaded, so the
OffloadThread stuff from VpxVideoDecoder should be factored out.
- Decoding should use zero copy where possible, so the odd 8bit
in 16bit container needs to be sorted out or Chrome taught to
read this. This requires setting the av1 framebuffer functions.
- All AV1 frames are marked as non-power efficient; is this true
even for low resolutions?
- A fuzzertest needs to be added along with corpus data.
- A pipeline integration test needs to be added with test media
for both src= and MSE.
- What should canPlayType()/isTypeSupported() return for this?
- Changes to MediaSourceExtensions for SourceBuffer creation and
demuxing.

To use this, you must update your .gclient file to include the
following within the "src" solution:

  "custom_vars": { "checkout_libaom": True, },

This will propogate a ENABLE_AV1_DECODER buildflag, which can
optionally be turned off via enable_av1_decode=false for
unsupported platfroms (everything except linux x64 currently)

BUG= 783519 , b/67860375
TEST=new unittest, manual playback test

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia77a8d0710ebebd1ac3e7ad83648313063181d62
Reviewed-on: https://chromium-review.googlesource.com/762359
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#516847}
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/components/arc/common/video_encode_accelerator.mojom
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/components/arc/common/video_encode_accelerator_struct_traits.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/gpu/config/gpu_info.h
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/gpu/ipc/common/gpu_info.mojom
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/gpu/ipc/common/gpu_info_struct_traits.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/DEPS
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/base/BUILD.gn
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/base/decode_capabilities.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/base/video_codecs.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/base/video_codecs.h
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/base/video_decoder_config.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/base/video_types.h
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/ffmpeg/ffmpeg_common.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/ffmpeg/ffmpeg_common_unittest.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/filters/BUILD.gn
[add] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/filters/aom_video_decoder.cc
[add] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/filters/aom_video_decoder.h
[add] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/filters/aom_video_decoder_unittest.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/filters/ffmpeg_demuxer_unittest.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/filters/ffmpeg_video_decoder.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/gpu/gpu_video_accelerator_util.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/remoting/proto_enum_utils.cc
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/remoting/rpc.proto
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/renderers/BUILD.gn
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/renderers/default_renderer_factory.cc
[add] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/media/test/data/av1-I-frame-352x288
[modify] https://crrev.com/b03fc92a51679a4a04645614879bc8e3a2955e77/tools/metrics/histograms/enums.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8842633b9ea324ecd3951c2620a67fa998272db

commit c8842633b9ea324ecd3951c2620a67fa998272db
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Nov 17 03:40:13 2017

Introduce OffloadingVideoDecoder wrapper.

Used to run a OffloadableVideoDecoder on a different thread
than the media thread. Offload conditions are configurable.

OffloadableVideoDecoder implementations are just normal
VideoDecoders with a new Detach() method that removes them
from the thread they were running on.

This replaces the offload task runner that was previously held
within VpxVideoDecoder with a new class OffloadingVpxVideoDecoder
and a helper variable on the constructor to VpxVideoDecoder. The
helper variable ensures tasks are returned to the correct thread
without unnecessary hops.

BUG= 783519 ,  785760 , 786059
TEST=new unittests, all existing tests pass

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib76dd9c2778fef3c39455ca3b4de6ecb12dea953
Reviewed-on: https://chromium-review.googlesource.com/773040
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517284}
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/base/test_helpers.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/base/test_helpers.h
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/BUILD.gn
[add] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/offloading_video_decoder.cc
[add] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/offloading_video_decoder.h
[add] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/offloading_video_decoder_unittest.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/vpx_video_decoder.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/vpx_video_decoder.h
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/filters/vpx_video_decoder_unittest.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/renderers/default_renderer_factory.cc
[modify] https://crrev.com/c8842633b9ea324ecd3951c2620a67fa998272db/media/test/pipeline_integration_test_base.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68d5c0ad6f486158dd797241a544b8946f36452d

commit 68d5c0ad6f486158dd797241a544b8946f36452d
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Mon Nov 20 23:36:29 2017

Enable AV1 with MSE and SRC when runtime flag is enabled.

Adds support for AV1 in webm and mp4 with MSE and enables this
support only when the buildflag and runtime flag are present.

The proper codec string is currently just "av1" until it's
finalized. Tracked by  http://crbug.com/784607 . E.g., the
following should be used with this demo:

HTMLMediaElement.canPlayType('video/mp4; codecs="av1"')
HTMLMediaElement.canPlayType('video/webm; codecs="av1"')
MediaSource.isTypeSupported('video/mp4; codecs="av1"')
MediaSource.isTypeSupported('video/webm; codecs="av1"')

BUG= 783519 ,  784607 , b/67860440
TEST=manual, new tests, updated existing tests.

http: //xorax.sea/mse.html?type=mp4_av1&src=test_av1_bitstream.mp4
http: //xorax.sea/mse.html?type=webm_av1&src=test_av1_bitstream.mkv
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I7f29de49b05849f681d8781755f189ea50ace475
Reviewed-on: https://chromium-review.googlesource.com/776060
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517991}
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/content/browser/DEPS
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/content/browser/media/media_canplaytype_browsertest.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/content/test/BUILD.gn
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/base/decode_capabilities.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/base/mime_util_internal.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/base/mime_util_internal.h
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/base/mime_util_unittest.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/filters/BUILD.gn
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/filters/stream_parser_factory.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/formats/BUILD.gn
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/formats/mp4/box_definitions.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/formats/mp4/fourccs.h
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/formats/webm/webm_video_client.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/renderers/default_renderer_factory.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/test/BUILD.gn
[add] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/test/data/bear-av1.mp4
[add] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/test/data/bear-av1.webm
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/media/test/pipeline_integration_test_base.cc
[modify] https://crrev.com/68d5c0ad6f486158dd797241a544b8946f36452d/tools/metrics/histograms/enums.xml

This is done as far as the pre-bitstream freeze is concerned. Once we have a final version of AOM, we'll need to resolve the two linked issues for profiles and mime type.
Blockedon: 787514
Blockedon: 787522
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/978bcb16297edd531ed805cf7eb3f5d4ade99834

commit 978bcb16297edd531ed805cf7eb3f5d4ade99834
Author: Johann <johannkoenig@google.com>
Date: Sat Dec 02 08:14:21 2017

enable libaom

Check out and build libaom by default.

AV1 playback is still guarded by a flag.

BUG= 783519 

Change-Id: Iac481ca03cc39b6241b3ffcf834689626c7e39f1
Reviewed-on: https://chromium-review.googlesource.com/780581
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521207}
[modify] https://crrev.com/978bcb16297edd531ed805cf7eb3f5d4ade99834/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7eb8650bbec6ecd051caf89e3bb144e075578e6

commit f7eb8650bbec6ecd051caf89e3bb144e075578e6
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Sat Dec 02 19:16:03 2017

Revert "enable libaom"

This reverts commit 978bcb16297edd531ed805cf7eb3f5d4ade99834.

Reason for revert: Broke linux msan builder:
https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/7457

Original change's description:
> enable libaom
> 
> Check out and build libaom by default.
> 
> AV1 playback is still guarded by a flag.
> 
> BUG= 783519 
> 
> Change-Id: Iac481ca03cc39b6241b3ffcf834689626c7e39f1
> Reviewed-on: https://chromium-review.googlesource.com/780581
> Commit-Queue: Johann Koenig <johannkoenig@google.com>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521207}

TBR=dalecurtis@chromium.org,johannkoenig@google.com

Change-Id: I6e86090b9d56c5ccf6b3a30bcc57248aee945661
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  783519 
Reviewed-on: https://chromium-review.googlesource.com/804686
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521218}
[modify] https://crrev.com/f7eb8650bbec6ecd051caf89e3bb144e075578e6/DEPS

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80428a9587801289b331674365fc09523319288c

commit 80428a9587801289b331674365fc09523319288c
Author: Johann <johannkoenig@google.com>
Date: Mon Dec 04 21:56:28 2017

Revert "Revert "enable libaom""

This reverts commit f7eb8650bbec6ecd051caf89e3bb144e075578e6.

The msan build failure has been addressed:
https://chromium-review.googlesource.com/c/chromium/src/+/806634

Original change's description:
> Reason for revert: Broke linux msan builder:
> https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Builder/7457

BUG= 783519 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_msan_rel_ng

R=tomfinegan@chromium.org,dalecurtis@chromium.org

Change-Id: I720447e099700e1bce0868590d31943beb370643
Reviewed-on: https://chromium-review.googlesource.com/806875
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#521477}
[modify] https://crrev.com/80428a9587801289b331674365fc09523319288c/DEPS

Cc: -jaikk@chromium.org johannkoenig@chromium.org dalecur...@chromium.org
Owner: jaikk@chromium.org
Status: ExternalDependency (was: Started)
Nothing more can be done at this point, so we're now waiting for the bitstream finalization. Once that is complete the following is still left to do in Chrome:

- We currently don't handle the I440 pixel formats.
- We currently only handle a single profile, but more are expected ( issue 784993 )
- Decoding for AV1 content should probably be offloaded from the media thread using OffloadingVideoDecoder.
- Decoding should be zero copy, i.e. support added for FrameBufferPool using the AV1 set frame buffer commands; this is blocked by AV1s weird 8-bit in 16-bit packaging currently.
- A fuzzertest needs to be added along with corpus data.
- What should canPlayType()/isTypeSupported() return for this? ( issue 784607 )
- Changes to MediaSourceExtensions for SourceBuffer creation and
demuxing true AV1 data instead of VPx data.

Assigning to jaik@ for tracking, please hand back to me when you're ready for me to undertake any of the above.
In third_party/libaom, the source lists for ARM targets are not yet configured.
Would patches toward enabling Android/ARM builds be welcome?
I am familiar with building libaom and looking to resume contributing to chromium.
We are currently waiting for the hard bitstream freeze before updating the library, but if you look at BUILD.gn.cmake and cmake_update.sh you can test things out.

Note however, in options.gni that we do not currently build on arm. It will likely be a bit of time before we can enable it by default, but if you want to set things up that would be very welcome.
The arm/arm-neon/arm-neon-cpu-detect variants can be enabled with only build configuration change - no updates to the library are required to compile and link.

With a change to enable the PipelineIntegrationTest suite on Android, we can verify that the resulting binary can decode the test sequences.

Enabling on Android, behind the enable_av1_decoder flag, can be done independently of configuring the ARM build if we test on x86/Android and ARM/Linux targets, respectively.

Should new bugs be opened for these cases or is tracking against this bug okay?
Using this bug is fine if it's just a few small patches; if you anticipate quite a few large patches please create a new bug and block this issue on it instead. Thanks for your help!
Project Member

Comment 20 by bugdroid1@chromium.org, May 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ba7b05a3d35d348293ad22ceeb2a87426b015b7

commit 8ba7b05a3d35d348293ad22ceeb2a87426b015b7
Author: David Michael Barr <david.barr@samsung.com>
Date: Fri May 18 02:36:14 2018

libaom: enable generation of linux/arm-neon config

Use run_perl.py from third_party/libvpx.

Document cmake_update.sh requirements, particularly:
* gcc-arm-linux-gnueabihf
* g++-arm-linux-gnueabihf

Bug:  783519 
Change-Id: I091a60cd306e1bea63d4a8ab0b0caacb65ade464
Reviewed-on: https://chromium-review.googlesource.com/1062986
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#559781}
[modify] https://crrev.com/8ba7b05a3d35d348293ad22ceeb2a87426b015b7/AUTHORS
[modify] https://crrev.com/8ba7b05a3d35d348293ad22ceeb2a87426b015b7/third_party/libaom/BUILD.gn.cmake
[modify] https://crrev.com/8ba7b05a3d35d348293ad22ceeb2a87426b015b7/third_party/libaom/cmake_update.sh

Some notes on rolling libaom.

https://aomedia.googlesource.com/aom/+/d969f2c2aaab2538b665b8bf20581f4b11c20e9a%5E%21/
Since "Turn CONFIG_CICP on by default" landed in libaom, the color space handling in
media/filters/aom_video_decoder.cc needs to be rewritten or the flag reverted.

https://aomedia.googlesource.com/aom/+/103991e301c9002c76e6931ab15e945036677c9f%5E%21/
Since "Remove CONFIG_CICP compile flag" landed, rewriting  is required.

https://aomedia.googlesource.com/aom/+/47cc25591c36fafcc36e11109e5c36531353cdd9%5E%21/
Since "Remove deadline" landed, the call to aom_codec_decode() in
media/filters/aom_video_decoder.cc should drop the deadline parameter.
I have some pending changes to address those. The CICP one needs a fair amount of work:
https://chromium-review.googlesource.com/c/chromium/src/+/999009
https://chromium-review.googlesource.com/c/chromium/src/+/999028
Project Member

Comment 23 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f96093d2d7db7f0ab25d9a7511652a31f117b84

commit 5f96093d2d7db7f0ab25d9a7511652a31f117b84
Author: David Michael Barr <david.barr@samsung.com>
Date: Tue May 29 19:34:33 2018

libaom: generators for alternate linux/arm configs

linux/arm for targets without NEON support.
linux/arm-neon-cpu-detect for deprecated( Bug 448055 ) Android config.

Bug:  783519 
Change-Id: Ib050ed227ddfcd759efbe08e80a781ca6f675dbe
Reviewed-on: https://chromium-review.googlesource.com/1068902
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562547}
[modify] https://crrev.com/5f96093d2d7db7f0ab25d9a7511652a31f117b84/third_party/libaom/BUILD.gn.cmake
[modify] https://crrev.com/5f96093d2d7db7f0ab25d9a7511652a31f117b84/third_party/libaom/cmake_update.sh

Project Member

Comment 24 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a04bb03fdcf7860f8e4787e8db1c7799eaa69be

commit 3a04bb03fdcf7860f8e4787e8db1c7799eaa69be
Author: David Michael Barr <david.barr@samsung.com>
Date: Tue May 29 19:53:52 2018

libaom: move aom_config to config sub dir

The include structure has changed in libaom.

Bug:  783519 
Change-Id: Ibea981e41e25ef5aa18c3c840b6ebfae9ceee526
Reviewed-on: https://chromium-review.googlesource.com/1074797
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#562559}
[modify] https://crrev.com/3a04bb03fdcf7860f8e4787e8db1c7799eaa69be/third_party/libaom/cmake_update.sh

Project Member

Comment 25 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbd740eee0cccaf87e8b2458cf480dd621a24c21

commit bbd740eee0cccaf87e8b2458cf480dd621a24c21
Author: David Michael Barr <david.barr@samsung.com>
Date: Wed May 30 19:37:24 2018

libaom: tidy files for cmake config

BUILD.gn.cmake:
Merge blocks with identical conditions. Remove an empty block.
Inline arm_assembly_sources, it has a single reference.
Use generic sources for libaom static_library.
Note, architecure-specific sources are included via deps.

cmake_update.sh:
Move common console message to reset_dirs step.
Handle creation of config dir for aom_version.h on first run.

Bug:  783519 
Change-Id: If8b4be6bb1f54ea0eec839c8281cd1861e4f3195
Reviewed-on: https://chromium-review.googlesource.com/1077715
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#562957}
[modify] https://crrev.com/bbd740eee0cccaf87e8b2458cf480dd621a24c21/third_party/libaom/BUILD.gn.cmake
[modify] https://crrev.com/bbd740eee0cccaf87e8b2458cf480dd621a24c21/third_party/libaom/cmake_update.sh

Project Member

Comment 26 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6549f52e42064906e4b92fda8050e68b4814cff9

commit 6549f52e42064906e4b92fda8050e68b4814cff9
Author: David Michael Barr <david.barr@samsung.com>
Date: Thu May 31 15:16:15 2018

libaom: enable generation of linux/arm64 config

Document new cmake_update.sh requirements:
* gcc-aarch64-linux-gnu
* g++-aarch64-linux-gnu

AArch64 mandates NEON extensions, so intrinsics require no extra config.
The NEON assembly sources are not required for AArch64.

Bug:  783519 
Change-Id: I276283adb1867a90a08f9348bbaace7089ef5c4e
Reviewed-on: https://chromium-review.googlesource.com/1080437
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#563236}
[modify] https://crrev.com/6549f52e42064906e4b92fda8050e68b4814cff9/third_party/libaom/BUILD.gn.cmake
[modify] https://crrev.com/6549f52e42064906e4b92fda8050e68b4814cff9/third_party/libaom/cmake_update.sh

Project Member

Comment 27 by bugdroid1@chromium.org, Jun 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aa94f035eda11023e18360cff3f3f8157a205ad

commit 9aa94f035eda11023e18360cff3f3f8157a205ad
Author: David Michael Barr <david.barr@samsung.com>
Date: Mon Jun 04 20:20:56 2018

libaom: remove config for neon assembly

All neon assembly was removed upstream, including conversion scripts.
https://aomedia-review.googlesource.com/c/aom/+/59782

Bug:  783519 
Change-Id: I84333958a580a93d0a7e5ac8ec5f2abf319124af
Reviewed-on: https://chromium-review.googlesource.com/1081769
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#564214}
[modify] https://crrev.com/9aa94f035eda11023e18360cff3f3f8157a205ad/third_party/libaom/BUILD.gn.cmake
[modify] https://crrev.com/9aa94f035eda11023e18360cff3f3f8157a205ad/third_party/libaom/cmake_update.sh

Comment 28 by jaikk@chromium.org, Jun 11 2018

Blocking: 838380
Project Member

Comment 29 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3bcd204a1871d9ed5f52248b98bd5c9a32f7e1c

commit a3bcd204a1871d9ed5f52248b98bd5c9a32f7e1c
Author: David Michael Barr <david.barr@samsung.com>
Date: Thu Jun 14 15:12:46 2018

libaom: remove obsolete cflags

In libaom CMake configuration:
-Wenum-conversion and -Wparentheses-equality are enabled by default
in clang and not explicitly disabled.
-Wunused-function is from CMake defaults and no longer disabled.
-Wsign-compare is explicitly enabled.

The symbol "_vpx_scaled_2d" is no longer present, so the bug that
required "-fno-common" should be resolved.

Bug:  783519 
Change-Id: I099b89c3b418fb2cd50bc19af167deaf71f12a6c
Reviewed-on: https://chromium-review.googlesource.com/1100370
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#567268}
[modify] https://crrev.com/a3bcd204a1871d9ed5f52248b98bd5c9a32f7e1c/third_party/libaom/BUILD.gn.cmake

Comment 30 by jaikk@chromium.org, Jun 18 2018

Owner: dalecur...@chromium.org
Hey Dale, 

Reassigning this to you for the outstanding to-do list. Updated  Issue 784993  and  issue 784607  with links to AOM documentation. Please reassign to Tom, Johann, or myself if you need additional information.

Thanks,
Jai
Project Member

Comment 31 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c09fc457a3017691cb775b36ac4f517240ae412e

commit c09fc457a3017691cb775b36ac4f517240ae412e
Author: Johann <johannkoenig@google.com>
Date: Thu Jun 21 00:43:14 2018

Roll src/third_party/libaom/source/libaom/ cc92258a0..c5a56b99d (3832 commits)

https://aomedia.googlesource.com/aom.git/+log/cc92258a08d9..c5a56b99df86

$ git log cc92258a0..c5a56b99d --date=short --no-merges --format='%ad %ae %s'
(...)

Created with:
  roll-dep src/third_party/libaom/source/libaom

As part of the roll we must update the colorspace signaling.

Originally added to libaom in
commit 9e69463febe0ee8525cb5a99ee5f9f11286581f1
Author: Andrey Norkin <anorkin@netflix.com>
Date:   Thu Dec 21 18:50:57 2017 -0800

    CICP colorspace signaling

Monochrome is signaled outside of CICP:
commit f340fece2c18f068dc3c0c9219b2e5a5eee7ba79
Author: Debargha Mukherjee <debargha@google.com>
Date:   Wed Jan 10 18:12:22 2018 -0800

    No colorspace for mono-video f/ CICP compatibility

BUG= aomedia:1673 

And remove references to the deadline parameter.

BUG= aomedia:13 

Updates bear-av1.webm and disables bear-av1.mp4 test.
ffmpeg muxing of av1 in mp4 has not been upstreamed yet.
The webm file was generated with the av1 tree in this
update.
vpxdec media/test/data/bear-vp9.webm -o bear.y4m
aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \
  bear.y4m

The I frame for the AV1 test is generated with:
aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \
  bear.y4m --limit=1 --ivf

And then a hex editor is used to remove the 32 byte
file header and 12 byte frame header.

BUG= chromium:783519 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e

NOPRESUBMIT=true (due to presubmit confusion about relative paths in DEPS)

Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e
Reviewed-on: https://chromium-review.googlesource.com/1101705
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569100}
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/DEPS
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/media/filters/aom_video_decoder.cc
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/media/filters/aom_video_decoder_unittest.cc
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/media/test/data/av1-I-frame-320x240
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/media/test/data/av1-I-frame-352x288
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/media/test/data/bear-av1.webm
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/BUILD.gn
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/BUILD.gn.cmake
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/DEPS
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/README.chromium
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/cmake_update.sh
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/generate_gni.sh
[modify] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/libaom_srcs.gni
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/aom_version.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/config/aom_version.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.asm
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.c
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_dsp_rtcd.h
[copy] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_scale_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/av1_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon/config/aom_config.asm
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon/config/aom_config.c
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon/config/aom_config.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon/config/aom_dsp_rtcd.h
[copy] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon/config/aom_scale_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm-neon/config/av1_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm/config/aom_config.asm
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm/config/aom_config.c
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm/config/aom_config.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm/config/aom_dsp_rtcd.h
[copy] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm/config/aom_scale_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm/config/av1_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm64/config/aom_config.asm
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm64/config/aom_config.c
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm64/config/aom_config.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm64/config/aom_dsp_rtcd.h
[copy] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm64/config/aom_scale_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/arm64/config/av1_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/ia32/aom_config.asm
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/ia32/aom_config.c
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/ia32/aom_config.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/ia32/aom_dsp_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/ia32/av1_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/ia32/config/aom_config.asm
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/ia32/config/aom_config.c
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/ia32/config/aom_config.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/ia32/config/aom_dsp_rtcd.h
[rename] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/ia32/config/aom_scale_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/ia32/config/av1_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/x64/aom_config.asm
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/x64/aom_config.c
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/x64/aom_config.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/x64/aom_dsp_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/x64/aom_scale_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/linux/x64/av1_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/x64/config/aom_config.asm
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/x64/config/aom_config.c
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/x64/config/aom_config.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/x64/config/aom_dsp_rtcd.h
[copy] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/x64/config/aom_scale_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/linux/x64/config/av1_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/ia32/aom_config.asm
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/ia32/aom_config.c
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/ia32/aom_config.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/ia32/aom_dsp_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/ia32/aom_scale_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/ia32/av1_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/ia32/config/aom_config.asm
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/ia32/config/aom_config.c
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/ia32/config/aom_config.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/ia32/config/aom_dsp_rtcd.h
[copy] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/ia32/config/aom_scale_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/ia32/config/av1_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/x64/aom_config.asm
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/x64/aom_config.c
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/x64/aom_config.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/x64/aom_dsp_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/x64/aom_scale_rtcd.h
[delete] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/third_party/libaom/source/config/win/x64/av1_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/x64/config/aom_config.asm
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/x64/config/aom_config.c
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/x64/config/aom_config.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/x64/config/aom_dsp_rtcd.h
[copy] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/x64/config/aom_scale_rtcd.h
[add] https://crrev.com/c09fc457a3017691cb775b36ac4f517240ae412e/third_party/libaom/source/config/win/x64/config/av1_rtcd.h

Project Member

Comment 32 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9

commit d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Jun 21 02:52:09 2018

Revert "Roll src/third_party/libaom/source/libaom/ cc92258a0..c5a56b99d (3832 commits)"

This reverts commit c09fc457a3017691cb775b36ac4f517240ae412e.

Reason for revert: This CL breaks MSAN build
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/8439

Original change's description:
> Roll src/third_party/libaom/source/libaom/ cc92258a0..c5a56b99d (3832 commits)
> 
> https://aomedia.googlesource.com/aom.git/+log/cc92258a08d9..c5a56b99df86
> 
> $ git log cc92258a0..c5a56b99d --date=short --no-merges --format='%ad %ae %s'
> (...)
> 
> Created with:
>   roll-dep src/third_party/libaom/source/libaom
> 
> As part of the roll we must update the colorspace signaling.
> 
> Originally added to libaom in
> commit 9e69463febe0ee8525cb5a99ee5f9f11286581f1
> Author: Andrey Norkin <anorkin@netflix.com>
> Date:   Thu Dec 21 18:50:57 2017 -0800
> 
>     CICP colorspace signaling
> 
> Monochrome is signaled outside of CICP:
> commit f340fece2c18f068dc3c0c9219b2e5a5eee7ba79
> Author: Debargha Mukherjee <debargha@google.com>
> Date:   Wed Jan 10 18:12:22 2018 -0800
> 
>     No colorspace for mono-video f/ CICP compatibility
> 
> BUG= aomedia:1673 
> 
> And remove references to the deadline parameter.
> 
> BUG= aomedia:13 
> 
> Updates bear-av1.webm and disables bear-av1.mp4 test.
> ffmpeg muxing of av1 in mp4 has not been upstreamed yet.
> The webm file was generated with the av1 tree in this
> update.
> vpxdec media/test/data/bear-vp9.webm -o bear.y4m
> aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \
>   bear.y4m
> 
> The I frame for the AV1 test is generated with:
> aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \
>   bear.y4m --limit=1 --ivf
> 
> And then a hex editor is used to remove the 32 byte
> file header and 12 byte frame header.
> 
> BUG= chromium:783519 
> 
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e
> 
> NOPRESUBMIT=true (due to presubmit confusion about relative paths in DEPS)
> 
> Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e
> Reviewed-on: https://chromium-review.googlesource.com/1101705
> Commit-Queue: Johann Koenig <johannkoenig@google.com>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569100}

TBR=dalecurtis@chromium.org,jschuh@chromium.org,tomfinegan@chromium.org,hubbe@chromium.org,johannkoenig@google.com,tdaede@mozilla.com

Change-Id: Iea0ad8d1bff6db507eac0be065f3dfe0ba248e5f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  aomedia:1673 ,  aomedia:13 ,  chromium:783519 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1109557
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569125}
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/DEPS
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/media/filters/aom_video_decoder.cc
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/media/filters/aom_video_decoder_unittest.cc
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/media/test/data/av1-I-frame-320x240
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/media/test/data/av1-I-frame-352x288
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/media/test/data/bear-av1.webm
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/BUILD.gn
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/BUILD.gn.cmake
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/DEPS
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/README.chromium
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/cmake_update.sh
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/generate_gni.sh
[modify] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/libaom_srcs.gni
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/aom_version.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/config/aom_version.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.asm
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.c
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_dsp_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_scale_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/av1_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon/config/aom_config.asm
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon/config/aom_config.c
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon/config/aom_config.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon/config/aom_dsp_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon/config/aom_scale_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm-neon/config/av1_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm/config/aom_config.asm
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm/config/aom_config.c
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm/config/aom_config.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm/config/aom_dsp_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm/config/aom_scale_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm/config/av1_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm64/config/aom_config.asm
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm64/config/aom_config.c
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm64/config/aom_config.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm64/config/aom_dsp_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm64/config/aom_scale_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/arm64/config/av1_rtcd.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/ia32/aom_config.asm
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/ia32/aom_config.c
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/ia32/aom_config.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/ia32/aom_dsp_rtcd.h
[rename] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/ia32/aom_scale_rtcd.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/ia32/av1_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/ia32/config/aom_config.asm
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/ia32/config/aom_config.c
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/ia32/config/aom_config.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/ia32/config/aom_dsp_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/ia32/config/av1_rtcd.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/x64/aom_config.asm
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/x64/aom_config.c
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/x64/aom_config.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/x64/aom_dsp_rtcd.h
[copy] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/x64/aom_scale_rtcd.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/linux/x64/av1_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/x64/config/aom_config.asm
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/x64/config/aom_config.c
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/x64/config/aom_config.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/x64/config/aom_dsp_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/x64/config/aom_scale_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/linux/x64/config/av1_rtcd.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/ia32/aom_config.asm
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/ia32/aom_config.c
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/ia32/aom_config.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/ia32/aom_dsp_rtcd.h
[copy] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/ia32/aom_scale_rtcd.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/ia32/av1_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/ia32/config/aom_config.asm
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/ia32/config/aom_config.c
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/ia32/config/aom_config.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/ia32/config/aom_dsp_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/ia32/config/aom_scale_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/ia32/config/av1_rtcd.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/x64/aom_config.asm
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/x64/aom_config.c
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/x64/aom_config.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/x64/aom_dsp_rtcd.h
[copy] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/x64/aom_scale_rtcd.h
[add] https://crrev.com/d03f1b1e0f92606743eafff80da6b2bb3bb1c6d9/third_party/libaom/source/config/win/x64/av1_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/x64/config/aom_config.asm
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/x64/config/aom_config.c
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/x64/config/aom_config.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/x64/config/aom_dsp_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/x64/config/aom_scale_rtcd.h
[delete] https://crrev.com/6407dba4c9759affdb5ef44b9235601bc6b4ba9e/third_party/libaom/source/config/win/x64/config/av1_rtcd.h

The revert was due to msan builds failing because cmake_update.sh doesn't generate linux/generic config while BUILD.gn selects that target for msan.
We could either try msan with linux/x64 or add the linux/generic config to resolve this.
Project Member

Comment 34 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4a9e51ecca29cda16260e9505a62bbdd890912a

commit b4a9e51ecca29cda16260e9505a62bbdd890912a
Author: Johann <johannkoenig@google.com>
Date: Thu Jun 21 18:30:37 2018

Roll src/third_party/libaom/source/libaom/ cc92258a0..c5a56b99d (3832 commits)

Re-land with working msan support:
https://chromium-review.googlesource.com/c/chromium/src/+/1109557

https://aomedia.googlesource.com/aom.git/+log/cc92258a08d9..c5a56b99df86

$ git log cc92258a0..c5a56b99d --date=short --no-merges --format='%ad %ae %s'
(...)

Created with:
  roll-dep src/third_party/libaom/source/libaom

As part of the roll we must update the colorspace signaling.

Originally added to libaom in
commit 9e69463febe0ee8525cb5a99ee5f9f11286581f1
Author: Andrey Norkin <anorkin@netflix.com>
Date:   Thu Dec 21 18:50:57 2017 -0800

    CICP colorspace signaling

Monochrome is signaled outside of CICP:
commit f340fece2c18f068dc3c0c9219b2e5a5eee7ba79
Author: Debargha Mukherjee <debargha@google.com>
Date:   Wed Jan 10 18:12:22 2018 -0800

    No colorspace for mono-video f/ CICP compatibility

BUG= aomedia:1673 

And remove references to the deadline parameter.

BUG= aomedia:13 

Updates bear-av1.webm and disables bear-av1.mp4 test.
ffmpeg muxing of av1 in mp4 has not been upstreamed yet.
The webm file was generated with the av1 tree in this
update.
vpxdec media/test/data/bear-vp9.webm -o bear.y4m
aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \
  bear.y4m

The I frame for the AV1 test is generated with:
aomenc -o bear-av1.webm -p 2 --target-bitrate=150 \
  bear.y4m --limit=1 --ivf

And then a hex editor is used to remove the 32 byte
file header and 12 byte frame header.

BUG= chromium:783519 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0b89285155e286f921448b221a491f9ed24cfd6e

NOPRESUBMIT=true (due to presubmit confusion about relative paths in DEPS)

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie74c407f903b166948dd519c47339cfd09e6751c
Reviewed-on: https://chromium-review.googlesource.com/1109742
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#569330}
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/DEPS
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/media/filters/aom_video_decoder.cc
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/media/filters/aom_video_decoder_unittest.cc
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/media/test/data/av1-I-frame-320x240
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/media/test/data/av1-I-frame-352x288
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/media/test/data/bear-av1.webm
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/media/test/pipeline_integration_test.cc
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/BUILD.gn
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/BUILD.gn.cmake
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/DEPS
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/README.chromium
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/cmake_update.sh
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/generate_gni.sh
[modify] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/libaom_srcs.gni
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/aom_version.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/config/aom_version.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.asm
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.c
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_dsp_rtcd.h
[copy] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_scale_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/av1_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon/config/aom_config.asm
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon/config/aom_config.c
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon/config/aom_config.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon/config/aom_dsp_rtcd.h
[copy] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon/config/aom_scale_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm-neon/config/av1_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm/config/aom_config.asm
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm/config/aom_config.c
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm/config/aom_config.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm/config/aom_dsp_rtcd.h
[copy] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm/config/aom_scale_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm/config/av1_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm64/config/aom_config.asm
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm64/config/aom_config.c
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm64/config/aom_config.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm64/config/aom_dsp_rtcd.h
[copy] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm64/config/aom_scale_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/arm64/config/av1_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/generic/aom_config.asm
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/generic/aom_config.c
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/generic/aom_config.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/generic/aom_dsp_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/generic/av1_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/generic/config/aom_config.asm
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/generic/config/aom_config.c
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/generic/config/aom_config.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/generic/config/aom_dsp_rtcd.h
[rename] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/generic/config/aom_scale_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/generic/config/av1_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/ia32/aom_config.asm
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/ia32/aom_config.c
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/ia32/aom_config.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/ia32/aom_dsp_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/ia32/av1_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/ia32/config/aom_config.asm
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/ia32/config/aom_config.c
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/ia32/config/aom_config.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/ia32/config/aom_dsp_rtcd.h
[rename] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/ia32/config/aom_scale_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/ia32/config/av1_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/x64/aom_config.asm
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/x64/aom_config.c
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/x64/aom_config.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/x64/aom_dsp_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/x64/aom_scale_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/linux/x64/av1_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/x64/config/aom_config.asm
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/x64/config/aom_config.c
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/x64/config/aom_config.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/x64/config/aom_dsp_rtcd.h
[copy] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/x64/config/aom_scale_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/linux/x64/config/av1_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/ia32/aom_config.asm
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/ia32/aom_config.c
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/ia32/aom_config.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/ia32/aom_dsp_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/ia32/aom_scale_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/ia32/av1_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/ia32/config/aom_config.asm
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/ia32/config/aom_config.c
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/ia32/config/aom_config.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/ia32/config/aom_dsp_rtcd.h
[copy] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/ia32/config/aom_scale_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/ia32/config/av1_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/x64/aom_config.asm
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/x64/aom_config.c
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/x64/aom_config.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/x64/aom_dsp_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/x64/aom_scale_rtcd.h
[delete] https://crrev.com/3504586e6d1da7f6eb01c303dfeb207061de00f8/third_party/libaom/source/config/win/x64/av1_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/x64/config/aom_config.asm
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/x64/config/aom_config.c
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/x64/config/aom_config.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/x64/config/aom_dsp_rtcd.h
[copy] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/x64/config/aom_scale_rtcd.h
[add] https://crrev.com/b4a9e51ecca29cda16260e9505a62bbdd890912a/third_party/libaom/source/config/win/x64/config/av1_rtcd.h

Status: Assigned (was: ExternalDependency)
The last two things left from the chrome side are:
- Add support for parsing the AV1 configuration from mp4 and webm. This is blocked by not having any spec compliant media yet. The webm spec is not even defined I believe. I have started the mp4 av1c processing at least though: https://chromium-review.googlesource.com/c/chromium/src/+/1107260
- Enable offloading and zero-copy optimizations from the av1 decoder. This requires fixing libaom to not pack 8-bit content in 16-bit values or to teach chrome how to handle this. 
Project Member

Comment 36 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d969f8bf68f19c41a37374e9190084d938107fa6

commit d969f8bf68f19c41a37374e9190084d938107fa6
Author: Johann <johannkoenig@google.com>
Date: Sat Jun 23 01:21:25 2018

Roll src/third_party/libaom/source/libaom/ c5a56b99d..63256264a (76 commits)

Update to the finalized version of the AV1 bitstream.

https://aomedia.googlesource.com/aom.git/+log/c5a56b99df86..63256264a978

$ git log c5a56b99d..63256264a --date=short --no-merges --format='%ad %ae %s'
2018-06-22 yaowu Replace "<< 1" with "* 2"
2018-06-22 tdaede Don't write timing or display model for still pictures.
2018-06-22 ravi.chaudhary Fix highbd warp intrinsic module
2018-06-19 tdaede [NORMATIVE] Update decoder_peek_si_internal to match RAP spec.
2018-06-21 debargha [NORMATIVE] Fix dr preds when upsampling is enabled
2018-06-20 huisu Reset seen_frame_header before decoding a frame
2018-06-21 debargha [NORMATIVE] Rem rest. for show_exisitng_frames
2018-06-21 zoeliu Remove duplicate assert statement
2018-06-20 anorkin [NORMATIVE] Update of decoder model syntax
2018-06-20 rathaval common: convolve: Use memcpy in av1_convolve_2d_copy_sr_c
2018-06-20 ravi.chaudhary Fixed issue in AV1MultiThreaded/TestVectorTest
2018-05-24 yuec Add wavelet energy based q modulation
2018-06-20 angiebird Turn off inter_mode_data_push on multi-tile mode
2018-06-20 david.barker [NORMATIVE] Fix random-access decoding
2018-06-21 johannkoenig Revert "Fix bug in round shift array unit test"
2018-06-20 angiebird Implement handle_intra_mode
2018-06-19 angiebird Move skip_repeated_mv into order indep skip func
2018-06-19 angiebird Move ref_frame_skip_mask out of search_state
2018-06-19 angiebird Move mode_skip_mask out of search_state
2018-06-21 sachin.kumargarg Add ARM Neon optimization of compound_diffwtd_mask_d16
(...)

Created with:
  roll-dep src/third_party/libaom/source/libaom

BUG= chromium:783519 

Change-Id: I2532d7bf4684c19dea2b9606f6ed6d60bf0165f2
Reviewed-on: https://chromium-review.googlesource.com/1112501
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#569869}
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/DEPS
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/README.chromium
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/libaom_srcs.gni
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/config/aom_version.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.asm
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_config.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_dsp_rtcd.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/av1_rtcd.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm-neon/config/aom_config.asm
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm-neon/config/aom_config.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm-neon/config/aom_dsp_rtcd.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm-neon/config/av1_rtcd.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm/config/aom_config.asm
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm/config/aom_config.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm64/config/aom_config.asm
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm64/config/aom_config.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm64/config/aom_dsp_rtcd.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/arm64/config/av1_rtcd.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/generic/config/aom_config.asm
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/generic/config/aom_config.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/ia32/config/aom_config.asm
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/ia32/config/aom_config.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/x64/config/aom_config.asm
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/linux/x64/config/aom_config.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/win/ia32/config/aom_config.asm
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/win/ia32/config/aom_config.h
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/win/x64/config/aom_config.asm
[modify] https://crrev.com/d969f8bf68f19c41a37374e9190084d938107fa6/third_party/libaom/source/config/win/x64/config/aom_config.h

Looking at: https://aomedia.googlesource.com/aom/+log/63256264a..av1-normative
There was another normative change since:
"[NORMATIVE] level_idx=31, initial_display_delay"
https://aomedia.googlesource.com/aom/+/c7511dee486661b48109a77db89d7bcba92333a3


Good catch ::sad face::
Project Member

Comment 39 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c696907d7202d2b3cba3017aa5421b59ec49eef

commit 1c696907d7202d2b3cba3017aa5421b59ec49eef
Author: Johann <johannkoenig@google.com>
Date: Sat Jun 23 22:44:01 2018

Roll src/third_party/libaom/source/libaom/ 63256264a..1c2430a2e (6 commits)

https://aomedia.googlesource.com/aom.git/+log/63256264a978..1c2430a2e13a

$ git log 63256264a..1c2430a2e --date=short --no-merges --format='%ad %ae %s'
2018-06-21 niva213 hbd lpf sse2 perf and code quality improvement
2018-06-21 ddvfinite Speed up av1_optimize_b
2018-06-21 zoeliu Merge two flags to one for hierarchical structure
2018-06-22 anorkin [NORMATIVE] level_idx=31, initial_display_delay
2018-06-22 birkbeck Clear {cb,cr}_grain_block when there is no scaling function
2018-06-21 sachin.kumargarg Add ARM Neon optimization of aom_highbd_dc_predictor

Created with:
  roll-dep src/third_party/libaom/source/libaom

BUG= chromium:783519 
TBR=tomfinegan@chromium.org

Change-Id: I86949822c95cd18d2739ca9c3c99fbdc9d0028cd
Reviewed-on: https://chromium-review.googlesource.com/1112944
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#569904}
[modify] https://crrev.com/1c696907d7202d2b3cba3017aa5421b59ec49eef/DEPS
[modify] https://crrev.com/1c696907d7202d2b3cba3017aa5421b59ec49eef/third_party/libaom/README.chromium
[modify] https://crrev.com/1c696907d7202d2b3cba3017aa5421b59ec49eef/third_party/libaom/libaom_srcs.gni
[modify] https://crrev.com/1c696907d7202d2b3cba3017aa5421b59ec49eef/third_party/libaom/source/config/config/aom_version.h
[modify] https://crrev.com/1c696907d7202d2b3cba3017aa5421b59ec49eef/third_party/libaom/source/config/linux/arm-neon-cpu-detect/config/aom_dsp_rtcd.h
[modify] https://crrev.com/1c696907d7202d2b3cba3017aa5421b59ec49eef/third_party/libaom/source/config/linux/arm-neon/config/aom_dsp_rtcd.h
[modify] https://crrev.com/1c696907d7202d2b3cba3017aa5421b59ec49eef/third_party/libaom/source/config/linux/arm64/config/aom_dsp_rtcd.h

Project Member

Comment 40 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1226c4efafd07e87cda3ba01af94f4528b8d87ab

commit 1226c4efafd07e87cda3ba01af94f4528b8d87ab
Author: David Michael Barr <david.barr@samsung.com>
Date: Fri Jun 29 14:58:19 2018

libaom: remove obsolete yasm define

Android ABI compat code for x86 assembly was removed August 2016.
See vpx_ports/x86_abi_support.asm in: "more cleanup of vp8 and vp9"
https://aomedia.googlesource.com/aom/+/a3cff082

Bug:  783519 
Change-Id: Ifb32c16d8d6bc139860d9a0f8a29e8e5c558c947
Reviewed-on: https://chromium-review.googlesource.com/1119615
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#571475}
[modify] https://crrev.com/1226c4efafd07e87cda3ba01af94f4528b8d87ab/third_party/libaom/BUILD.gn

Project Member

Comment 41 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd0ef48fe3b260fe6a99b6f1b1b21347b73bf53c

commit dd0ef48fe3b260fe6a99b6f1b1b21347b73bf53c
Author: David Michael Barr <david.barr@samsung.com>
Date: Wed Jul 11 17:20:08 2018

libaom: defer RTCD header generation to cmake

We only need to format the files generated by cmake.
This causes no change to the current configuration.
This facilitates upcoming changes to the generator.

Bug:  783519 
Change-Id: If8e51f082881728c46a8ee9924db5d2c3ac13d11
Reviewed-on: https://chromium-review.googlesource.com/1132267
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#574208}
[modify] https://crrev.com/dd0ef48fe3b260fe6a99b6f1b1b21347b73bf53c/third_party/libaom/cmake_update.sh

 http://crbug.com/aomedia/999  tracking 8 bit in 16 bit issue in libaom
Status: Fixed (was: Assigned)
 issue 867613  tracks remaining optimizations, but this is fixed overall.

Sign in to add a comment