New issue
Advanced search Search tips

Issue 783516 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

media/ui tests aren't compiled against O SDK

Project Member Reported by ntfschr@chromium.org, Nov 10 2017

Issue description

I'm writing a CL to resolve  issue 783418 , and I was surprised to realize that the media/ui java tests [1] aren't compiled with the O SDK, but with the N_MR1 SDK. My evidence is that `Build.VERSION_CODES.O` isn't defined (but N_MR1 is).

Why do these tests use a different SDK than the rest of chromium? Is there a reason this shouldn't move up to the O SDK?

Possible duplicate of issue 729029 (the meaning of that issue wasn't clear to me).

[1] https://cs.chromium.org/chromium/src/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationFaviconTest.java?l=87

 
I chatted with a teammate, it sounds like we're using the N_MR1 SDK because robolectric doesn't support O yet ( issue 729135 ). Correct me if I've misunderstood.

Does our compile-sdk have to match the sdk-level robolectric runs at, or is this just a decision the team made? Feel free to wontfix this if we can't/don't want to bump our compile-sdk until robolectric supports O.
Status: Verified (was: Assigned)
I think this was resolved by  issue 729135 .

Sign in to add a comment