gooftool verify_keys seem not finding key problems on disk. |
|||||||||
Issue descriptionFrom some screenshot from partners, I found that when the kernel on HDD partition 5 is incorrect, verify_keys today may not show failure. verify_kernel all failed with stderr 'Error verifying key block' but the result is passed. We should review verify_keys and make sure it's reporting the right results.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/4da002ff0902ee4572933d7f896d167f42ba79ec commit 4da002ff0902ee4572933d7f896d167f42ba79ec Author: Ting Shen <phoenixshen@google.com> Date: Fri Nov 10 04:40:27 2017 gooftool: fix verify_keys When 'vbutil_kernel --verify' failed, verify_keys tries to diagnose which key is actually using, but forgot to raise error if all diagnosis failed. Add a re-throw for this case. BUG= chromium:783507 TEST=none Change-Id: Ida204684660f82a31e3da3bdaf986b6b50a8ee27 Reviewed-on: https://chromium-review.googlesource.com/762928 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/4da002ff0902ee4572933d7f896d167f42ba79ec/py/gooftool/core.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/0878f6ef0b0187c8f38d7dbef3a4783db9a6b23b commit 0878f6ef0b0187c8f38d7dbef3a4783db9a6b23b Author: Ting Shen <phoenixshen@google.com> Date: Fri Nov 10 04:40:30 2017 gooftool: fix verify_keys When 'vbutil_kernel --verify' failed, verify_keys tries to diagnose which key is actually using, but forgot to raise error if all diagnosis failed. Add a re-throw for this case. BUG= chromium:783507 TEST=none Change-Id: Ida204684660f82a31e3da3bdaf986b6b50a8ee27 Reviewed-on: https://chromium-review.googlesource.com/762808 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/0878f6ef0b0187c8f38d7dbef3a4783db9a6b23b/py/gooftool/core.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/71c457d5ea15cce3859efc33847656ef629a2e35 commit 71c457d5ea15cce3859efc33847656ef629a2e35 Author: Ting Shen <phoenixshen@google.com> Date: Fri Nov 10 04:43:28 2017 gooftool: fix verify_keys When 'vbutil_kernel --verify' failed, verify_keys tries to diagnose which key is actually using, but forgot to raise error if all diagnosis failed. Add a re-throw for this case. BUG= chromium:783507 TEST=none Change-Id: Ida204684660f82a31e3da3bdaf986b6b50a8ee27 Reviewed-on: https://chromium-review.googlesource.com/762809 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/71c457d5ea15cce3859efc33847656ef629a2e35/py/gooftool/core.py
,
Nov 10 2017
thanks for the quick solution!
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/27a04108b43fe8e3b90e8d540b59545f009c5fff commit 27a04108b43fe8e3b90e8d540b59545f009c5fff Author: Ting Shen <phoenixshen@google.com> Date: Fri Nov 10 04:45:59 2017 gooftool: fix verify_keys When 'vbutil_kernel --verify' failed, verify_keys tries to diagnose which key is actually using, but forgot to raise error if all diagnosis failed. Add a re-throw for this case. BUG= chromium:783507 TEST=none Change-Id: Ida204684660f82a31e3da3bdaf986b6b50a8ee27 Reviewed-on: https://chromium-review.googlesource.com/763027 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/27a04108b43fe8e3b90e8d540b59545f009c5fff/py/gooftool/core.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/f4cf9e8702e41d80e2b74803c028a5229733bec1 commit f4cf9e8702e41d80e2b74803c028a5229733bec1 Author: Ting Shen <phoenixshen@google.com> Date: Fri Nov 10 04:48:37 2017 gooftool: fix verify_keys When 'vbutil_kernel --verify' failed, verify_keys tries to diagnose which key is actually using, but forgot to raise error if all diagnosis failed. Add a re-throw for this case. BUG= chromium:783507 TEST=none Change-Id: Ida204684660f82a31e3da3bdaf986b6b50a8ee27 Reviewed-on: https://chromium-review.googlesource.com/762909 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/f4cf9e8702e41d80e2b74803c028a5229733bec1/py/gooftool/core.py
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/0275300eb7497a37a509d0ee3d7989cdf5e05bfe commit 0275300eb7497a37a509d0ee3d7989cdf5e05bfe Author: Ting Shen <phoenixshen@google.com> Date: Sat Nov 11 00:27:27 2017 gooftool: fix verify_keys When 'vbutil_kernel --verify' failed, verify_keys tries to diagnose which key is actually using, but forgot to raise error if all diagnosis failed. Add a re-throw for this case. BUG= chromium:783507 TEST=none Change-Id: Ida204684660f82a31e3da3bdaf986b6b50a8ee27 Reviewed-on: https://chromium-review.googlesource.com/762688 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/0275300eb7497a37a509d0ee3d7989cdf5e05bfe/py/gooftool/core.py
,
Jan 22 2018
,
Jan 23 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hungte@chromium.org
, Nov 10 2017