New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 783487 link

Starred by 2 users
Status: Fixed
Owner:
█ ortuno@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 740783



Sign in to add a comment

desktop-pwas: Capture same origin links to different scope

Project Member Reported by ortuno@chromium.org, Nov 10 2017 
What steps will reproduce the problem?
(1) Go to google.com and search for google maps.
(2) Click link to Google Maps

What is the expected result?
Google Maps app should open

What happens instead?
Tab just navigates to google.com/maps
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b4c8d53655a73886563a3731619ca3b7c52cda0

commit 3b4c8d53655a73886563a3731619ca3b7c52cda0
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Mon Nov 20 07:15:33 2017

desktop-pwas: Keep same app navigation in the browser

Before we would keep same origin navigations in the browser, but that
would mean that navigating from https://www.google.com/ to
https://www.google.com/maps wouldn't open the app.

Now, we compare the app for the current URL with that of the target app
and if they don't match we open the app, otherwise we keep the navigation
in the same context.


Bug:  783487 
Change-Id: I0ecafbf006b502f60c665d91b9f3c838a4157dc2
Reviewed-on: https://chromium-review.googlesource.com/778401
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517770}
[modify] https://crrev.com/3b4c8d53655a73886563a3731619ca3b7c52cda0/chrome/browser/extensions/bookmark_app_navigation_throttle.cc
[modify] https://crrev.com/3b4c8d53655a73886563a3731619ca3b7c52cda0/chrome/browser/extensions/bookmark_app_navigation_throttle.h
[modify] https://crrev.com/3b4c8d53655a73886563a3731619ca3b7c52cda0/chrome/browser/extensions/bookmark_app_navigation_throttle_browsertest.cc

Comment 2 by ortuno@chromium.org, Nov 21 2017

Status: Fixed (was: Started)
There is some follow up work to be done to change which app opens when there are multiple nested apps but that is tracked on Issue 786902
►

Sign in to add a comment