New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783480 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add confirmation dialog for installation of PWAs.

Project Member Reported by mcgreevy@chromium.org, Nov 10 2017

Issue description

Mock: go/ltepd.
 
gridlayout.png
6.9 KB View Download
boxlayout.png
6.9 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/556227a5a0ebb6a048b8ae89648b306a88f74c84

commit 556227a5a0ebb6a048b8ae89648b306a88f74c84
Author: Michael McGreevy <mcgreevy@chromium.org>
Date: Thu Nov 16 07:47:24 2017

Add a PWA install confirmation dialog.

This dialog will be displayed in response to any of the following:
* user clicks on the "Add to Desktop" menu item
* user clicks on the omnibox badge
* developer calls beforeinstallprompt.prompt()

Bug:  783480 

Change-Id: I5af411d4fe826902e664f72f67ac4f66c9151756
Reviewed-on: https://chromium-review.googlesource.com/726958
Commit-Queue: Michael McGreevy <mcgreevy@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517018}
[modify] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/extensions/bookmark_app_helper.cc
[modify] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/extensions/bookmark_app_helper_browsertest.cc
[modify] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.cc
[modify] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/ui/views/extensions/bookmark_app_confirmation_view.h
[add] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/ui/views/extensions/pwa_confirmation_view.cc
[add] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/ui/views/extensions/pwa_confirmation_view.h
[add] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/ui/views/extensions/pwa_confirmation_view_browsertest.cc
[add] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/ui/views/extensions/web_app_info_image_source.cc
[add] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/browser/ui/views/extensions/web_app_info_image_source.h
[modify] https://crrev.com/556227a5a0ebb6a048b8ae89648b306a88f74c84/chrome/test/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment