New issue
Advanced search Search tips

Issue 783459 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 777555



Sign in to add a comment

Undefined-shift in av_read_frame

Project Member Reported by ClusterFuzz, Nov 9 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5016870515376128

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  av_read_frame
  base::OnceCallback<int
  void base::internal::ReturnAsParamAdapter<int>
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=462018:462036

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5016870515376128

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 9 2017

Components: Internals>Core
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 9 2017

Labels: Test-Predator-Auto-Owner
Owner: tzik@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/6e42784f92a0b66a3eae584358ec4a8778bffa33 (Migrate base::TaskRunner from Closure to OnceClosure).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by tzik@chromium.org, Nov 10 2017

Components: -Internals>Core Internals>Media>FFmpeg
Labels: Test-Predator-Wrong-CLs Test-Predator-Wrong-Components
Owner: ----
Status: Untriaged (was: Assigned)
Blocking: 777555
Owner: dalecur...@chromium.org
Status: Assigned (was: Untriaged)
From ffmpeg roll probably.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/791bcb5945b07fc2255c894b612a09f3c19aa6dc

commit 791bcb5945b07fc2255c894b612a09f3c19aa6dc
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Nov 17 22:44:04 2017

Prevent undefined shift with wrap_bits >= 63.

2LL << (wrap_bits=63 - 1) does not fit in int64_t; apply the same
check used in other places that handle wrap bits to ensure the
values are < 63.

BUG= 783459 
TEST=ubsan test no longer fails

Signed-off-by: Dale Curtis <dalecurtis@chromium.org>
Change-Id: I480c6e44dbd71f5abc311696ff5cd5facfe03cd6
Reviewed-on: https://chromium-review.googlesource.com/777842
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>

[modify] https://crrev.com/791bcb5945b07fc2255c894b612a09f3c19aa6dc/libavformat/utils.c
[modify] https://crrev.com/791bcb5945b07fc2255c894b612a09f3c19aa6dc/chromium/patches/README

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aea3d2d4d8d304df1a029ef83d248508073bd066

commit aea3d2d4d8d304df1a029ef83d248508073bd066
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Sat Nov 18 06:56:26 2017

Roll ffmpeg DEPS and fix additional ubsan issues.

This change enables AV_EF_EXPLODE such that all serious errors
encountered during demuxing are fatal. Previously ffmpeg would
try to ignore these in some cases; leading to ubsan or other
issues. Specifically  crbug.com/698524  and  crbug.com/710791 .

Due to the removal of the speex parser from ogg, there is one
test that needs updating with the roll too.

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/1e816bccb5ff..252244150ad7

$ git log 1e816bccb..252244150 --date=short --no-merges --format='%ad %ae %s'
2017-11-17 dalecurtis [mpeg4video] Fix undefined shift on assumed 8-bit input.
2017-11-17 dalecurtis Disable unused ogg codec parsers; they have bugs we don't care about.
2017-11-17 dalecurtis Use ff_thread_once for fixed, float table init.
2017-11-17 dalecurtis Fixup some patches messages.
2017-11-17 dalecurtis [mov] Fix leak of frame_duration_buffer in mov_fix_index().
2017-11-17 dalecurtis Prevent undefined shift with wrap_bits >= 63.
2017-11-15 hubbe avformat/mov: Check size of STSC allocation
2017-11-17 jstebbins [PATCH] lavf/mov: don't read outside frag_index bounds

Created with:
  roll-dep src/third_party/ffmpeg

BUG= 786269 , 782074 , 783459 , 784159 , 654612 , 779924 , 710791 , 698524 
TEST=security test cases no longer fail.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ibbf3c32080705d6484682351a351663c51a7f752
Reviewed-on: https://chromium-review.googlesource.com/777408
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517709}
[modify] https://crrev.com/aea3d2d4d8d304df1a029ef83d248508073bd066/DEPS
[modify] https://crrev.com/aea3d2d4d8d304df1a029ef83d248508073bd066/media/filters/ffmpeg_demuxer_unittest.cc
[modify] https://crrev.com/aea3d2d4d8d304df1a029ef83d248508073bd066/media/filters/ffmpeg_glue.cc

Project Member

Comment 8 by ClusterFuzz, Nov 19 2017

ClusterFuzz has detected this issue as fixed in range 517703:517710.

Detailed report: https://clusterfuzz.com/testcase?key=5016870515376128

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  av_read_frame
  base::OnceCallback<int
  void base::internal::ReturnAsParamAdapter<int>
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=462018:462036
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=517703:517710

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5016870515376128

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Nov 19 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5016870515376128 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f1b654208478be9851c8b2a2ee2591d88d3b99c

commit 7f1b654208478be9851c8b2a2ee2591d88d3b99c
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Wed Nov 22 03:24:28 2017

Roll src/third_party/ffmpeg/ 168dfaa19..abead8cbc (6 commits)

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/168dfaa19bfd..abead8cbcf89

$ git log 168dfaa19..abead8cbc --date=short --no-merges --format='%ad %ae %s'
2017-11-21 dalecurtis [vorbis] 1 << 31 > int32_t::max(), so use 1u << 31 instead.
2017-11-21 dalecurtis [mov] Increment stsd_count while processing stsd data; avoids leaks.
2017-11-21 dalecurtis Update wrap_bits fix to work with wrap_bits == 63,64.
2017-11-21 dalecurtis Free extradata before reallocating.
2017-11-21 dalecurtis Add mips64el build files based.
2017-11-21 milko.leporis [MIPS] Put mips64el Linux configuration options

BUG= 787347 , 786803 , 786808 , 783459 
TEST=test cases no longer fail.
TBR=tguilbert

Created with:
  roll-dep src/third_party/ffmpeg

Change-Id: I20b262e221d31a6449b9de966d312e14df67b6b9
Reviewed-on: https://chromium-review.googlesource.com/784104
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518523}
[modify] https://crrev.com/7f1b654208478be9851c8b2a2ee2591d88d3b99c/DEPS

Dale, this patch isn't yet in upstream ffmpeg; it's still correctly tracked by our downstream patches README as of M67 roll  bug 803898 .
not in M68 roll either.

Sign in to add a comment