New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783452 link

Starred by 8 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Even with 'Do not disturb' icon set, every new notification pops up in the notification center.

Project Member Reported by mkarkada@chromium.org, Nov 9 2017

Issue description

Chrome OS: 10032.32.0/ 63.0.3239.49 beta channel caroline device

Steps:
1. Sign in, goto notification center.
2. Click on 'Do not disturb' icon (i.e. set to do not disturb mode).
3. Start downloading some files from the web.
4. Observe the notifications in the notification center.

Actual Result:
Even with 'Do not disturb' icon set, every new notification pops up. 

Expected result:
In 'Do not disturb' mode, notification pop up should be disabled. Only the notification count must increase.

Please refer the issue video and logs.
 
Cc: yoshiki@chromium.org
I'm still seeing this issue on M64 build (10176.22.0, 64.0.3282.41).
Labels: M-64
Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)
I confirmed the issue. Tetsui-san, could you take a look?

Comment 6 by tetsui@chromium.org, Dec 21 2017

Tried this on ToT. The behavior is only limited to download notification. Let me investigate further.

https://screencast.googleplex.com/cast/NTEwMjMzMzAxNjkzMjM1MnwwNzkxOWU4NC04ZA

Comment 7 by tetsui@chromium.org, Dec 26 2017

Status: Started (was: Assigned)

Comment 9 by dymp...@gmail.com, Jan 11 2018

Confirming fixed on 

Google Chrome	64.0.3282.79 (Official Build) beta (64-bit)
Revision	0
Platform	10176.41.0 (Official Build) beta-channel caroline
Firmware Version	Google_Caroline.7820.356.0
Customization ID	SAMSUNG-CAROLINE
ARC	4530929
JavaScript	V8 6.4.388.19
Flash	28.0.0.137 /opt/google/chrome/pepper/libpepflashplayer.so
User Agent	Mozilla/5.0 (X11; CrOS x86_64 10176.41.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.79 Safari/537.36

Comment 10 by dymp...@gmail.com, Jan 11 2018

Sorry, for comment#9 it does not pop up a screenshot notification.

It does for a file download.


Screenshot 2018-01-11 at 12.35.45 AM.png
1003 KB View Download
Screenshot 2018-01-11 at 12.37.18 AM.png
141 KB View Download
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50243ad4b7b0ff7e2691eeb07f5c39a21b999eed

commit 50243ad4b7b0ff7e2691eeb07f5c39a21b999eed
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Mon Jan 15 02:59:08 2018

Fix Download notification in do-not-disturb mode.

When a notification is updated, it is possible to also update the
notification priority. When priority is updated, the notification will
appear as a popup toast again. However, We should not show the
notification as a popup toast when do-not-disturb mode is enabled.

TEST=NotificationListTest.UpdateNotificationWithQuietMode
BUG= 783452 

Change-Id: I88147f88749381236f59c46f21458f43116fbc7c
Reviewed-on: https://chromium-review.googlesource.com/844006
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529190}
[modify] https://crrev.com/50243ad4b7b0ff7e2691eeb07f5c39a21b999eed/ui/message_center/notification_list.cc
[modify] https://crrev.com/50243ad4b7b0ff7e2691eeb07f5c39a21b999eed/ui/message_center/notification_list_unittest.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on CrOS: 10323.39.0, 65.0.3325.89 beta channel eve device.
This issue appears to have reared its head again in v66. It did appear to have been fixed for a bit. While I am not getting the pop-ups when notifications come in, there is still the audible tone for each notification even when DND is turned on.

- Merg
Was just updated to 66.0.3359.203 (Official Build) (32-bit) and still have the issue...

- Merg
Labels: Hotlist-ConOps-CrOS
Well, after being updated to v67, I thought the issue was rectified. However, after not using my Chromebook for a week, I have found that I receive the audible notification as well as the visual icon notification still when I have turned on "Do Not Disturb".

I am currently using v67.0.3396.87 (Official Build) (32-bit).

- Merg
#17: Could you provide which notification did you get the audible tone from?
We don't have audible tone for web notifications by default. That means either the notifications is probably from Android, or the website generating the notification is playing the sound background.
@tetsui:

Sorry for the delay. I did not realize that you had responded.

I'm not sure what you mean by which notification did I get the audible tone from? When I have Notifications turned on and an email or any other notification comes into my Chromebook, I get an audible tone along with the visible indicator that I have notifications. I suppose it could be that the audible tone is from Outlook for Android, which is what I use for email on my Chromebook, however, I still get an indicator for every notification that comes through even though I have it on "Do Not Disturb".

I also just updated to 68.0.3440.118 (Official Build) (32-bit) and the issue is still present.

- Merg
Android notifications can not be turned off via the Chrome OS shelf notification/message center > do not disturb

1. go to the individual Android app > turn off or snooze/pause notifications
2. Android settings > sound & notification > do not disturb
Screenshot 2018-09-02 at 8.12.21 AM.png
401 KB View Download

Sign in to add a comment