Issue metadata
Sign in to add a comment
|
A11y: expose AX link role as ATK_ROLE_LINK |
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.89 Safari/537.36 Steps to reproduce the problem: The links in a document should be exposed to ATK using the AtkHyperlinkImpl interface, that should allow to fetch an AtkHyperlink with the link information. What is the expected behavior? What went wrong? This has never been implemented in Chromium. Did this work before? No Chrome version: 64.0.3260.2 Channel: stable OS Version: Flash Version:
,
Nov 10 2017
As per comment#0 considering it as feature and marking it as untriaged.
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4d527503af5b132e53868710ec393f74e48e50ef commit 4d527503af5b132e53868710ec393f74e48e50ef Author: Jose Dapena Paz <jose.dapena@lge.com> Date: Tue Nov 14 16:18:37 2017 Export AtkHyperlinkImpl and AtkHyperlink for link role. On ATK accessibility model, embedded hyperlinks accessibility nodes should be exposed as ATK objects implementing AtkHyperlinkImpl interface. This interface should provide the get_hyperlink method that returns an AtkHyperlink object with the hyperlink URL and status. This implementation is equivalent to the one found in Firefox and in WebKitGTK: it will return always one anchor, that will point to the link embedding object. It does not implement the get_start_index and get_end_index yet. Bug: 783447 Change-Id: I72163b1cce18c7cc3c8f732d5eaa45987b86a420 Reviewed-on: https://chromium-review.googlesource.com/762316 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#516318} [modify] https://crrev.com/4d527503af5b132e53868710ec393f74e48e50ef/content/browser/BUILD.gn [add] https://crrev.com/4d527503af5b132e53868710ec393f74e48e50ef/content/browser/accessibility/browser_accessibility_atk_hyperlink.cc [add] https://crrev.com/4d527503af5b132e53868710ec393f74e48e50ef/content/browser/accessibility/browser_accessibility_atk_hyperlink.h [modify] https://crrev.com/4d527503af5b132e53868710ec393f74e48e50ef/content/browser/accessibility/browser_accessibility_auralinux.cc [modify] https://crrev.com/4d527503af5b132e53868710ec393f74e48e50ef/content/browser/accessibility/browser_accessibility_auralinux.h
,
Nov 14 2017
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1622826665b8e03c6732bb8ecdb16ed736cc358 commit b1622826665b8e03c6732bb8ecdb16ed736cc358 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Wed Nov 15 07:05:13 2017 [jumbo] avoid ToBrowserAccessibilityAuraLinux redefinition Followup to https://chromium-review.googlesource.com/762316 Bug: 783447 ,746953 Change-Id: I7935a609ff9f460d02a1373c0e4528887dcd8955 Reviewed-on: https://chromium-review.googlesource.com/769948 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#516620} [modify] https://crrev.com/b1622826665b8e03c6732bb8ecdb16ed736cc358/content/browser/accessibility/browser_accessibility_atk_hyperlink.cc [modify] https://crrev.com/b1622826665b8e03c6732bb8ecdb16ed736cc358/content/browser/accessibility/browser_accessibility_auralinux.cc [modify] https://crrev.com/b1622826665b8e03c6732bb8ecdb16ed736cc358/content/browser/accessibility/browser_accessibility_auralinux.h
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fe385870629d143c8c737ac061393b8b9aa7025 commit 6fe385870629d143c8c737ac061393b8b9aa7025 Author: Jose Dapena Paz <jose.dapena@lge.com> Date: Fri Nov 17 18:33:04 2017 Fix ATK hyperlink action castings. This is a fix for a regression introduced by this jumbo fix: commit b1622826665b8e03c6732bb8ecdb16ed736cc358 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Wed Nov 15 07:05:13 2017 +0000 [jumbo] avoid ToBrowserAccessibilityAuraLinux redefinition The change reuses the BrowserAccessibilityAuraLinux AtkAction casting for BrowserAccessibilityAtkHyperlink. But it is not the same object, and it will break the hyperlink action support. So let's provide again a specific casting, but with a name that will not clash with jumbo build. Bug: 783447 Change-Id: I319154aadd5aa040a2222d533ca94cb83877068e Reviewed-on: https://chromium-review.googlesource.com/776778 Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Cr-Commit-Position: refs/heads/master@{#517484} [modify] https://crrev.com/6fe385870629d143c8c737ac061393b8b9aa7025/content/browser/accessibility/browser_accessibility_atk_hyperlink.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Nov 9 2017