New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783437 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature

Blocked on:
issue 783435



Sign in to add a comment

Add BROTLI_BSDIFF operation to update_engine

Project Member Reported by ahass...@chromium.org, Nov 9 2017

Issue description

After brotli support is added in the CrOS, add support for BROTLI_BSDIFF operation. This operation asks bsdiff to compress its patch using brotli instead of bzip2. This will decrease the patch size on average 10-20%.
 
Blockedon: 783435
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0ed80033959633b64c3cc72f275452b019154977

commit 0ed80033959633b64c3cc72f275452b019154977
Author: Amin Hassani <ahassani@google.com>
Date: Wed Nov 15 08:39:51 2017

bsdiff: mark stable

- Marks bsdiff as stable
- Adds dependency to app-arch/brotli

BUG= chromium:783437 
TEST=unittests pass
CQ-DEPEND=CL:768600,CL:761342

Change-Id: I19da0e1ca6c3fe53cab6afbc6751e55e48e1bd94
Reviewed-on: https://chromium-review.googlesource.com/769228
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/0ed80033959633b64c3cc72f275452b019154977/dev-util/bsdiff/bsdiff-9999.ebuild
[rename] https://crrev.com/0ed80033959633b64c3cc72f275452b019154977/dev-util/bsdiff/bsdiff-4.3.1-r7.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/88e9fef0c400c6dd64aef92f48d843978c659a16

commit 88e9fef0c400c6dd64aef92f48d843978c659a16
Author: Amin Hassani <ahassani@google.com>
Date: Thu Nov 23 01:29:38 2017

bsdiff: mark as stable

BUG= chromium:783437 
TEST=unittests pass

Change-Id: Ia82518cb7de523a6af45653e7ffbc2ef64b0e532
Reviewed-on: https://chromium-review.googlesource.com/780448
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[rename] https://crrev.com/88e9fef0c400c6dd64aef92f48d843978c659a16/dev-util/bsdiff/bsdiff-4.3.1-r8.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/efa62d959cf8f225477ab85d8ff42d5150007cf8

commit efa62d959cf8f225477ab85d8ff42d5150007cf8
Author: Amin Hassani <ahassani@google.com>
Date: Thu Nov 23 01:29:40 2017

update_engine: Adds BROTLI_BSDIFF operation

Brotli compression creates on average 10%-20% smaller output than bzip2
in addition to having faster decompressor. With recent changes in bsdiff
to compress the its patch with brotli, we can use it in the
update_engine as a new operation BROTLI_BSDIFF. This operation will be
turned on in minor version 4. However, this CL only adds support for it
in the client. It will not generate BROTLI_BSDIFF operations yet.

BUG= chromium:783437 
TEST=unittests pass for both update_engine and update_payload;
'brillo_update_payload {generate|verify}' passes;
'scripts/paycheck.py payload.delta' passes;

Change-Id: Ie791ba5431561c95de6fbc031a8196dbfd912288
Reviewed-on: https://chromium-review.googlesource.com/764791
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/scripts/update_payload/update_metadata_pb2.py
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/scripts/update_payload/checker.py
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/payload_consumer/payload_constants.cc
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/payload_generator/ab_generator.h
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/payload_generator/payload_generation_config.cc
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/update_metadata.proto
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/scripts/update_payload/checker_unittest.py
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/scripts/update_payload/applier.py
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/scripts/update_payload/common.py
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/payload_consumer/delta_performer.cc
[modify] https://crrev.com/efa62d959cf8f225477ab85d8ff42d5150007cf8/payload_generator/delta_diff_utils.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment