New issue
Advanced search Search tips

Issue 783418 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 729135



Sign in to add a comment

Inline isAtLeastO and targetsAtLeastO

Project Member Reported by ntfschr@chromium.org, Nov 9 2017

Issue description

Now that the O SDK is (long-since) finalized, we can inline the implementation of isAtLeastO and targetsAtLeastO.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/97d40f3cd3ef83c0d82595ad26e0464131f8b5ec

commit 97d40f3cd3ef83c0d82595ad26e0464131f8b5ec
Author: Nate Fischer <ntfschr@google.com>
Date: Thu Nov 09 22:44:45 2017

Blockedon: 729135
I guess robolectric doesn't support O yet (and we also don't compile our robolectric tests against O). Since there's one robolectric test which uses isAtLeastO, we'll have to wait to inline that call.

Otherwise, upstream CL is at: https://chromium-review.googlesource.com/c/chromium/src/+/762136
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edca8f9863448ccf7486bed1932a2445f6c3133c

commit edca8f9863448ccf7486bed1932a2445f6c3133c
Author: Nate Fischer <ntfschr@chromium.org>
Date: Tue Nov 14 23:53:29 2017

Android: inline isAtLeastO and targetsAtLeastO

No change in logic.

This inlines isAtLeastO and targetsAtLeastO checks, since the SDK
constant is available. This also removes the targetsAtLeastO method,
since it's no longer used (isAtLeastO is required for robolectric
tests, which compile with the N_MR1 SDK).

Downstream uses are removed in another CL.

This also fixes some import mistakes, due to presubmit warnings.

Bug:  783418 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4d03589b7fabd2475ad5b4642013c11160ff793e
Reviewed-on: https://chromium-review.googlesource.com/762136
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516507}
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/android_webview/glue/java/src/com/android/webview/chromium/WebViewDatabaseAdapter.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/android_webview/java/src/org/chromium/android_webview/AwSettings.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/base/android/java/src/org/chromium/base/ApiCompatibilityUtils.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/base/android/java/src/org/chromium/base/ApplicationStatus.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/base/android/java/src/org/chromium/base/BuildInfo.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/base/android/java/src/org/chromium/base/SysUtils.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/media/PictureInPictureController.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaSessionTabHelper.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderFactory.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationBuilderForO.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationManagerProxyImpl.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationSettingsBridge.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/ChannelsUpdater.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/ntp/ContentSuggestionsNotifier.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/prefetch/PrefetchedPagesNotifier.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/preferences/NotificationsPreferences.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/upgrade/PackageReplacedBroadcastReceiver.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/chrome/android/java/src/org/chromium/chrome/browser/widget/ViewResourceFrameLayout.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationClientService.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/components/invalidation/impl/android/java/src/org/chromium/components/invalidation/InvalidationService.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/net/android/java/src/org/chromium/net/X509Util.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[modify] https://crrev.com/edca8f9863448ccf7486bed1932a2445f6c3133c/ui/android/java/src/org/chromium/ui/display/PhysicalDisplayAndroid.java

Cc: changwan@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c73cf09b10ff7f068fafefc6eb651fc4db8d9f1

commit 2c73cf09b10ff7f068fafefc6eb651fc4db8d9f1
Author: Nate Fischer <ntfschr@chromium.org>
Date: Tue Dec 05 20:33:29 2017

Android: remove isAtLeastO from robolectric test

This removes the final use of BuildInfo.isAtLeastO from chromium code.

This was previously blocked on robolectric not supporting O (but this
has since been resolved by  crbug.com/729135 ).

Bug:  783418 
Test: ninja chrome_junit_tests
Change-Id: Ib7d4af9ff74912ccadfa3c9cae57553f3a217e94
Reviewed-on: https://chromium-review.googlesource.com/806745
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521811}
[modify] https://crrev.com/2c73cf09b10ff7f068fafefc6eb651fc4db8d9f1/base/android/java/src/org/chromium/base/BuildInfo.java
[modify] https://crrev.com/2c73cf09b10ff7f068fafefc6eb651fc4db8d9f1/chrome/android/junit/src/org/chromium/chrome/browser/media/ui/MediaNotificationFaviconTest.java

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Bulk edit: marking stale 'fixed' bugs as 'verified' since they don't need verification at this point.

Sign in to add a comment