Take a stab at removing unused .grd strings. |
||
Issue descriptionUsing this to track some work. Not intending to finish something or end up with zero dead strings due to this effort.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/211309f13f31396b304afde679aec2f1f1f1849f commit 211309f13f31396b304afde679aec2f1f1f1849f Author: Peter Boström <pbos@chromium.org> Date: Fri Nov 10 01:20:50 2017 Remove IDS_PRINTER_DETECTED_NOTIFICATION_* strings. These strings used to be referenced by chrome/browser/chromeos/dbus but the printer service provider that used them is no longer present and the strings are no longer referenced. Bug: chromium:783396 Change-Id: I440abd89c19688b0e4f2496e3d439695da684751 Reviewed-on: https://chromium-review.googlesource.com/762180 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#515399} [modify] https://crrev.com/211309f13f31396b304afde679aec2f1f1f1849f/chrome/app/generated_resources.grd
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0408cb08b2b33dfa87619aa32292b134a4580099 commit 0408cb08b2b33dfa87619aa32292b134a4580099 Author: Peter Boström <pbos@chromium.org> Date: Fri Nov 10 18:59:15 2017 Remove unreferenced IDS_SEARCH_ENGINES_* strings. These strings are no longer referenced outside .grd files and generated build files resulting from them. Bug: chromium:783396 Change-Id: I5f8b1d870c9fb1a8ef719fc7db03c8906a31aa08 Reviewed-on: https://chromium-review.googlesource.com/761817 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#515620} [modify] https://crrev.com/0408cb08b2b33dfa87619aa32292b134a4580099/chrome/app/generated_resources.grd
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/528eec57d56872a0a4f82548ace0e1cfa834cfaf commit 528eec57d56872a0a4f82548ace0e1cfa834cfaf Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Nov 10 19:21:19 2017 CrOS: Eliminate unused strings from chromeos_strings.grdp Includes a minor change to check_grd_for_unused_strings.py Found running the following with the change to check_grd_for_unused_strings.py: ./tools/check_grd_for_unused_strings.py chrome \ chrome/app/chromeos_strings.grdp Some of these came from the switch to the new Settings UI and were missed, some have just been lingering for a very long time. Bug: 771795, 783396 Change-Id: If6d9ab01f909c69d6375459d314e97ce3633ceaf Reviewed-on: https://chromium-review.googlesource.com/762383 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Scott Graham <scottmg@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#515629} [modify] https://crrev.com/528eec57d56872a0a4f82548ace0e1cfa834cfaf/chrome/app/chromeos_strings.grdp [modify] https://crrev.com/528eec57d56872a0a4f82548ace0e1cfa834cfaf/tools/check_grd_for_unused_strings.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff1be1ca52597bc9aee5df64c75e6ca1d49f5e96 commit ff1be1ca52597bc9aee5df64c75e6ca1d49f5e96 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Nov 10 21:29:45 2017 Eliminate some unused CrOS/panel/app list related strings Found running the following with the change to check_grd_for_unused_strings.py: ./tools/check_grd_for_unused_strings.py chrome \ chrome/app/generated_resources.grd Only a subset of strings from deprecated CrOS/panel/app list features were removed in this CL. Bug: 771795, 783396 CrOS: Elim unised strings from chromeos_strings.grdp Change-Id: I9accc2027f66d5b7b8ff9d45461a29bacafbb301 Reviewed-on: https://chromium-review.googlesource.com/762521 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515687} [modify] https://crrev.com/ff1be1ca52597bc9aee5df64c75e6ca1d49f5e96/chrome/app/generated_resources.grd
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/039d77c4e610bd9df5dbc5b12b5c51615a052b2c commit 039d77c4e610bd9df5dbc5b12b5c51615a052b2c Author: Peter Boström <pbos@chromium.org> Date: Fri Nov 17 21:03:02 2017 Remove old IDS_CONTEXTUAL_SEARCH strings. These strings were previously referenced in non-java code but are now only referenced by their R.string equivalents in android_chrome_strings.grd. Bug: chromium:783396 Change-Id: I2230169954a8e78fa3a1e50b95c0348e9a47dce2 Reviewed-on: https://chromium-review.googlesource.com/776338 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#517549} [modify] https://crrev.com/039d77c4e610bd9df5dbc5b12b5c51615a052b2c/chrome/app/chromium_strings.grd [modify] https://crrev.com/039d77c4e610bd9df5dbc5b12b5c51615a052b2c/chrome/app/google_chrome_strings.grd
,
Dec 6 2017
Marking obsolete until I get around to doing more, this clutters my bug view. |
||
►
Sign in to add a comment |
||
Comment 1 by steve...@chromium.org
, Nov 10 2017