I got around this by ungrouping each individual group, and then grouping the resulting alerts all together.

This is something I should have mentioned earlier during the planning for grouping alerts by default. 

Grouping groups together was never implemented for the initial grouping logic because we decided it should be added later since it's not really clear how groups of groups should function (ie: which group gets to be the "primary" group, do we want to preserve a record of previous groups' structure). 

I never finished this doc since I had to go work on other things, but I did briefly address this issue is a design doc on improving grouping: https://docs.google.com/document/d/10TVyFohK29caoJN36WGEkkTubXvmESC9D_COBJSYfXg/edit#heading=h.tcf4ubff6zwb 

I also ran into this. It was very frustrating.

Here's a screenshot of this happening on the perf waterfall right now: these alerts were grouped a few minutes ago.

Deleted: gGQWJPzFF6L.png 342 KB

	gGQWJPzFF6L.png 342 KB View Download

There are two bugs here; one is what charlie shows in #5, where grouping just doesn't seem to work. I've seen this, and I don't really understand it.

The other is what tiffany mentions in #2. We need to add the ability to group groups; I'm not sure what the best way to come up with the group name is, but it's pretty important. There are cases where you have 10 tests in a test suite failing, and that shows up as 10 different alerts. Those should all be grouped under the same group.

I've seen the bug in #5 multiple times over the past two days as well.

I agree that we need the ability to group groups.

We also should probably start w/ failures grouped by builder/test suite, rather than by test.

For large test suites like browser_tests or webkit_layout_tests, it's easy for a change to break dozens of tests at once, and that makes the current UI almost unmanageable (I guess it'd make it comparable to the 200+ steps on the older perf bot configs).

Just want to reiterate that this is important for perf bot health sheriffing. Right now, I'm looking at 30 alerts that should be merged, all in groups of two. In order to merge them, I need to first unmerge them to 60 alerts all and then remerge all of those, which is a very tedious process.

In total, that means that the process takes 30 clicks (to ungroup) + 60 clicks (to individually select each of the alerts) + 1 click (to regroup) instead of the 31 clicks it'd take to group the alerts usually.

Ah - I actually lied: ungrouping a particular alert requires clicking "Ungroup", then clicking "Select all" in the subsequent dialog, then clicking "OK". That means that the whole process takes 150 clicks instead of the 31 that it'd usually take.

I thought we fixed this months ago, we haven't fixed this?

(#c13 was meant to be surprise, as in, I honestly thought we had fixed this. Apologies if it sounds too complain-y instead).

To make sure we're fixing the right problem here: Is the problem that the automatically grouped perf alerts are grouped incorrectly in the fist place (is there some property they all have in common that could be identified in code)? 

If so, fixing the bug by "Allow grouping groups together" sounds like we'd solving it at the wrong layer.

(No worries, re #14)

Sorry: somehow I missed this. I suspect that there is an element of incorrect grouping in the first place, and I think we should continue to make progress on that, but I suspect that we're never going to get 100% correct alert grouping. Sometimes, multiple benchmarks will break together in a way that's hard to detect programmatically (e.g. they all log in to Google and we change the Google login logic in Telemetry in a bad way). In these instances, it's still definitely useful to be able to group alert groups manually.

Also, I think just generally, the current behavior is confusing - there's no negative feedback when you try to group alert groups together, just... nothing.

Just bumping this again. I had to link to this bug when rewriting the perfbot health sheriffing docs because it's such a point of confusion among sheriffs: https://docs.google.com/document/d/1UIs_G8B7qKp2H7p-1B5jtpDhs1BhqAOfZP2o4ugS_lk/edit#bookmark=id.xiz8oqyll1ki

Can someone from SOM team help tackling this bug? It has a big effect on perf sheriff's productivity.

I'll take a closer look at this today, starting with zhangtiff's design doc for merging groups. 

Just to clarify: What I'd be aiming for is "reduce the number of clicks required to regroup things", not "automatically group things better in the first place".

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/de719dedc09f6cc6fdf0d8ddccbbed0f26ef3ce5

commit de719dedc09f6cc6fdf0d8ddccbbed0f26ef3ce5
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Tue Apr 03 22:09:42 2018

[som] Make buttons hide when hidden

I was confused about why the "Group All" button didn't disappear
when multiple groups are selected (since the code was indeed setting
hidden=true in that case). Yay CSS!

From https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden :
"Note: Changing the value of the CSS display property on an element with the hidden attribute overrides the behavior. For instance, elements styled display: flex will be displayed despite the hidden attribute's presence."

Bug: 783360
Change-Id: I8ecfb21e9b6ad32063e8c00c77fbeec6b34c8982
Reviewed-on: https://chromium-review.googlesource.com/994113
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/de719dedc09f6cc6fdf0d8ddccbbed0f26ef3ce5/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-input-styles.html

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/0aa4d1f00d60c6dd82092d7b0a1aa703e4e72462

commit 0aa4d1f00d60c6dd82092d7b0a1aa703e4e72462
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Wed Apr 04 00:22:13 2018

[som] Add bulk ungroup feature.

chromium.perf has a use case where they currently have to manually
ungroup lots of alerts.  This provides one action to ungroup any number
of groups into individual alerts.

Bug: 783360
Change-Id: Icfecb49044535180336f380e3c5940a776d608a4
Reviewed-on: https://chromium-review.googlesource.com/994258
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/0aa4d1f00d60c6dd82092d7b0a1aa703e4e72462/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[modify] https://crrev.com/0aa4d1f00d60c6dd82092d7b0a1aa703e4e72462/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/0aa4d1f00d60c6dd82092d7b0a1aa703e4e72462/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.html
[modify] https://crrev.com/0aa4d1f00d60c6dd82092d7b0a1aa703e4e72462/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fd1269b33ee7bf594f1f11de2651db0b4b4d7300

commit fd1269b33ee7bf594f1f11de2651db0b4b4d7300
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Wed Apr 04 19:11:28 2018

[som] Check ungrouped alerts after doing a bulk ungroup.

Bug: 783360
Change-Id: Ice690c5f2b0b4b5c5abbfa98ad319acfbc7f732b
Reviewed-on: https://chromium-review.googlesource.com/996182
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/fd1269b33ee7bf594f1f11de2651db0b4b4d7300/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.html
[modify] https://crrev.com/fd1269b33ee7bf594f1f11de2651db0b4b4d7300/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-view/som-alert-view.js
[modify] https://crrev.com/fd1269b33ee7bf594f1f11de2651db0b4b4d7300/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-alert-category/som-alert-category.js
[modify] https://crrev.com/fd1269b33ee7bf594f1f11de2651db0b4b4d7300/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.html
[modify] https://crrev.com/fd1269b33ee7bf594f1f11de2651db0b4b4d7300/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js

Just pushed a change to prod that makes it much easier to deal with this situation. You can ungroup groups in bulk, and doing so will leave the individual alerts checked and ready for a "Group All" action to regroup them all into one group.

I've done all the work on this that I can justify for the time being.

Leaving it Available in case someone wants to make the complete "Merge groups" feature.

Great!

 Issue 898753  has been merged into this issue.