[TTS] Bar left hanging when network is disabled |
||||||
Issue descriptionTap to get CS to show the Bar. Enter airplane mode. The selection and Bar remain even though CS is disconnected from the Tab and won't respond to events, including scrolling (which would normally dismiss the Bar). This is also happening on 62 Stable.
,
Feb 14 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5c83b43bfaef0b95d9913fbf1f78f3b53192bbe commit e5c83b43bfaef0b95d9913fbf1f78f3b53192bbe Author: Donn Denman <donnd@google.com> Date: Wed Feb 14 17:04:50 2018 [TTS] Hide the CS UI when entering airplane mode. When Contextual Search enters a disabled state it removes notifiers for showing the UI. However if the UI is already showing it should hide it immediately. This CL adds a call to hide when disabling for any reason, including network connectivity loss. BUG= 783352 Change-Id: I826d38264cd6c0cb5ca6ece804c2f44c3b0ee924 Reviewed-on: https://chromium-review.googlesource.com/917647 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#536738} [modify] https://crrev.com/e5c83b43bfaef0b95d9913fbf1f78f3b53192bbe/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Feb 14 2018
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7bdb0782e45ed6d5359a56e331363c80fefc480 commit a7bdb0782e45ed6d5359a56e331363c80fefc480 Author: Donn Denman <donnd@chromium.org> Date: Thu Feb 15 18:13:42 2018 Revert "[TTS] Hide the CS UI when entering airplane mode." This reverts commit e5c83b43bfaef0b95d9913fbf1f78f3b53192bbe. Reason for revert: Broke normal usage (crbug.com/812542) Original change's description: > [TTS] Hide the CS UI when entering airplane mode. > > When Contextual Search enters a disabled state it removes notifiers > for showing the UI. However if the UI is already showing it should > hide it immediately. This CL adds a call to hide when disabling for > any reason, including network connectivity loss. > > BUG= 783352 > > Change-Id: I826d38264cd6c0cb5ca6ece804c2f44c3b0ee924 > Reviewed-on: https://chromium-review.googlesource.com/917647 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536738} TBR=donnd@chromium.org,twellington@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 783352 Change-Id: I33da18a5e3d71dfd71717e0488d272d843a838c7 Reviewed-on: https://chromium-review.googlesource.com/922221 Reviewed-by: Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#537073} [modify] https://crrev.com/a7bdb0782e45ed6d5359a56e331363c80fefc480/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Feb 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35851c3bb198989a0665d7bd126fb2f1cd7c3c7f commit 35851c3bb198989a0665d7bd126fb2f1cd7c3c7f Author: Donn Denman <donnd@chromium.org> Date: Thu Feb 15 18:23:18 2018 Revert "[TTS] Hide the CS UI when entering airplane mode." This reverts commit e5c83b43bfaef0b95d9913fbf1f78f3b53192bbe. Reason for revert: Broke normal usage (crbug.com/812542) Original change's description: > [TTS] Hide the CS UI when entering airplane mode. > > When Contextual Search enters a disabled state it removes notifiers > for showing the UI. However if the UI is already showing it should > hide it immediately. This CL adds a call to hide when disabling for > any reason, including network connectivity loss. > > BUG= 783352 > > Change-Id: I826d38264cd6c0cb5ca6ece804c2f44c3b0ee924 > Reviewed-on: https://chromium-review.googlesource.com/917647 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536738} TBR=donnd@chromium.org,twellington@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 783352 Change-Id: I33da18a5e3d71dfd71717e0488d272d843a838c7 Reviewed-on: https://chromium-review.googlesource.com/922221 Reviewed-by: Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#537073}(cherry picked from commit a7bdb0782e45ed6d5359a56e331363c80fefc480) Reviewed-on: https://chromium-review.googlesource.com/922482 Reviewed-by: Claude Masso <cmasso@chromium.org> Cr-Commit-Position: refs/branch-heads/3348@{#5} Cr-Branched-From: 62c55a88a1aa6b877054b25d06e3ab0ea505d253-refs/heads/master@{#536934} [modify] https://crrev.com/35851c3bb198989a0665d7bd126fb2f1cd7c3c7f/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Feb 15 2018
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e3c4a35aca938c9c07f2898673096ec2b62eec8 commit 3e3c4a35aca938c9c07f2898673096ec2b62eec8 Author: Donn Denman <donnd@google.com> Date: Thu Feb 22 18:14:16 2018 [TTS] Hide the CS UI when entering airplane mode. When Contextual Search enters a disabled state it removes notifiers for showing the UI. However if the UI is already showing it should hide it immediately. This CL adds a call to hide when disabling for network connectivity loss. BUG= 783352 Change-Id: Ic938df3f0717a2b3e426e01ff03f469ade94c385 Reviewed-on: https://chromium-review.googlesource.com/924326 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#538483} [modify] https://crrev.com/3e3c4a35aca938c9c07f2898673096ec2b62eec8/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Feb 22 2018
,
Feb 24 2018
Verified fix in Chrome Dev 66.0.3353.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by donnd@google.com
, Feb 14 2018