New issue
Advanced search Search tips

Issue 783336 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Lost syntax highlighting for Clouje

Reported by antonin....@gmail.com, Nov 9 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.89 Safari/537.36

Steps to reproduce the problem:
I noticed the syntax highlighting for clojure is no longer applied.

What is the expected behavior?

What went wrong?
https://github.com/binaryage/dirac/commit/ab85ac7b452b30424b252b581e6d988fea7195ca#diff-ebb80bf22cc45cc0ce3407d106ba1efbR134

Did this work before? Yes 

Chrome version: 62.0.3202.89  Channel: canary
OS Version: OS X 10.13.2
Flash Version: 

See the commit above. CodeMirror contains some default styles which are language agnostic like 'cm-bracket', 'cm-keyword', 'cm-variable', 'cm-builtin' and similar. With the above change Joel recreated only cm-js-xxx, cm-css-xxx and cm-xml-xxx specific versions but didn't bring general styles over. Clojure language mode relies on those. Probably some other language modes are affected as well.
 
Labels: Needs-Triage-M62

Comment 3 by kozy@chromium.org, Nov 10 2017

Owner: einbinder@chromium.org
Status: Fixed (was: Unconfirmed)

Sign in to add a comment