A dark line is seen in new tab page when in tab switcher mode. |
||||||||
Issue descriptionApp Version: 63.0.3239.41 beta iOS Version: 11.0.1 Device: iPhone X ONLY URL: na Steps to reproduce: 1.Launch Google Chrome 2.Open NTP in landscape mode 3.Tap on tabswicher. 4.Change device orientation , open a new tab, tap on tabswicher. Observed results: NTP in tab switcher mode is messed up.There is a dark line in the NTP when in tab switcher mode. Expected results: NTP should not be messed up. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M62 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M63- Yes Type-bug-regression? Yes Link to video/image: https://drive.google.com/a/google.com/file/d/1RRtUHSUyMxtYZGf-pVVTUrJEdA86N8b_/view?usp=sharing
,
Nov 9 2017
,
Nov 10 2017
,
Nov 10 2017
I think it has more to do with the StackView than the NTP. The dark line is actually the top of the bottom toolbar of the NTP. The issue is that the pages are zoomed a lot when doing that. I can reproduce with other pages.
,
Nov 10 2017
,
Nov 10 2017
I think this has to do with how we display landscape snapshots in a portrait stack view. I think edchin@ may have done some work on snapshots recently? This is not iPhoneX related. srikanthg@ can you dup/file a different bug?
,
Nov 10 2017
Yea this is not iPhoneX only. Happens on other iPhones too. Snapshots of NTP/any web content is zoomed after rotation. Closest I got is http://crbug/667940 we can dup to it. The issue is not just NTP snapshot its with any webpage snapshot. Let me know if the other bug is not clear enough, will report a new one.
,
Nov 10 2017
Over to edchin@ for a snapshotting issue. Can you mark a severity/milestone please?
,
Nov 10 2017
I can repro this on M62 on iPhone X iOS 11 device, so it's not a regression between M62 and M63. I can also repro this on a trunk build on iPhone 7 iOS 10.3 simulator, so it's not an iOS 11 hotfix bug. In the video, the snapshot is taken in landscape mode. When the device is rotated to portrait in the stackView, the height of the cell (the tab snapshot) is kept short as it was in landscape mode. When you exit the stackView then return in portrait, all the cells are shown in full portrait size. Since the snapshot taken has a short height, the image is stretched to fit the portrait height. This results in a highly zoomed image that is cropped to the far left of the image. If you examine the dark line, you'll see that it is just a high zoomed portion of the actual snapshot. The poor effect is really due to our decision to build the StackView with rectangular snapshots rather than square snapshots, which would be more consistent between portrait and landscape. On iPhone X, this is effect is further exaggerated due to an even greater aspect ratio screen. This problem will be ameliorated when we move to a square snapshot tab switcher. I am marking this as won't fix. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by vbhatso...@chromium.org
, Nov 9 2017