New issue
Advanced search Search tips

Issue 783314 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix realtimeanalyser-fft-scaling.html

Project Member Reported by rtoy@chromium.org, Nov 9 2017 
The test has this bit of code:

        context.oncomplete = checkResult(order, analyser, should);
        return context.startRendering().then(function(audioBuffer) {
          checkResult(audioBuffer, order, analyser);
        });

I have no idea what this is supposed to be doing.  The arguments to checkResult are of different types between the promise and the oncomplete event.

Fix this.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a22b358468b85d51bb7d70154a535f54f1ec9412

commit a22b358468b85d51bb7d70154a535f54f1ec9412
Author: Raymond Toy <rtoy@chromium.org>
Date: Mon Nov 13 22:37:31 2017

Fix bad test code in fft-scaling test

The test code for verifying the scaling of the FFT was totally
confused (and confusing).  Correct the code, and only use the promise
instead of both the promise and the completion event.

Bug:  783314 
Test: Analyser/realtimeanalyser-fft-scaling.html
Change-Id: Iecc607205c1cd0ed6e76bfa7c627907238f6a46e
Reviewed-on: https://chromium-review.googlesource.com/761436
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516082}
[modify] https://crrev.com/a22b358468b85d51bb7d70154a535f54f1ec9412/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html

Comment 2 by rtoy@chromium.org, Nov 14 2017

Status: Fixed (was: Started)
►

Sign in to add a comment