New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783309 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Xoogler
Closed: Jul 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 793069



Sign in to add a comment

Refactor The Blink Task Queue Manager to the Base Sequence Manager

Project Member Reported by robliao@chromium.org, Nov 9 2017

Issue description

Assess, audit, update, and move
//third_party/WebKit/Source/platform/scheduler/base/
to
//base [undecided location]

Design doc : https://docs.google.com/document/d/1h-FlOeO-27g__JnuRvdJ8KG9G-bmG_zn6zuw7GerFkc/edit
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c319b9eb2e499adc1fb8d0100e7af5e8c142454b

commit c319b9eb2e499adc1fb8d0100e7af5e8c142454b
Author: Francois Doray <fdoray@chromium.org>
Date: Thu Nov 09 20:07:35 2017

[scheduler] Remove unused base/long_task_tracker_unittest.cc.

No build file refers to that file.

Bug: 783309
Change-Id: I7e7d26575cfa7814112645205d11ae05259aed4a
Reviewed-on: https://chromium-review.googlesource.com/761297
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515258}
[delete] https://crrev.com/bc2056c30e9d7245c3ef90664201eccca41418b7/third_party/WebKit/Source/platform/scheduler/base/long_task_tracker_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e174030e7ccc3cbeb8ae978e6209d8975b7cd32

commit 2e174030e7ccc3cbeb8ae978e6209d8975b7cd32
Author: Gabriel Charette <gab@chromium.org>
Date: Thu Nov 09 21:30:27 2017

Add TEAM and COMPONENT to base/task_scheduler/OWNERS

R=robliao@chromium.org

Bug: 783309
Change-Id: I445555d4fba12d278e9e0d942d475039a36a7a24
Reviewed-on: https://chromium-review.googlesource.com/761736
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515295}
[modify] https://crrev.com/2e174030e7ccc3cbeb8ae978e6209d8975b7cd32/base/task_scheduler/OWNERS

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed682b176dd73ae9198c69eefadb08fb38798906

commit ed682b176dd73ae9198c69eefadb08fb38798906
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Nov 10 14:30:01 2017

[scheduler] Move CancelableClosureHolder to child/.

CancelableClosureHolder is not used in base/. It is only used
in child/ and renderer/.

Bug: 783309
Change-Id: Ieb9745b15ef1f8b610f6e12f8e566f50e823de84
Reviewed-on: https://chromium-review.googlesource.com/761178
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515547}
[modify] https://crrev.com/ed682b176dd73ae9198c69eefadb08fb38798906/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[rename] https://crrev.com/ed682b176dd73ae9198c69eefadb08fb38798906/third_party/WebKit/Source/platform/scheduler/child/cancelable_closure_holder.cc
[rename] https://crrev.com/ed682b176dd73ae9198c69eefadb08fb38798906/third_party/WebKit/Source/platform/scheduler/child/cancelable_closure_holder.h
[modify] https://crrev.com/ed682b176dd73ae9198c69eefadb08fb38798906/third_party/WebKit/Source/platform/scheduler/child/idle_helper.h
[modify] https://crrev.com/ed682b176dd73ae9198c69eefadb08fb38798906/third_party/WebKit/Source/platform/scheduler/renderer/deadline_task_runner.h
[modify] https://crrev.com/ed682b176dd73ae9198c69eefadb08fb38798906/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20cde4eaa43549ff7e7039c7dd28fa21d3a56f79

commit 20cde4eaa43549ff7e7039c7dd28fa21d3a56f79
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Nov 10 17:26:28 2017

[scheduler] Move MonotonicTimeInSecondsToTimeTicks to worker_scheduler_impl.cc.

This base/ function is only used in worker_scheduler_impl.cc. It makes
sense to move it to the anonymous namespace of
worker_scheduler_impl.cc.

Bug: 783309
Change-Id: I7c963347fa1a9a599b037088c10e8cbdd7f7594c
Reviewed-on: https://chromium-review.googlesource.com/761419
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515581}
[modify] https://crrev.com/20cde4eaa43549ff7e7039c7dd28fa21d3a56f79/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[delete] https://crrev.com/8ec7714af9698919b2f8b40f3f23e1d8130fb464/third_party/WebKit/Source/platform/scheduler/base/time_converter.h
[modify] https://crrev.com/20cde4eaa43549ff7e7039c7dd28fa21d3a56f79/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc
[modify] https://crrev.com/20cde4eaa43549ff7e7039c7dd28fa21d3a56f79/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Components: Internals Internals>SequenceManager
Components: -Internals
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37ce9b49795d7b4e7eda0f25c6851d3fa67eb660

commit 37ce9b49795d7b4e7eda0f25c6851d3fa67eb660
Author: Alexander Timin <altimin@chromium.org>
Date: Thu Nov 16 15:49:54 2017

[scheduler] Introduce ThreadController.

ThreadController is a designed replacement for TaskQueueManagerDelegate
in a SequenceManager world.

Current implementation of a ThreadController allows for drop-in
replacement of TaskQueueManagerDelegate. Further refactorings are
planned after complete deletion of TaskQueueManagerDelegate.

Full replacement code can be found at
https://chromium-review.googlesource.com/c/chromium/src/+/763511

R=skyostil@chromium.org,alexclarke@chromium.org,robliao@chromium.org,fdoray@chromium.org,gab@chromium.org

Bug: 783309

Change-Id: Id424da3cf43ac20b40c93ab7f20d79294d854df9
Reviewed-on: https://chromium-review.googlesource.com/765267
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517093}
[modify] https://crrev.com/37ce9b49795d7b4e7eda0f25c6851d3fa67eb660/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[add] https://crrev.com/37ce9b49795d7b4e7eda0f25c6851d3fa67eb660/third_party/WebKit/Source/platform/scheduler/base/sequence.h
[add] https://crrev.com/37ce9b49795d7b4e7eda0f25c6851d3fa67eb660/third_party/WebKit/Source/platform/scheduler/base/thread_controller.h
[add] https://crrev.com/37ce9b49795d7b4e7eda0f25c6851d3fa67eb660/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.cc
[add] https://crrev.com/37ce9b49795d7b4e7eda0f25c6851d3fa67eb660/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.h
[add] https://crrev.com/37ce9b49795d7b4e7eda0f25c6851d3fa67eb660/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.cc
[add] https://crrev.com/37ce9b49795d7b4e7eda0f25c6851d3fa67eb660/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.h

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e1d79f07cae5d78ff6f6b1363d990f722a9e6c0

commit 9e1d79f07cae5d78ff6f6b1363d990f722a9e6c0
Author: Francois Doray <fdoray@chromium.org>
Date: Fri Nov 17 22:19:04 2017

Make the minimum discard protection time a constant.

With the upcoming TabManager refactor, each tab will be associated
with a TabLifetimeUnit instance, which will expose a CanDiscard()
method. To avoid the need for a pointer to TabManager in
TabLifetimeUnit, this CL moves TabManager::minimum_protection_time_
to TabManager::kDiscardProtectionTime.

This CL also prevents proactive discard of a tab that has already
been discarded or that has been used recently on ChromeOS
(previously, that was only the case on non-ChromeOS platforms
- removing this protection on ChromeOS is only needed for
urgent discard).

Bug: 783309
Change-Id: Ife3698f9554dcfe705e43953eda74fdaefee60ca
Reviewed-on: https://chromium-review.googlesource.com/771781
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517583}
[modify] https://crrev.com/9e1d79f07cae5d78ff6f6b1363d990f722a9e6c0/chrome/browser/extensions/api/tabs/tabs_test.cc
[modify] https://crrev.com/9e1d79f07cae5d78ff6f6b1363d990f722a9e6c0/chrome/browser/resource_coordinator/tab_manager.cc
[modify] https://crrev.com/9e1d79f07cae5d78ff6f6b1363d990f722a9e6c0/chrome/browser/resource_coordinator/tab_manager.h
[modify] https://crrev.com/9e1d79f07cae5d78ff6f6b1363d990f722a9e6c0/chrome/browser/resource_coordinator/tab_manager_browsertest.cc
[modify] https://crrev.com/9e1d79f07cae5d78ff6f6b1363d990f722a9e6c0/chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc

Owner: altimin@chromium.org
Blocking: 793069
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d07daf95fd73f5fd92f22777e466ed9fa14e538d

commit d07daf95fd73f5fd92f22777e466ed9fa14e538d
Author: Robert Liao <robliao@chromium.org>
Date: Mon Dec 18 01:38:07 2017

Pass/store Task by value in TaskScheduler.

MessageLoop and the Blink scheduler pass/store tasks by value. This
avoids having a heap allocation for every task.

With this CL, TaskScheduler also passes/stores tasks by value. This
is a prerequisite to make the TaskScheduler and the Blink scheduler
work together.

ScopedTaskEnvironment refactor and previous review at https://chromium-review.googlesource.com/c/chromium/src/+/764531

Bug: 783309, 795024
TBR: gab@chromium.org
Change-Id: I2ae01bed216f7d4e9c6a2615689df1817a2507d0
Reviewed-on: https://chromium-review.googlesource.com/826569
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524635}
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/delayed_task_manager.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/delayed_task_manager.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/delayed_task_manager_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/priority_queue_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/scheduler_worker_pool.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/scheduler_worker_pool.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/scheduler_worker_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/sequence.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/sequence.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/sequence_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_scheduler_impl.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker_posix.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker_posix.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker_posix_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/task_tracker_unittest.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/test_utils.cc
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/task_scheduler/test_utils.h
[modify] https://crrev.com/d07daf95fd73f5fd92f22777e466ed9fa14e538d/base/test/scoped_task_environment.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80bdddf57950a3fdbc1cce96ab3bacb4a8487721

commit 80bdddf57950a3fdbc1cce96ab3bacb4a8487721
Author: Francois Doray <fdoray@chromium.org>
Date: Thu Jan 04 22:09:07 2018

Add base::RunLoop::NestingObserver::OnExitNestedRunLoop().

This method is called when a nested loop is done running work.
It will help simplify the TaskQueueManager code.

Use case:
The blink scheduler needs to adjust the time domain
when there is a transition between a nested/non-nested scope.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc?l=2302&rcl=614a67e2c14cf8bb9a06f4fe8da7625cbf1ea7d7
Currently, it checks base::RunLoop::IsNestedOnCurrentThread()
every time a task completes to detect transitions between
a nested/non-nested scope. Code would be simpler with
an explicit notification.

Bug: 783309
Change-Id: I9748c287ad8418831598d84f45a518e4138c5e1b
Reviewed-on: https://chromium-review.googlesource.com/766388
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527112}
[modify] https://crrev.com/80bdddf57950a3fdbc1cce96ab3bacb4a8487721/base/run_loop.cc
[modify] https://crrev.com/80bdddf57950a3fdbc1cce96ab3bacb4a8487721/base/run_loop.h
[modify] https://crrev.com/80bdddf57950a3fdbc1cce96ab3bacb4a8487721/base/run_loop_unittest.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36df3a6bd78fdb1297ad662587997b5d6bed3c9d

commit 36df3a6bd78fdb1297ad662587997b5d6bed3c9d
Author: Gabriel Charette <gab@chromium.org>
Date: Wed Jan 17 15:54:25 2018

Mark IncomingTaskQueue::message_loop_scheduled_ after kicking it off.

Also grab the lock although it shouldn't yet be contended for good
measure and to be future proof.

I realized it also served the purpose of serializing ScheduleWork() calls
when trying to figure out how to implement ThreadController::ScheduleWork()
(ref. Blink/TaskScheduler merge and ScopedTaskEnvironment MOCK_TIME over
non-default MessageLoops). MessageLoop::ScheduleWork() itself is
documented as requiring mutually exclusive calls (and some
MessagePump::ScheduleWork() impls indeed require this per touching
non atomic state).

R=robliao@chromium.org

Bug: 708584, 783309
Change-Id: Id6acb3176d23b8161b686f715c710646c27acfe5
Reviewed-on: https://chromium-review.googlesource.com/866836
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529753}
[modify] https://crrev.com/36df3a6bd78fdb1297ad662587997b5d6bed3c9d/base/message_loop/incoming_task_queue.cc
[modify] https://crrev.com/36df3a6bd78fdb1297ad662587997b5d6bed3c9d/base/message_loop/incoming_task_queue.h

Cc: kraynov@chromium.org
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d1ddd5706eb7a662b17511108fdd655145a8ccd

commit 9d1ddd5706eb7a662b17511108fdd655145a8ccd
Author: Alex Clarke <alexclarke@chromium.org>
Date: Fri Feb 02 16:33:21 2018

Refactor away TaskQueueManager::DoWork in favor of the Sequence interface

This patch changes the Sequence interface slightly by introducing
DelayTillNextTask which helps work around problems scheduling delayed
tasks when TakeTask doesn't have a task to return (due to cancellation).

Change-Id: I5935e41ad5bc725b6109a187b329c82ce5a70689
Bug: 783309
Reviewed-on: https://chromium-review.googlesource.com/883346
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534070}
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/sequence.h
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.cc
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.h
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/thread_controller.h
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.cc
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.h
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.cc
[modify] https://crrev.com/9d1ddd5706eb7a662b17511108fdd655145a8ccd/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.h

Project Member

Comment 19 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9badb12fc99143650afa87a335c597b9a89c917c

commit 9badb12fc99143650afa87a335c597b9a89c917c
Author: Thomas Anderson <thomasanderson@chromium.org>
Date: Fri Feb 02 18:42:00 2018

Revert "Refactor away TaskQueueManager::DoWork in favor of the Sequence interface"

This reverts commit 9d1ddd5706eb7a662b17511108fdd655145a8ccd.

Reason for revert: Causing http/tests/devtools/sources/debugger/async-callstack-fetch.js to fail on WebKit Linux Trusty ASAN:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20ASAN/8904

Original change's description:
> Refactor away TaskQueueManager::DoWork in favor of the Sequence interface
> 
> This patch changes the Sequence interface slightly by introducing
> DelayTillNextTask which helps work around problems scheduling delayed
> tasks when TakeTask doesn't have a task to return (due to cancellation).
> 
> Change-Id: I5935e41ad5bc725b6109a187b329c82ce5a70689
> Bug: 783309
> Reviewed-on: https://chromium-review.googlesource.com/883346
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534070}

TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org

Change-Id: I8eab7e997f2ca6d397b6233f7a4f3ae8664437a8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 783309
Reviewed-on: https://chromium-review.googlesource.com/899902
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534108}
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/sequence.h
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.cc
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.h
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/thread_controller.h
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.cc
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.h
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.cc
[modify] https://crrev.com/9badb12fc99143650afa87a335c597b9a89c917c/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.h

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01521901c75de270189594fa8c746c8ae31da913

commit 01521901c75de270189594fa8c746c8ae31da913
Author: Alex Clarke <alexclarke@chromium.org>
Date: Mon Feb 05 11:17:14 2018

[Reland] Refactor away TaskQueueManager::DoWork in favor of the Sequence interface

Refactor away TaskQueueManager::DoWork in favor of the Sequence interface

This patch changes the Sequence interface slightly by introducing
DelayTillNextTask which helps work around problems scheduling delayed
tasks when TakeTask doesn't have a task to return (due to cancellation).

The bug fix is using std::list rather than std:vector to hold the stack.

Bug: 783309
Change-Id: I105e80bcdcfd042bd2fdd245d1296266572d7238
Reviewed-on: https://chromium-review.googlesource.com/901322
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534363}
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/sequence.h
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.cc
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.h
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/thread_controller.h
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.cc
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.h
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.cc
[modify] https://crrev.com/01521901c75de270189594fa8c746c8ae31da913/third_party/WebKit/Source/platform/scheduler/test/lazy_thread_controller_for_test.h

Comment 21 by gab@chromium.org, Feb 7 2018

Description: Show this description
The most recent CL (https://crrev.com/c/883346) removed "TaskQueueManager::ProcessTaskFromWorkQueue" which broke some metric calculations in Lighthouse and Catapult.

Codesearch: https://cs.chromium.org/search/?q=TaskQueueManager::ProcessTaskFromWorkQueue&sq=package:chromium&type=cs

It appears as though `ThreadControllerImpl::DoWork` is the equivalent name, yeah?
Yes that's right.
Project Member

Comment 24 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7065819199069cd92e18ab28e34901a09cf19fbb

commit 7065819199069cd92e18ab28e34901a09cf19fbb
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Feb 16 13:01:25 2018

Blink Scheduler: Blocked task queue selector cleanup.

TaskQueueSelector had the logic to report when a task was prevented
from running due to one of RendererScheduler's interventions.
This feature is deprecated and now removed for sake of simplicity.

Bug: 783309
Change-Id: I0debabf6a9c340bacf780a03259006449006292e
Reviewed-on: https://chromium-review.googlesource.com/921963
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537292}
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/base/task_queue.h
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.cc
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.h
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.cc
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.h
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/7065819199069cd92e18ab28e34901a09cf19fbb/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3172bc0039de63c8cf4a3e6eadf65e92c1d5a1d

commit e3172bc0039de63c8cf4a3e6eadf65e92c1d5a1d
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Feb 21 18:46:03 2018

Remove redundant relationship between LazyNow and TaskQueueManager.

Bug: 783309
Change-Id: Ib72df466d56969853443d634632c38b3e4952e12
Reviewed-on: https://chromium-review.googlesource.com/928655
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538163}
[modify] https://crrev.com/e3172bc0039de63c8cf4a3e6eadf65e92c1d5a1d/third_party/WebKit/Source/platform/scheduler/base/lazy_now.cc
[modify] https://crrev.com/e3172bc0039de63c8cf4a3e6eadf65e92c1d5a1d/third_party/WebKit/Source/platform/scheduler/base/lazy_now.h
[modify] https://crrev.com/e3172bc0039de63c8cf4a3e6eadf65e92c1d5a1d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25cd23b87149b97b28820cce51767e5c4ddc018d

commit 25cd23b87149b97b28820cce51767e5c4ddc018d
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Feb 23 12:43:49 2018

Blink Scheduler: Split TaskQueueManager to interface and impl.

The general approach is to keep API for scheduler/base inside the impl
while exposing the public API (for renderer, child, etc.) in the interface.
This should help with further moving all that stuff to //base.

Bug: 783309
Change-Id: I5c3b65f223617f401aac4ee37318ec63a5c20a89
Reviewed-on: https://chromium-review.googlesource.com/931543
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538767}
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/task_queue.cc
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/task_queue.h
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[rename] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_impl.cc
[add] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_impl.h
[rename] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.cc
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/test/create_task_queue_manager_for_test.cc
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/25cd23b87149b97b28820cce51767e5c4ddc018d/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithMockScheduler.cpp

Project Member

Comment 27 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de4aa61ceb2eca73d93ae8be3b3e145688989eb0

commit de4aa61ceb2eca73d93ae8be3b3e145688989eb0
Author: Alexander Timin <altimin@chromium.org>
Date: Tue Feb 27 16:38:03 2018

[base/task] Create skeleton for base/task.

Create base/task/task_scheduler and base/task/sequence_manager
directories, add OWNERS files and README.md stub.

R=gab@chromium.org
BUG=783309

Change-Id: Ic30cfac8ce71e5f0553fcfb6c95e05750d15d265
Reviewed-on: https://chromium-review.googlesource.com/934444
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539455}
[add] https://crrev.com/de4aa61ceb2eca73d93ae8be3b3e145688989eb0/base/task/OWNERS
[add] https://crrev.com/de4aa61ceb2eca73d93ae8be3b3e145688989eb0/base/task/README.md
[add] https://crrev.com/de4aa61ceb2eca73d93ae8be3b3e145688989eb0/base/task/sequence_manager/OWNERS
[add] https://crrev.com/de4aa61ceb2eca73d93ae8be3b3e145688989eb0/base/task/task_scheduler/OWNERS

Project Member

Comment 28 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d57ecb90fcfa13c2b22cb352e216dd0769c77cf3

commit d57ecb90fcfa13c2b22cb352e216dd0769c77cf3
Author: Patrick Hulce <phulce@chromium.org>
Date: Fri Mar 02 02:55:51 2018

DevTools: Roll Lighthouse 2.9.1

* Fixes critical audits issue introduced by task queue refactor
* Several new audits: webfonts, preload

BUG=783309

Change-Id: Idfd825db882dc6e7a8b9a381a1184edb2c304ae0
Reviewed-on: https://chromium-review.googlesource.com/944913
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540426}
[modify] https://crrev.com/d57ecb90fcfa13c2b22cb352e216dd0769c77cf3/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/d57ecb90fcfa13c2b22cb352e216dd0769c77cf3/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/d57ecb90fcfa13c2b22cb352e216dd0769c77cf3/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
[modify] https://crrev.com/d57ecb90fcfa13c2b22cb352e216dd0769c77cf3/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/d57ecb90fcfa13c2b22cb352e216dd0769c77cf3/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js

Project Member

Comment 29 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc175711c6eaf47201a5942aa608ba2612aa1f05

commit cc175711c6eaf47201a5942aa608ba2612aa1f05
Author: Greg Kraynov <kraynov@chromium.org>
Date: Tue Mar 06 11:23:57 2018

Blink Scheduler: Rename Sequence to SequencedTaskSource.

Bug: 783309
Change-Id: I5595d5eb2f869cd3d1015f9f0838fa8e9370e9c4
Reviewed-on: https://chromium-review.googlesource.com/948912
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541072}
[modify] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[rename] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/base/sequenced_task_source.h
[modify] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/base/thread_controller.h
[modify] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.cc
[modify] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/base/thread_controller_impl.h
[modify] https://crrev.com/cc175711c6eaf47201a5942aa608ba2612aa1f05/third_party/WebKit/Source/platform/scheduler/base/work_queue.h

Project Member

Comment 30 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/305c717632838a040d99b7895c1f4ed61c8ce73e

commit 305c717632838a040d99b7895c1f4ed61c8ce73e
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Mar 07 11:19:29 2018

Blink Scheduler: Remove TaskType references from schduler/base.

When scheduler/base will be moved to //base we can't use Blink types.

Bug: 783309
Change-Id: I1d9bada5a08129a885e9fe6d2f75a02c80e03183
Reviewed-on: https://chromium-review.googlesource.com/943565
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541408}
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/base/task_queue.cc
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/base/task_queue.h
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/child/task_runner_impl.cc
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/child/task_runner_impl.h
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/child/worker_metrics_helper.cc
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.cc
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.h
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/305c717632838a040d99b7895c1f4ed61c8ce73e/third_party/WebKit/public/platform/TaskType.h

Project Member

Comment 31 by bugdroid1@chromium.org, Mar 7 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f74752d7dfe0ad935045f4ebdfb4e36cff6dace1

commit f74752d7dfe0ad935045f4ebdfb4e36cff6dace1
Author: Patrick Hulce <phulce@chromium.org>
Date: Wed Mar 07 18:38:39 2018

DevTools: Roll Lighthouse 2.9.1

* Fixes critical audits issue introduced by task queue refactor
* Several new audits: webfonts, preload

BUG=783309

Change-Id: Idfd825db882dc6e7a8b9a381a1184edb2c304ae0
Reviewed-on: https://chromium-review.googlesource.com/944913
Reviewed-by: Paul Irish <paulirish@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540426}(cherry picked from commit d57ecb90fcfa13c2b22cb352e216dd0769c77cf3)
Reviewed-on: https://chromium-review.googlesource.com/952871
Reviewed-by: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#63}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/f74752d7dfe0ad935045f4ebdfb4e36cff6dace1/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/f74752d7dfe0ad935045f4ebdfb4e36cff6dace1/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/f74752d7dfe0ad935045f4ebdfb4e36cff6dace1/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
[modify] https://crrev.com/f74752d7dfe0ad935045f4ebdfb4e36cff6dace1/third_party/WebKit/Source/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/f74752d7dfe0ad935045f4ebdfb4e36cff6dace1/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js

Project Member

Comment 33 by bugdroid1@chromium.org, Apr 27 2018

Project Member

Comment 34 by bugdroid1@chromium.org, Apr 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d965f23f56be25bfe99fde5e539b690c59e88e78

commit d965f23f56be25bfe99fde5e539b690c59e88e78
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Apr 27 19:18:34 2018

Apply stricter Chromium ctor/dtor rules for Blink's scheduler/base.

Extracted from https://chromium-review.googlesource.com/1015743
Required in order to move Blink's scheduler/base to //base.

Bug: 783309
Change-Id: Iff610ed6da964fb6c93de070ac81916bec5dceba
Reviewed-on: https://chromium-review.googlesource.com/1032781
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554439}
[modify] https://crrev.com/d965f23f56be25bfe99fde5e539b690c59e88e78/third_party/blink/renderer/platform/scheduler/base/task_queue.cc
[modify] https://crrev.com/d965f23f56be25bfe99fde5e539b690c59e88e78/third_party/blink/renderer/platform/scheduler/base/task_queue.h
[modify] https://crrev.com/d965f23f56be25bfe99fde5e539b690c59e88e78/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/d965f23f56be25bfe99fde5e539b690c59e88e78/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/d965f23f56be25bfe99fde5e539b690c59e88e78/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/d965f23f56be25bfe99fde5e539b690c59e88e78/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/d965f23f56be25bfe99fde5e539b690c59e88e78/third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.cc
[modify] https://crrev.com/d965f23f56be25bfe99fde5e539b690c59e88e78/third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.h

Project Member

Comment 35 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b

commit efa036667fd3ba4fe1768e9f32d6db1dc4f4880b
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon Apr 30 14:08:07 2018

Move scheduler/base test support to scheduler/base/test.

Required in order to move Blink's scheduler/base to //base.

Bug: 783309
Change-Id: I3d6b183a1639988f54b6104cba8543d27d8f410f
Reviewed-on: https://chromium-review.googlesource.com/1033745
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554739}
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_perftest.cc
[rename] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/base/test/task_queue_manager_for_test.cc
[rename] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/base/test/task_queue_manager_for_test.h
[rename] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/base/test/test_count_uses_time_source.cc
[rename] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/base/test/test_count_uses_time_source.h
[rename] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/base/test/test_task_queue.cc
[rename] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/base/test/test_task_queue.h
[rename] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/base/test/test_task_time_observer.h
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/renderer/idle_time_estimator_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
[modify] https://crrev.com/efa036667fd3ba4fe1768e9f32d6db1dc4f4880b/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h

Comment 36 by gab@chromium.org, May 3 2018

Labels: -Type-Bug Type-Feature
Project Member

Comment 37 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d03097fd778322f1e6e9e0caf02becb56fcae38d

commit d03097fd778322f1e6e9e0caf02becb56fcae38d
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed May 09 13:36:49 2018

Refactor TaskQueueManager unit tests.

Split into separate test fixtures to make it more straightforward.

Bug: 783309
Change-Id: Ife5353fa61a07936c3ccf8c8255f253206038df8
Reviewed-on: https://chromium-review.googlesource.com/1052007
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557166}
[modify] https://crrev.com/d03097fd778322f1e6e9e0caf02becb56fcae38d/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc

Project Member

Comment 38 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b94880fa4fecc6ecd141e9fc7b210da4a67de1b1

commit b94880fa4fecc6ecd141e9fc7b210da4a67de1b1
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed May 09 17:30:18 2018

Make TaskQueueManagerImpl tests use TestMockTimeTaskRunner.

Got rid of cc::OrderedSimpleTaskRunner dependency and slightly
cleaned TaskQueueManagerImpl unittests while adjusting the code.

Bug: 783309
Change-Id: Ibc31281b1dcdf6750b2fcc9e07bc7d7dfe1e85af
Reviewed-on: https://chromium-review.googlesource.com/1037144
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557230}
[modify] https://crrev.com/b94880fa4fecc6ecd141e9fc7b210da4a67de1b1/base/test/test_mock_time_task_runner.cc
[modify] https://crrev.com/b94880fa4fecc6ecd141e9fc7b210da4a67de1b1/base/test/test_mock_time_task_runner.h
[modify] https://crrev.com/b94880fa4fecc6ecd141e9fc7b210da4a67de1b1/base/test/test_mock_time_task_runner_unittest.cc
[delete] https://crrev.com/bea7337b8000cf0da50f2fbb4bf9e19096d0915f/third_party/blink/renderer/platform/scheduler/base/DEPS
[modify] https://crrev.com/b94880fa4fecc6ecd141e9fc7b210da4a67de1b1/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/b94880fa4fecc6ecd141e9fc7b210da4a67de1b1/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc

Project Member

Comment 39 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46290e3f2b9f12cdc16e1d5856be3a35836492bb

commit 46290e3f2b9f12cdc16e1d5856be3a35836492bb
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu May 10 15:48:25 2018

Trace scheduler/base independently.

It's getting moved to //base, so renderer.scheduler tracing
category is inappropriate.

Bug: 783309
Change-Id: I8280a218188f2de721f752f1c58cdf6555cb0943
Reviewed-on: https://chromium-review.googlesource.com/1052130
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557531}
[modify] https://crrev.com/46290e3f2b9f12cdc16e1d5856be3a35836492bb/base/trace_event/trace_event_etw_export_win.cc
[modify] https://crrev.com/46290e3f2b9f12cdc16e1d5856be3a35836492bb/third_party/blink/renderer/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/46290e3f2b9f12cdc16e1d5856be3a35836492bb/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/46290e3f2b9f12cdc16e1d5856be3a35836492bb/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/46290e3f2b9f12cdc16e1d5856be3a35836492bb/third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.cc
[modify] https://crrev.com/46290e3f2b9f12cdc16e1d5856be3a35836492bb/third_party/blink/renderer/platform/scheduler/util/tracing_helper.cc
[modify] https://crrev.com/46290e3f2b9f12cdc16e1d5856be3a35836492bb/third_party/blink/renderer/platform/scheduler/util/tracing_helper.h

Project Member

Comment 41 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0361c3ce3863fb33d61bc62591a83f330d57dd83

commit 0361c3ce3863fb33d61bc62591a83f330d57dd83
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri May 11 18:32:28 2018

Roll src/third_party/catapult/ c458fd696..b6e96e16f (1 commit)

https://chromium.googlesource.com/catapult.git/+log/c458fd6963db..b6e96e16f364

$ git log c458fd696..b6e96e16f --date=short --no-merges --format='%ad %ae %s'
2018-05-10 kraynov Introduce sequence_manager tracing category.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:783309


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia4ece1ea1f68336f2e18d6f05800735a6ae8846b
Reviewed-on: https://chromium-review.googlesource.com/1055669
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#557952}
[modify] https://crrev.com/0361c3ce3863fb33d61bc62591a83f330d57dd83/DEPS

Project Member

Comment 42 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f4784463e06ff969c11d877e43b2cebab2ba17f

commit 8f4784463e06ff969c11d877e43b2cebab2ba17f
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon May 14 10:08:21 2018

Rename namespace in scheduler/base to base::sequence_manager.

Moving scheduler/base to //base incurs enormous diff and git
doesn't detect file moves well enough as a result.
This CL mitigates that by dropping base:: prefixes before the move,
which will happen soon, so that temporary inconsistency won't stay long.

Bug: 783309
Change-Id: Iad4b2823e3304c0cb5c6a2745adf1f5f4255d4ee
Reviewed-on: https://chromium-review.googlesource.com/1035269
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558245}
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/public/platform/scheduler/child/webthread_base.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/public/platform/web_thread.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/core/frame/performance_monitor.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/core/inspector/inspector_performance_agent.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/core/loader/idleness_detector.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/long_task_detector.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/enqueue_order.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/enqueue_order.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/graceful_queue_shutdown_helper.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/graceful_queue_shutdown_helper.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/intrusive_heap.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/intrusive_heap_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/lazy_now.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/lazy_now.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/moveable_auto_lock.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/sequenced_task_source.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_delegate_for_test.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_delegate_for_test.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_selector.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_selector.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_selector_logic.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/task_time_observer.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/test/task_queue_manager_for_test.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/test/task_queue_manager_for_test.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/test/test_count_uses_time_source.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/test/test_count_uses_time_source.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/test/test_task_queue.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/test/test_task_queue.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/test/test_task_time_observer.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/thread_controller.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/work_queue.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/work_queue.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/work_queue_sets.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/work_queue_sets.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/work_queue_sets_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/base/work_queue_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/compositor_metrics_helper.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/compositor_metrics_helper.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/idle_helper.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/idle_helper.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/metrics_helper.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/metrics_helper.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/metrics_helper_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/task_runner_impl.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/task_runner_impl.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/worker_metrics_helper.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/worker_metrics_helper.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/worker_task_queue.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/child/worker_task_queue.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/cpu_time_budget_pool.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/cpu_time_budget_pool.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/throttled_time_domain.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/throttled_time_domain.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/wake_up_budget_pool.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/common/throttling/wake_up_budget_pool.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/main_thread/web_main_thread_scheduler.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/test/lazy_thread_controller_for_test.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/renderer/platform/timer_test.cc
[modify] https://crrev.com/8f4784463e06ff969c11d877e43b2cebab2ba17f/third_party/blink/tools/audit_non_blink_usage.py

Project Member

Comment 43 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/002bb3b484c1c5ed53a6ea68676c9f6e764ed73e

commit 002bb3b484c1c5ed53a6ea68676c9f6e764ed73e
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed May 16 11:03:11 2018

Enforce scheduler/base dependency isolation.

Bug: 783309
Change-Id: Ibfd73d8bd6f6f2c7640e345e0292f3bad0946b83
Reviewed-on: https://chromium-review.googlesource.com/1057329
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559035}
[add] https://crrev.com/002bb3b484c1c5ed53a6ea68676c9f6e764ed73e/third_party/blink/renderer/platform/scheduler/base/DEPS
[add] https://crrev.com/002bb3b484c1c5ed53a6ea68676c9f6e764ed73e/third_party/blink/renderer/platform/scheduler/base/README.md

Owner: kraynov@chromium.org
Project Member

Comment 45 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d33cfbbb80d33f901a6a4814688f70740bcc527

commit 2d33cfbbb80d33f901a6a4814688f70740bcc527
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu May 24 20:02:04 2018

Move ThreadController interface to base.

Also its deps: SequencedTaskSource and LazyNow.

Bug: 783309
Change-Id: Iee4c753beaa08f1373f5bac73bee31b78f338c10
Reviewed-on: https://chromium-review.googlesource.com/1061696
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561581}
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/base/BUILD.gn
[rename] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/base/task/sequence_manager/lazy_now.cc
[rename] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/base/task/sequence_manager/lazy_now.h
[add] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/base/task/sequence_manager/sequenced_task_source.h
[rename] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/base/task/sequence_manager/thread_controller.h
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/DEPS
[delete] https://crrev.com/f85585b37189469ba6c9b53dfea57d88f1a9fe0f/third_party/blink/renderer/platform/scheduler/base/sequenced_task_source.h
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.cc
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.h
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/base/work_queue.h
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool.h
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/common/throttling/cpu_time_budget_pool.h
[modify] https://crrev.com/2d33cfbbb80d33f901a6a4814688f70740bcc527/third_party/blink/renderer/platform/scheduler/common/throttling/wake_up_budget_pool.h

Project Member

Comment 46 by bugdroid1@chromium.org, Jun 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3136af187adeda62e91c424436c1c8b2117021bb

commit 3136af187adeda62e91c424436c1c8b2117021bb
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jun 08 17:49:56 2018

Move TaskQueue header to //base/task/sequence_manager.

Bug: 783309
Change-Id: I4572bf52fb31840cdb6006d8821bc29c2fd071f3
Reviewed-on: https://chromium-review.googlesource.com/1079567
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565677}
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/base/BUILD.gn
[rename] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/base/task/sequence_manager/moveable_auto_lock.h
[rename] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/base/task/sequence_manager/task_queue.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/base/task_queue.cc
[add] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/base/task_queue_forward.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/base/test/test_task_queue.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/child/task_queue_with_task_type.cc
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/common/metrics_helper.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/public/worker_scheduler.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.h
[modify] https://crrev.com/3136af187adeda62e91c424436c1c8b2117021bb/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc

Project Member

Comment 47 by bugdroid1@chromium.org, Jun 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd

commit 7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Jun 13 17:22:08 2018

Move TaskQueueImpl header to //base/task/sequence_manager.

Bug: 783309
Change-Id: I0ac7a204e5df7f980eb025534f16e0f563c47104
Reviewed-on: https://chromium-review.googlesource.com/1095616
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566889}
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/base/BUILD.gn
[add] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/base/task/sequence_manager/enqueue_order.cc
[rename] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/base/task/sequence_manager/enqueue_order.h
[rename] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/base/task/sequence_manager/intrusive_heap.h
[rename] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/base/task/sequence_manager/lazily_deallocated_deque.h
[rename] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/base/task/sequence_manager/task_queue_impl.h
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/graceful_queue_shutdown_helper.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/intrusive_heap_unittest.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/lazily_deallocated_deque_unittest.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.cc
[add] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue_impl_forward.h
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue_selector.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/test/test_task_queue.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/work_queue.h
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/work_queue_sets.h
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/base/work_queue_unittest.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.cc
[modify] https://crrev.com/7bcf3f69b49e8f441e2c0ee94b04ba2c694319dd/third_party/blink/renderer/platform/timer_test.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8f488aa5f6ba90dab557abed1027f46152c3c3d

commit e8f488aa5f6ba90dab557abed1027f46152c3c3d
Author: Greg Kraynov <kraynov@chromium.org>
Date: Thu Jun 14 20:56:42 2018

Move TaskTimeObserver to //base/task/sequence_manager.

Bug: 783309
Change-Id: I3d179e286bd82b3fb6f4c63e0c3eb9a64aaa5f68
Reviewed-on: https://chromium-review.googlesource.com/1097410
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567407}
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/base/BUILD.gn
[add] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/base/task/sequence_manager/task_time_observer.h
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/core/DEPS
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/core/frame/performance_monitor.h
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/core/inspector/inspector_performance_agent.h
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/core/loader/idleness_detector.h
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/platform/DEPS
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/platform/long_task_detector.h
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[delete] https://crrev.com/7cc71e21b0c868d8908c9f7be58a5bf1e80f9670/third_party/blink/renderer/platform/scheduler/base/task_time_observer.h
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/platform/scheduler/base/test/test_task_time_observer.h
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/e8f488aa5f6ba90dab557abed1027f46152c3c3d/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 49 by bugdroid1@chromium.org, Jun 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a9b06a57b33a5a955af04a914f85f981cf05f88

commit 6a9b06a57b33a5a955af04a914f85f981cf05f88
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jun 15 16:29:03 2018

Rename TaskQueueManager to SequenceManager.

Also some doc comments and API tidy-up.

Bug: 783309
Change-Id: I1551478010dcd47aa0169935c4a3dc219997466e
Reviewed-on: https://chromium-review.googlesource.com/1102471
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567683}
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/BUILD.gn
[add] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/base/sequence_manager.h
[delete] https://crrev.com/6fca131df518b7eb77eb53875e56c9c1ba55da3d/third_party/blink/renderer/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/common/web_thread_scheduler.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
[modify] https://crrev.com/6a9b06a57b33a5a955af04a914f85f981cf05f88/third_party/blink/renderer/platform/testing/testing_platform_support.cc

Project Member

Comment 50 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a5e3489c49885cf220416590ea2a525a772d2cc

commit 8a5e3489c49885cf220416590ea2a525a772d2cc
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon Jun 18 17:18:03 2018

Return TimeDomain instead of RealTimeDomain in the SequenceManager interface.

As a bonus it allowed to remove a dozen of redundant includes.

Bug: 783309
Change-Id: Ib1cd92825c828c2724746f979c5f92e18538b1d4
Reviewed-on: https://chromium-review.googlesource.com/1104419
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568051}
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/base/sequence_manager.h
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/8a5e3489c49885cf220416590ea2a525a772d2cc/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc

Project Member

Comment 51 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/119bc604faa84ebc58ce3dce01e38ebe3927d15d

commit 119bc604faa84ebc58ce3dce01e38ebe3927d15d
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Jun 20 12:49:14 2018

Move SequenceManager interface to //base/sequence_manager.

Bug: 783309
Change-Id: I0e32bfa8001ceb6be444b99852ca73f38dec8bbc
Reviewed-on: https://chromium-review.googlesource.com/1102682
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568804}
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/base/BUILD.gn
[rename] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/base/task/sequence_manager/sequence_manager.h
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/BUILD.gn
[add] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/base/sequence_manager_forward.h
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/common/web_thread_scheduler.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/119bc604faa84ebc58ce3dce01e38ebe3927d15d/third_party/blink/renderer/platform/testing/testing_platform_support.cc

Project Member

Comment 52 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df94b84c3ce80e5d994aea35423dedaa9718319

commit 0df94b84c3ce80e5d994aea35423dedaa9718319
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jun 29 10:13:36 2018

Move TimeDomain to //base/task/sequence_manager.

Also make RealTimeDomain internal.

Bug: 783309
Change-Id: I142aa6f9c13bd6f5ce2211b95dd84a234fc71e0d
Reviewed-on: https://chromium-review.googlesource.com/1118554
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571435}
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/base/BUILD.gn
[rename] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/base/task/sequence_manager/time_domain.h
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.cc
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl.h
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/time_domain.cc
[add] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/time_domain_forward.h
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.h
[modify] https://crrev.com/0df94b84c3ce80e5d994aea35423dedaa9718319/third_party/blink/renderer/platform/scheduler/common/throttling/throttled_time_domain.h

Project Member

Comment 53 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f38001d936d8b2abb5743e85cbc88c72746ae3d2

commit f38001d936d8b2abb5743e85cbc88c72746ae3d2
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jun 29 15:44:36 2018

Delete scheduler/base/task_queue_manager_delegate_for_test.{h|cc}.

These files are dormant and not used anywhere.

Bug: 783309
Change-Id: I18d29d46ab9875b0d273797eeebb2bba4f132c59
Reviewed-on: https://chromium-review.googlesource.com/1120341
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571491}
[delete] https://crrev.com/4d5d2ef8f7e846feb43e17205ea84683bb0182ca/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_delegate_for_test.cc
[delete] https://crrev.com/4d5d2ef8f7e846feb43e17205ea84683bb0182ca/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_delegate_for_test.h

Project Member

Comment 54 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd592fde998e97942d0fe383319684733469032c

commit fd592fde998e97942d0fe383319684733469032c
Author: Greg Kraynov <kraynov@chromium.org>
Date: Fri Jun 29 18:37:37 2018

Introduce MockTimeDomain to replace VirtualTimeDomain in tests.

Since scheduler/base is getting moved to //base/task/sequence_manager
we don't want to explicitly support the concept of virtual time
because it might be confused with the existing mechanism to override
a TickClock in //base. So we can't move VirtualTimeDomain to //base.
It was used in some tests in scheduler/base as a mock time domain,
so this CL makes it explicit and test-only.

Bug: 783309
Change-Id: I0a11e565de94fce06af4aff288427b6bc78e890b
Reviewed-on: https://chromium-review.googlesource.com/1120257
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571562}
[modify] https://crrev.com/fd592fde998e97942d0fe383319684733469032c/base/task/sequence_manager/time_domain.h
[modify] https://crrev.com/fd592fde998e97942d0fe383319684733469032c/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/fd592fde998e97942d0fe383319684733469032c/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_impl_unittest.cc
[modify] https://crrev.com/fd592fde998e97942d0fe383319684733469032c/third_party/blink/renderer/platform/scheduler/base/task_queue_manager_perftest.cc
[modify] https://crrev.com/fd592fde998e97942d0fe383319684733469032c/third_party/blink/renderer/platform/scheduler/base/task_queue_selector_unittest.cc
[add] https://crrev.com/fd592fde998e97942d0fe383319684733469032c/third_party/blink/renderer/platform/scheduler/base/test/mock_time_domain.cc
[add] https://crrev.com/fd592fde998e97942d0fe383319684733469032c/third_party/blink/renderer/platform/scheduler/base/test/mock_time_domain.h
[modify] https://crrev.com/fd592fde998e97942d0fe383319684733469032c/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/fd592fde998e97942d0fe383319684733469032c/third_party/blink/renderer/platform/scheduler/base/virtual_time_domain.h

Project Member

Comment 55 by bugdroid1@chromium.org, Jul 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e2e5567dbb47ebc42288946343d91a6fb79d332

commit 1e2e5567dbb47ebc42288946343d91a6fb79d332
Author: Greg Kraynov <kraynov@chromium.org>
Date: Sun Jul 01 16:07:58 2018

Rename TaskQueueManagerImpl to SequenceManagerImpl.

Bug: 783309
Change-Id: I5072998a38408d328d45aba76893763708ffd4df
Reviewed-on: https://chromium-review.googlesource.com/1120525
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571797}
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/base/task/sequence_manager/lazily_deallocated_deque.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/base/task/sequence_manager/task_queue.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/base/task/sequence_manager/task_queue_impl.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/base/task/sequence_manager/thread_controller.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/base/task/sequence_manager/time_domain.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/README.md
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/graceful_queue_shutdown_helper.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/graceful_queue_shutdown_helper.h
[rename] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/proto/sequence_manager_test_description.proto
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/sequence_manager_forward.h
[rename] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl.cc
[rename] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl.h
[rename] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl_unittest.cc
[rename] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/sequence_manager_perftest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/task_queue.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/task_queue_selector_unittest.cc
[rename] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/test/sequence_manager_for_test.cc
[rename] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/test/sequence_manager_for_test.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/virtual_time_domain.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_helper.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/test/lazy_thread_controller_for_test.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_helper.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
[modify] https://crrev.com/1e2e5567dbb47ebc42288946343d91a6fb79d332/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h

Project Member

Comment 56 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0e9e4b0cada764b2ee831082f9f2e55a37f3f3a

commit e0e9e4b0cada764b2ee831082f9f2e55a37f3f3a
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon Jul 02 10:44:59 2018

Merge VirtualTimeDomain into AutoAdvancingVirtualTimeDomain.

Bug: 783309
Change-Id: I8a684822743221a4e4f17736fcdd48347bf8e271
Reviewed-on: https://chromium-review.googlesource.com/1120326
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571860}
[modify] https://crrev.com/e0e9e4b0cada764b2ee831082f9f2e55a37f3f3a/third_party/blink/renderer/platform/scheduler/BUILD.gn
[delete] https://crrev.com/8858c088023cae8b760cd2d459654685e386840a/third_party/blink/renderer/platform/scheduler/base/virtual_time_domain.cc
[delete] https://crrev.com/8858c088023cae8b760cd2d459654685e386840a/third_party/blink/renderer/platform/scheduler/base/virtual_time_domain.h
[modify] https://crrev.com/e0e9e4b0cada764b2ee831082f9f2e55a37f3f3a/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain.cc
[modify] https://crrev.com/e0e9e4b0cada764b2ee831082f9f2e55a37f3f3a/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/e0e9e4b0cada764b2ee831082f9f2e55a37f3f3a/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/e0e9e4b0cada764b2ee831082f9f2e55a37f3f3a/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc

Project Member

Comment 57 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/445125f5bc126a4fdfc7ed01e6cd966c4984541c

commit 445125f5bc126a4fdfc7ed01e6cd966c4984541c
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon Jul 02 20:53:58 2018

Make SequenceManagerImpl internal.

Bug: 783309
Change-Id: I92091b358d312b12c9fd88f26b4763dc984a6b33
Reviewed-on: https://chromium-review.googlesource.com/1122870
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571991}
[modify] https://crrev.com/445125f5bc126a4fdfc7ed01e6cd966c4984541c/base/task/sequence_manager/task_queue.h
[modify] https://crrev.com/445125f5bc126a4fdfc7ed01e6cd966c4984541c/base/task/sequence_manager/task_queue_impl.h
[modify] https://crrev.com/445125f5bc126a4fdfc7ed01e6cd966c4984541c/base/task/sequence_manager/time_domain.h
[modify] https://crrev.com/445125f5bc126a4fdfc7ed01e6cd966c4984541c/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl.cc
[modify] https://crrev.com/445125f5bc126a4fdfc7ed01e6cd966c4984541c/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl.h
[modify] https://crrev.com/445125f5bc126a4fdfc7ed01e6cd966c4984541c/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl_unittest.cc
[modify] https://crrev.com/445125f5bc126a4fdfc7ed01e6cd966c4984541c/third_party/blink/renderer/platform/scheduler/base/test/sequence_manager_for_test.h
[modify] https://crrev.com/445125f5bc126a4fdfc7ed01e6cd966c4984541c/third_party/blink/renderer/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/445125f5bc126a4fdfc7ed01e6cd966c4984541c/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc

Project Member

Comment 58 by bugdroid1@chromium.org, Jul 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ddbb634e4536dbbe84a5e3739bcb35614158319

commit 4ddbb634e4536dbbe84a5e3739bcb35614158319
Author: Greg Kraynov <kraynov@chromium.org>
Date: Mon Jul 02 20:54:29 2018

Pre-move clean-up in blink's scheduler/base.

- Private constructor for ref-counted class.
- Remove redundant includes.
- Minor style fixes and TODOs.
- Add platform_export.h where needed.

Bug: 783309
Change-Id: I14cc00ef31526ae76f692fd48e3045fa483edb13
Reviewed-on: https://chromium-review.googlesource.com/1122976
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571992}
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/graceful_queue_shutdown_helper.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/real_time_domain.cc
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/real_time_domain.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl.cc
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/sequence_manager_perftest.cc
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/task_queue.cc
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/task_queue_selector.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/task_queue_selector_logic.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/thread_controller_impl.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/work_queue.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/work_queue_sets.cc
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/base/work_queue_sets.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/common/idle_helper.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/common/metrics_helper.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/common/throttling/throttled_time_domain.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/main_thread/prioritize_compositing_after_input_experiment.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/test/lazy_thread_controller_for_test.h
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/4ddbb634e4536dbbe84a5e3739bcb35614158319/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.h

Project Member

Comment 59 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6db9de7420eba7eb245c1683ac812b78b64608d

commit a6db9de7420eba7eb245c1683ac812b78b64608d
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Jul 04 12:21:03 2018

Big blink's scheduler/base to //base/task/sequence_manager move.

Move all the implementation except the test code (to be moved next).

Bug: 783309
Change-Id: Ib79a1bf7e5cc5a5231dcba81b55d78285d5ececf
Reviewed-on: https://chromium-review.googlesource.com/1122126
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572541}
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/BUILD.gn
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/graceful_queue_shutdown_helper.cc
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/graceful_queue_shutdown_helper.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/real_time_domain.cc
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/real_time_domain.h
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/sequence_manager.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/sequence_manager_impl.cc
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/sequence_manager_impl.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/task_queue.cc
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/task_queue.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/task_queue_impl.cc
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/task_queue_impl.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/task_queue_selector.cc
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/task_queue_selector.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/task_queue_selector_logic.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/thread_controller_impl.cc
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/thread_controller_impl.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/time_domain.cc
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/time_domain.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/work_queue.cc
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/work_queue.h
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/work_queue_sets.cc
[rename] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/base/task/sequence_manager/work_queue_sets.h
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/sequence_manager_forward.h
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl_unittest.cc
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/task_queue_forward.h
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/task_queue_impl_forward.h
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/test/sequence_manager_for_test.cc
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/test/sequence_manager_for_test.h
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/time_domain_forward.h
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/work_queue_sets_unittest.cc
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/base/work_queue_unittest.cc
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/a6db9de7420eba7eb245c1683ac812b78b64608d/third_party/blink/renderer/platform/scheduler/test/lazy_thread_controller_for_test.h

Project Member

Comment 60 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ae7ac32360d01c0667d213f8c204aeafd416eba

commit 8ae7ac32360d01c0667d213f8c204aeafd416eba
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Jul 04 14:56:27 2018

Remove SequenceManager forwarding headers.

Removal of unnecessary includes and narrowing down DEPS come next.

Bug: 783309
Change-Id: If413b3d2d64e5a9ad71d613c18fc94fa9fb4988e
Reviewed-on: https://chromium-review.googlesource.com/1125852
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572567}
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/BUILD.gn
[delete] https://crrev.com/362c80256baecfed86dfa88b758b4bf8a7a04f80/third_party/blink/renderer/platform/scheduler/base/sequence_manager_forward.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/base/sequence_manager_perftest.cc
[delete] https://crrev.com/362c80256baecfed86dfa88b758b4bf8a7a04f80/third_party/blink/renderer/platform/scheduler/base/task_queue_forward.h
[delete] https://crrev.com/362c80256baecfed86dfa88b758b4bf8a7a04f80/third_party/blink/renderer/platform/scheduler/base/task_queue_impl_forward.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/base/task_queue_selector_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/base/test/mock_time_domain.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/base/test/test_task_queue.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/base/test/test_task_queue.h
[delete] https://crrev.com/362c80256baecfed86dfa88b758b4bf8a7a04f80/third_party/blink/renderer/platform/scheduler/base/time_domain_forward.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/base/work_queue_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/child/task_queue_with_task_type.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/metrics_helper.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/common/throttling/throttled_time_domain.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/main_thread/prioritize_compositing_after_input_experiment.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/public/worker_scheduler.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler_impl.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.h
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/testing/testing_platform_support.cc
[modify] https://crrev.com/8ae7ac32360d01c0667d213f8c204aeafd416eba/third_party/blink/renderer/platform/timer_test.cc

Project Member

Comment 61 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d6ba62614546d9f12a1553d654eaf11480d22d7

commit 1d6ba62614546d9f12a1553d654eaf11480d22d7
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Jul 11 18:29:48 2018

Move scheduler/base/test to //base/task/sequence_manager/test.

Bug: 783309
Change-Id: I79a8fc81062c46128d1a0d2ee5358f91a7a401e2
Reviewed-on: https://chromium-review.googlesource.com/1133172
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574252}
[add] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/fake_task.cc
[add] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/fake_task.h
[rename] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/lazy_thread_controller_for_test.cc
[add] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/lazy_thread_controller_for_test.h
[rename] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/mock_time_domain.cc
[rename] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/mock_time_domain.h
[rename] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/sequence_manager_for_test.cc
[rename] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/sequence_manager_for_test.h
[rename] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/test_task_queue.cc
[rename] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/test_task_queue.h
[add] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/task/sequence_manager/test/test_task_time_observer.h
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/base/test/BUILD.gn
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/BUILD.gn
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/DEPS
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/base/sequence_manager_fuzzer_processor.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/base/sequence_manager_fuzzer_processor.h
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/base/sequence_manager_impl_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/base/sequence_manager_perftest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/base/task_queue_selector_unittest.cc
[delete] https://crrev.com/8fc67b341c8d30821f9df226a769d97e86523f02/third_party/blink/renderer/platform/scheduler/base/test/fake_task.cc
[delete] https://crrev.com/8fc67b341c8d30821f9df226a769d97e86523f02/third_party/blink/renderer/platform/scheduler/base/test/fake_task.h
[delete] https://crrev.com/8fc67b341c8d30821f9df226a769d97e86523f02/third_party/blink/renderer/platform/scheduler/base/test/test_count_uses_time_source.cc
[delete] https://crrev.com/8fc67b341c8d30821f9df226a769d97e86523f02/third_party/blink/renderer/platform/scheduler/base/test/test_count_uses_time_source.h
[delete] https://crrev.com/8fc67b341c8d30821f9df226a769d97e86523f02/third_party/blink/renderer/platform/scheduler/base/test/test_task_time_observer.h
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/common/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/common/idle_helper_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/common/metrics_helper_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/common/scheduler_helper_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/main_thread/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/main_thread/idle_time_estimator_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_metrics_helper_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/test/DEPS
[delete] https://crrev.com/8fc67b341c8d30821f9df226a769d97e86523f02/third_party/blink/renderer/platform/scheduler/test/lazy_thread_controller_for_test.h
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/test/renderer_scheduler_test_support.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/worker/compositor_thread_scheduler_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/worker/worker_scheduler_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler_unittest.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/testing/DEPS
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.cc
[modify] https://crrev.com/1d6ba62614546d9f12a1553d654eaf11480d22d7/third_party/blink/renderer/platform/testing/testing_platform_support_with_mock_scheduler.h

Project Member

Comment 62 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f4a335894a52fe036f66cc5d8841d7a3c15d98b

commit 8f4a335894a52fe036f66cc5d8841d7a3c15d98b
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Jul 18 09:44:08 2018

Move SequenceManager tests from scheduler/base.

Bug: 783309
Change-Id: I4b3157c03af6df9592da3aa18a5dc3abf58c96c5
Reviewed-on: https://chromium-review.googlesource.com/1136532
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575989}
[modify] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/base/BUILD.gn
[rename] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/base/task/sequence_manager/intrusive_heap_unittest.cc
[rename] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/base/task/sequence_manager/lazily_deallocated_deque_unittest.cc
[rename] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/base/task/sequence_manager/sequence_manager_impl_unittest.cc
[rename] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/base/task/sequence_manager/sequence_manager_perftest.cc
[rename] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/base/task/sequence_manager/task_queue_selector_unittest.cc
[rename] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/base/task/sequence_manager/time_domain_unittest.cc
[rename] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/base/task/sequence_manager/work_queue_sets_unittest.cc
[rename] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/base/task/sequence_manager/work_queue_unittest.cc
[modify] https://crrev.com/8f4a335894a52fe036f66cc5d8841d7a3c15d98b/third_party/blink/renderer/platform/scheduler/BUILD.gn

Cc: eseckler@chromium.org
Status: Fixed (was: Started)
This one is done, but some additional refinements would be nice.

Remove TaskQueueImpl references from renderer
https://bugs.chromium.org/p/chromium/issues/detail?id=859837

Maybe re-think TimeDomain architecture
https://bugs.chromium.org/p/chromium/issues/detail?id=857101

Simplify priorities
https://bugs.chromium.org/p/chromium/issues/detail?id=847858

Simplify non-nestable tasks logic
https://bugs.chromium.org/p/chromium/issues/detail?id=845437

Sign in to add a comment