New issue
Advanced search Search tips

Issue 783283 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocking:
issue 703263
issue 777914



Sign in to add a comment

cc_unittest CommitToPendingTreeLayerTreeHostImplTest.GPUMemoryForSmallLayerHistogramTest is flaky

Project Member Reported by sunxd@chromium.org, Nov 9 2017

Issue description

CommitToPendingTreeLayerTreeHostImplTest.GPUMemoryForSmallLayerHistogramTest often fails if runn with all other cc unit tests. It does not fail if run alone.

Here is the failure output:
[ RUN      ] CommitToPendingTreeLayerTreeHostImplTest.GPUMemoryForSmallLayerHistogramTest
[27032:27032:1109/133426.258839:595572228068:FATAL:histogram_base.cc(75)] Check failed: StringPiece(histogram_name()) == name (Compositing.(null).CachedImagesCount.Software vs. Compositing.Renderer.CachedImagesCount.Software)
#0 0x7f108de08ebd base::debug::StackTrace::StackTrace()
#1 0x7f108de072ec base::debug::StackTrace::StackTrace()
#2 0x7f108de8ecaa logging::LogMessage::~LogMessage()
#3 0x7f108deec023 base::HistogramBase::CheckName()
#4 0x7f1090216706 cc::SoftwareImageDecodeCache::~SoftwareImageDecodeCache()
#5 0x7f1090216829 cc::SoftwareImageDecodeCache::~SoftwareImageDecodeCache()
#6 0x7f10902bebfc cc::LayerTreeHostImpl::CleanUpTileManagerAndUIResources()
#7 0x7f10902cafb9 cc::LayerTreeHostImpl::ReleaseLayerTreeFrameSink()
#8 0x000000da79a1 cc::(anonymous namespace)::LayerTreeHostImplTest::TestGPUMemoryForTilings()
#9 0x000000da7082 cc::(anonymous namespace)::CommitToPendingTreeLayerTreeHostImplTest_GPUMemoryForSmallLayerHistogramTest_Test::TestBody()
#10 0x0000012df4ce testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#11 0x0000012d3a52 testing::internal::HandleExceptionsInMethodIfSupported<>()
#12 0x0000012be106 testing::Test::Run()
#13 0x0000012bec5d testing::TestInfo::Run()
#14 0x0000012bf6bc testing::TestCase::Run()
#15 0x0000012cb3dc testing::internal::UnitTestImpl::RunAllTests()
#16 0x0000012df5de testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#17 0x0000012d5092 testing::internal::HandleExceptionsInMethodIfSupported<>()
#18 0x0000012cb01e testing::UnitTest::Run()
#19 0x00000146d6c1 RUN_ALL_TESTS()
#20 0x00000146b2c2 base::TestSuite::Run()
#21 0x0000008499dd _ZN4base8internal13FunctorTraitsIMNS_13WaitableEventEFvvEvE6InvokeIPS2_JEEEvS4_OT_DpOT0_
#22 0x000000849954 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMNS_13WaitableEventEFvvEJPS4_EEEvOT_DpOT0_
#23 0x000000849905 _ZN4base8internal7InvokerINS0_9BindStateIMNS_13WaitableEventEFvvEJNS0_17UnretainedWrapperIS3_EEEEEFvvEE7RunImplIS5_NSt3__15tupleIJS7_EEEJLm0EEEEvOT_OT0_NSC_16integer_sequenceImJXspT1_EEEE
#24 0x000000cb4b1c _ZN4base8internal7InvokerINS0_9BindStateIMN2cc28ImageAnimationControllerTestEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#25 0x00000066c58d _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#26 0x000001478207 base::(anonymous namespace)::LaunchUnitTestsInternal()
#27 0x000001478075 base::LaunchUnitTests()
#28 0x000001278e2e main
#29 0x7f108bbb8f45 __libc_start_main
#30 0x0000004da029 <unknown>

[1520/2845] CommitToPendingTreeLayerTreeHostImplTest.GPUMemoryForSmallLayerHistogramTest (CRASHED)

 

Comment 1 by sunxd@chromium.org, Nov 9 2017

It looks like a racing condition: some other test changed the metric client name.
Summary: cc_unittest CommitToPendingTreeLayerTreeHostImplTest.GPUMemoryForSmallLayerHistogramTest is flaky (was: cc_unittest CommitToPendingTreeLayerTreeHostImplTest.GPUMemoryForSmallLayerHistogramTest is flacky)

Comment 3 by fsamuel@google.com, Nov 10 2017

Owner: yigu@chromium.org
Status: Assigned (was: Untriaged)
+yigu@ who modified this test last. Thoughts on this?

Comment 4 by yigu@chromium.org, Nov 10 2017

It seems the client name has been reset to "null" during the destruction which crashed the metric name DCHECK. Need further investigation.

Comment 5 by danakj@chromium.org, Nov 15 2017

Blocking: 703263
Labels: -Pri-2 Pri-1

Comment 6 by vmp...@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)
This was fixed in crrev.com/4749ce297c7

Sign in to add a comment