Set device name as parameter in "Learn more" link URL |
||||||
Issue descriptionCurrently, we direct to: https://support.google.com/chromebook?p=instant_tethering However, the feature is enabled only on some devices, so we want to display a different page depending on the device. agang@ suggests sending the device name as a URL parameter. Example for Eve: https://support.google.com/chromebook?p=instant_tethering&b=eve To get the board name, we should use base::SysInfo::GetLsbReleaseBoard(): https://cs.chromium.org/chromium/src/base/sys_info.h?q=GetLsbReleaseBoard We'll need to figure out the correct way to pass this value to the settings page as well.
,
Nov 10 2017
,
Nov 10 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b915363730541457a33fa0706505a4f85dfbe2eb commit b915363730541457a33fa0706505a4f85dfbe2eb Author: Kyle Horimoto <khorimoto@google.com> Date: Fri Nov 10 18:58:05 2017 [CrOS Tether] Add device type parameter to "Learn More" link. Instant Tethering is not available on all devices, so we only want the help article to show up for devices which have the feature. This change adds a parameter to the "Learn More" link URL which will be used by the back-end to determine which page to serve. Bug: 783273 , 672263 Change-Id: I4ae29af9fbef6de662218d7a988c6af1a4d7b854 Reviewed-on: https://chromium-review.googlesource.com/762161 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#515618} [modify] https://crrev.com/b915363730541457a33fa0706505a4f85dfbe2eb/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Nov 13 2017
,
Nov 13 2017
Please mark as fixed so that TE can verify
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c12c07ecfa73fb31c91706638ff6c3eb5c3dceb8 commit c12c07ecfa73fb31c91706638ff6c3eb5c3dceb8 Author: Kyle Horimoto <khorimoto@google.com> Date: Mon Nov 13 21:28:12 2017 [CrOS Tether] Add device type parameter to "Learn More" link. Instant Tethering is not available on all devices, so we only want the help article to show up for devices which have the feature. This change adds a parameter to the "Learn More" link URL which will be used by the back-end to determine which page to serve. TBR=khorimoto@google.com (cherry picked from commit b915363730541457a33fa0706505a4f85dfbe2eb) Bug: 783273 , 672263 Change-Id: I4ae29af9fbef6de662218d7a988c6af1a4d7b854 Reviewed-on: https://chromium-review.googlesource.com/762161 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#515618} Reviewed-on: https://chromium-review.googlesource.com/767018 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#468} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/c12c07ecfa73fb31c91706638ff6c3eb5c3dceb8/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Nov 13 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by khorimoto@chromium.org
, Nov 10 2017