AssertionError in ContextualSearchTabHelper.addContextualSearchHooks on incremental builds |
||||
Issue descriptionChrome Version: ToT (master) at bd4e3a9b4d6469e2e191747bb00c3779d9d46e10 OS: Android What steps will reproduce the problem? (1) Uninstall Chromium $ out/AndroidDebug/bin/chrome_public_apk uninstall (2) Build and install chrome_public_apk_incremental: $ ninja -C out/AndroidDebug -j2000 -l20 chrome_public_apk_incremental && out/AndroidDebug/bin/chrome_public_apk install --incremental (3) Launch Chromium and tap/scroll when the page loads Chromium crashes with this stack trace retrieved from tombstones: I 38.218s Main Java stderr from crashing pid (may identify underlying Java exception): I 38.218s Main at java.lang.reflect.Method.invoke(Native Method) I 38.218s Main at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240) I 38.218s Main at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767) I 38.218s Main java.lang.AssertionError I 38.218s Main at org.chromium.chrome.browser.contextualsearch.ContextualSearchTabHelper.addContextualSearchHooks(ContextualSearchTabHelper.java:209) I 38.218s Main at org.chromium.chrome.browser.contextualsearch.ContextualSearchTabHelper.updateContextualSearchHooks(ContextualSearchTabHelper.java:198) I 38.218s Main at org.chromium.chrome.browser.contextualsearch.ContextualSearchTabHelper.access$100(ContextualSearchTabHelper.java:26) I 38.218s Main at org.chromium.chrome.browser.contextualsearch.ContextualSearchTabHelper$1.onTemplateURLServiceChanged(ContextualSearchTabHelper.java:98) I 38.218s Main at org.chromium.chrome.browser.search_engines.TemplateUrlService.onTemplateURLServiceChanged(TemplateUrlService.java:254) My gn args: target_os = "android" enable_chrome_android_internal = false use_goma = true enable_incremental_javac = true disable_incremental_isolated_processes = true is_component_build = true dcheck_always_on = false
,
Nov 10 2017
I'm having trouble reproducing this crash following the instructions exactly. I'm using a N5. Anita, any hints about device or environment that might be helpful? In particular, when I launch I get the NTP, but you said "Launch Chromium and tap/scroll when the page loads" -- which page? Are you using an intent to launch some page? Do you have the First Run disabled -- I walk through that and don't sign in. I've tried tapping on the NTP suggestions from Zine. Or are you saying to tap on the NTP? Ramine or Sailaja, can one of you check if there are other crashes like this, or give me brief instructions on how to look myself? I could apply the same fix as in issue 782324 at this location, if all else fails.
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad080c5f02bd6a5fb53f4fe4df3497c4c1151205 commit ad080c5f02bd6a5fb53f4fe4df3497c4c1151205 Author: Donn Denman <donnd@google.com> Date: Sat Nov 11 00:13:48 2017 [TTS] Update last assert in CSearchTabHelper Speculative fix for an assert reported by a developer. Update an overly aggressive assert recently landed in ContextualSearchTabHelper when reparenting. BUG= 783225 , 775813 Change-Id: Ib8f54e0b5bfcf8dde785e0c25098771b21c1b420 Reviewed-on: https://chromium-review.googlesource.com/764667 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#515755} [modify] https://crrev.com/ad080c5f02bd6a5fb53f4fe4df3497c4c1151205/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa7ee4b4fc4112a8298c931c6752b8c2e1668ab2 commit aa7ee4b4fc4112a8298c931c6752b8c2e1668ab2 Author: Donn Denman <donnd@google.com> Date: Tue Nov 14 19:16:37 2017 [TTS] Update last assert in CSearchTabHelper Speculative fix for an assert reported by a developer. Update an overly aggressive assert recently landed in ContextualSearchTabHelper when reparenting. BUG= 783225 , 775813 TBR=donnd@google.com (cherry picked from commit ad080c5f02bd6a5fb53f4fe4df3497c4c1151205) Change-Id: Ib8f54e0b5bfcf8dde785e0c25098771b21c1b420 Reviewed-on: https://chromium-review.googlesource.com/764667 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#515755} Reviewed-on: https://chromium-review.googlesource.com/769244 Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#488} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/aa7ee4b4fc4112a8298c931c6752b8c2e1668ab2/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Nov 14 2017
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e646f0eb43aa350ba004aeb2f26a3ac22365108 commit 4e646f0eb43aa350ba004aeb2f26a3ac22365108 Author: Claude Masso <cmasso@chromium.org> Date: Tue Nov 14 23:32:30 2017 Revert "[TTS] Update last assert in CSearchTabHelper" This reverts commit aa7ee4b4fc4112a8298c931c6752b8c2e1668ab2. Reason for revert: <INSERT REASONING HERE> Original change's description: > [TTS] Update last assert in CSearchTabHelper > > Speculative fix for an assert reported by a developer. > Update an overly aggressive assert recently landed in > ContextualSearchTabHelper when reparenting. > > BUG= 783225 , 775813 > TBR=donnd@google.com > > (cherry picked from commit ad080c5f02bd6a5fb53f4fe4df3497c4c1151205) > > Change-Id: Ib8f54e0b5bfcf8dde785e0c25098771b21c1b420 > Reviewed-on: https://chromium-review.googlesource.com/764667 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#515755} > Reviewed-on: https://chromium-review.googlesource.com/769244 > Reviewed-by: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/branch-heads/3239@{#488} > Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} TBR=donnd@chromium.org,twellington@chromium.org Change-Id: I6d3881b5814c5778e001de9a6d9ba0fffccaff94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783225 , 775813 Reviewed-on: https://chromium-review.googlesource.com/770030 Reviewed-by: Claude Masso <cmasso@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#496} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/4e646f0eb43aa350ba004aeb2f26a3ac22365108/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a3a03334a0bf43b3415767d78b8200acd5f8462 commit 8a3a03334a0bf43b3415767d78b8200acd5f8462 Author: Donn Denman <donnd@google.com> Date: Thu Nov 16 00:54:14 2017 Reland "[TTS] Update last assert in CSearchTabHelper" This is a reland of aa7ee4b4fc4112a8298c931c6752b8c2e1668ab2 Original change's description: > [TTS] Update last assert in CSearchTabHelper > > Speculative fix for an assert reported by a developer. > Update an overly aggressive assert recently landed in > ContextualSearchTabHelper when reparenting. > > BUG= 783225 , 775813 > TBR=donnd@google.com > > (cherry picked from commit ad080c5f02bd6a5fb53f4fe4df3497c4c1151205) > > Change-Id: Ib8f54e0b5bfcf8dde785e0c25098771b21c1b420 > Reviewed-on: https://chromium-review.googlesource.com/764667 > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Donn Denman <donnd@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#515755} > Reviewed-on: https://chromium-review.googlesource.com/769244 > Reviewed-by: Donn Denman <donnd@chromium.org> > Cr-Commit-Position: refs/branch-heads/3239@{#488} > Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} Bug: 783225 , 775813 Change-Id: I975ba6ef5f3ded9ecd543da801bfd76a52189f35 Reviewed-on: https://chromium-review.googlesource.com/773439 Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#513} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/8a3a03334a0bf43b3415767d78b8200acd5f8462/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java |
||||
►
Sign in to add a comment |
||||
Comment 1 by donnd@google.com
, Nov 9 2017Status: Assigned (was: Untriaged)