New issue
Advanced search Search tips

Issue 783192 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Create EarlGrey helpers to open/close tabs and sycnhronize

Project Member Reported by baxley@chromium.org, Nov 9 2017

Issue description

Currently, methods in chrome_test_util to open and close (main and incognito) tabs don't properly synchronize with the UI.

We should add methods in ChromeEarlGrey to do this.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 9

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -baxley@chromium.org -liaoyuke@chromium.org -huangml@chromium.org justincohen@chromium.org
|[ChromeEarlGrey openNewTab];| seems to be what we need.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4573545a554908511b7979b8a2367f5754c5a82

commit b4573545a554908511b7979b8a2367f5754c5a82
Author: Justin Cohen <justincohen@google.com>
Date: Mon Nov 12 21:49:45 2018

[ios] Wait for new tab page load and animations to complete in tests.

Non CRWNativeContent NTP pages do not load instantly, and instead
load similarly to web view page loads.  Add logic to wait for the
webState to finish loading and the NTP animation to complete.

Bug:  783192 
Change-Id: If3d47e7467c2831697ae8baf9fd8f6755aa535af
Reviewed-on: https://chromium-review.googlesource.com/c/1324229
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607338}
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/device_sharing/handoff_manager_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/metrics/ukm_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/net/cookies_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ntp_tiles/ntp_tiles_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/prerender/prerender_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/translate/translate_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/content_suggestions/content_suggestions_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/content_suggestions/ntp_home_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/download/download_manager_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/infobars/infobar_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/recent_tabs/recent_tabs_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/settings/sync_utils/sync_fake_server_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/ui/toolbar/adaptive_toolbar_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/web/tab_order_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/browser/web/window_open_by_dom_egtest.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/test/earl_grey/chrome_earl_grey.h
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/test/earl_grey/chrome_earl_grey.mm
[modify] https://crrev.com/b4573545a554908511b7979b8a2367f5754c5a82/ios/chrome/test/earl_grey/chrome_test_case.mm

Owner: justincohen@chromium.org
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9df6f8704a223f176576bf6992e767508ec3dbc4

commit 9df6f8704a223f176576bf6992e767508ec3dbc4
Author: Justin Cohen <justincohen@google.com>
Date: Wed Nov 14 20:22:40 2018

[ios] Add more ios egtest helpers to synchronise closing tabs.

Bug:  783192 
Change-Id: I54f44ee294418a5de54ba59456e0e672893697f4
Reviewed-on: https://chromium-review.googlesource.com/c/1334854
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608103}
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/device_sharing/handoff_manager_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/metrics/ukm_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/net/cookies_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/ui/download/download_manager_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/ui/infobars/infobar_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/ui/recent_tabs/recent_tabs_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/ui/settings/settings_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/ui/tab_grid/tab_grid_transition_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/browser/web/window_open_by_dom_egtest.mm
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/test/earl_grey/chrome_earl_grey.h
[modify] https://crrev.com/9df6f8704a223f176576bf6992e767508ec3dbc4/ios/chrome/test/earl_grey/chrome_earl_grey.mm

Status: Fixed (was: Started)

Sign in to add a comment